strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
libreoffice-online/browser/.eslintrc

58 lines
1.4 KiB
Text
Raw Normal View History

Unmodified Leaflet Checkout date: 09/03/2015 HEAD: a92c8a3c21f8d580de2dfd1e937ea90db76787b6
2015-03-09 05:16:17 -05:00
{
Add prettier Prettier is a code formatter for javascript/typescript. It's relatively common to see complaints about style in pull requests or inconsistent style getting in to Collabora Online. Also, without a formatter it's harder for editors to automatically format code in sensible and consistent ways Prettier doesn't have many options, but those which it does have I have set to the closest values to current behavior (e.g. single quotes) in order to minimize unnecessary changes This commit doesn't format all existing files. Doing so would cause blames, cherry-picks and diffs to become much less useful. Instead, we use browser/.beforeprettier to list all files that would need to be changed, and this file is ignored. You are encouraged but not required to set your editor's equivalent of 'editor.formatOnSaveMode' to only format changed lines This commit also does format of docstatefunctions.js, previously it did not in to check that an incorrectly-formatted file could fail CI. Now it does to make sure that formatting fixes the issue. This file was chosen because it is very new and very small. Change-Id: Ie6067f34aa658f887e149a08aebd0180b2354005 Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-12-18 12:27:02 -06:00
"extends": [
"eslint:recommended",
"prettier"
],
Unmodified Leaflet Checkout date: 09/03/2015 HEAD: a92c8a3c21f8d580de2dfd1e937ea90db76787b6
2015-03-09 05:16:17 -05:00
"rules": {
"no-mixed-spaces-and-tabs": [2, "smart-tabs"],
"no-lonely-if": 2,
"no-underscore-dangle": 0,
"no-constant-condition": 0,
"strict": 0,
Make eslint more strict, and fix all the problems reported The new checks should help keep the codebase a bit cleaner from now. Change-Id: Ib1d77af00e234b8eeb34b09beffc24b95c2eeafc
2017-12-19 06:41:45 -06:00
"no-shadow": 0,
eslint: Enable "semi" rule as an error. This checks whether all statements end with a semicolon. We already use this rule in the code, so I enable to check this rule by eslint to keep the code consistent. Change-Id: I5ea46376d2b6fb488224d4d69e4d117139763a8c Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87154 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-16 08:44:23 -06:00
"no-console": 0,
disable no-control-regex check of eslint We do want control characters in regex in loleaflet/src/map/Clipboard.js Change-Id: I4e393cd57afc42cbb30e8c63f2a497519942411a
2020-10-19 09:11:15 -05:00
"no-control-regex": 0,
loleaflet: Bump eslint version to 4.0.0 Change-Id: I4d04d5f2037c6af61050f94d28e7781a14cc1210
2020-10-20 14:05:29 -05:00
"no-useless-escape": 0,
Make eslint in make check fail on eslint warnings As discussed [on Matrix](https://col.la/suppresseslintindevelopment) the set of things we want to pick up in CI and development are different. Specifically, there are some things that only get in the way during development but should not be allowed in merged code. Examples are 'debugger' statemens, dead code (e.g. resulting from 'if (false)') and unused variables. After #7822 there are no more eslint warnings, so we can use it as a separate state for these issues that should only block in CI. This commit make make check run eslint and fail if it receives any warnings, and changes those 3 errors so that they only emit warnings. It's expected that there are more annoying warnings which I've missed, if you have any please make a followup change! This commit explicitly does not deal with formatting-related issues (e.g. requiring single quotes for strings in eslint) as though they can be annoying there's no reason why they should change between development and master... another followup to improve linting experience could be to use an autoformatter so the computer fixes the formatting for you, however that's out-of-scope for this commit Change-Id: I036afac5ef5056a9cc2effc21e31165aa1436ad2 Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-12-18 10:25:40 -06:00
"no-redeclare": 0,
/// Rules that are set to warn will fail in CI but not when building for development:
"no-debugger": 1,
"no-unreachable": 1,
"no-unused-vars": 1,
Unmodified Leaflet Checkout date: 09/03/2015 HEAD: a92c8a3c21f8d580de2dfd1e937ea90db76787b6
2015-03-09 05:16:17 -05:00
},
"globals": {
"L": true,
"module": false,
"define": false
},
"env": {
"browser": true
cypress: new impress editing tests Single- and double-click starts editing text-boxes in Impress. Single-clicking works only on text, not in the white-space. Merges an existing test with a new one to minimize redundancy where there is overlap. Improved helpers to minimize duplication and update a single place when there are changes to the common operations/checks. ESLint version set to 6 to support the inline closure syntax that 5 doesn't support. This is only used for tests, so perhaps we should have a different ESLint config for leaflet to avoid breaking IE11, which is pre-6. Change-Id: I14ee65b18e310f4ff6b93ce81580b3d6aba0fa03 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90360 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-01 09:48:10 -06:00
},
es2015: bump eslint version - allow ES2015 in JS Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I2f0f17d6fbb49d8205d9825f0bdf74b3076afacc
2024-02-08 13:43:06 -06:00
"parserOptions": {
es2017: bump eslint version This spec was released 7 years ago, and allows e.g. async/await, which can result in more readable code in some cases. There is danger that we return to the main loop too easily using this construct, so no suggestion to rewrite any of the existing code to use this, as that can have side effects on how e.g. we process incoming websocket messages. Do use await at a single place to make sure await can be indeed used. Thanks Hubert to notice that the await-using function itself has to be async, the error message from eslint isn't too clear in that case. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I05b17658fcfab3d20a7e1e8aedf733ef6c7764f5
2024-02-20 01:14:53 -06:00
"ecmaVersion": 2017
es2015: bump eslint version - allow ES2015 in JS Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I2f0f17d6fbb49d8205d9825f0bdf74b3076afacc
2024-02-08 13:43:06 -06:00
},
lint typescript files too Fix some issues it found and disable the following checks for now. Some of them needs module support to work and some of them needs project compilation using tsc rather than per file compilation. cypress_test/ extends loleaflet's eslintrc so, its package.json needs to have the typescript lint plugin as well. Disabled checks: @typescript-eslint/no-unused-vars // This can be enabled after fixing all places it finds. @typescript-eslint/no-inferrable-types // Lets do explicit typing whenever we can. no-var // This needs a lot of conversion of var to let. @typescript-eslint/no-explicit-any @typescript-eslint/no-namespace // ES5 has no module support no-inner-declarations // ,, no-constant-condition // This is sometimes useful @typescript-eslint/triple-slash-reference // ES5 no module support. Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Change-Id: Ib4fd8b4fcee42216d4322fd043a1873302db375a
2021-04-07 00:57:21 -05:00
"overrides": [
{
"files": ["**/*.ts"],
"parser": "@typescript-eslint/parser",
"plugins": [
"@typescript-eslint"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
],
"rules": {
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-inferrable-types": "off",
"no-var": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-namespace": "off",
"no-inner-declarations": "off",
"no-constant-condition": "off",
"@typescript-eslint/triple-slash-reference": "off"
}
}
]
Unmodified Leaflet Checkout date: 09/03/2015 HEAD: a92c8a3c21f8d580de2dfd1e937ea90db76787b6
2015-03-09 05:16:17 -05:00
}
Reference in a new issue Copy permalink