strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
libreoffice-online/wsd/UserMessages.hpp

18 lines
804 B
C++
Raw Normal View History

loolwsd: cleanup and improve WSD request handlers Standardized error handling in request-handlers. There is a new family of internal exeptions designed to signify the type of error and how to handle it. All handlers must throw one of those errors and they will be translated to the correct HTTP response when caught. Since some requests send a response as part of their handling (convert-to, for example) those handlers must return a flag signlaning whether or not they sent a response. If not, HTTP OK response is sent at the end of the handler. To complicate things, some requests upgrade the connection to WebSocket. In those cases errors must be sent via the WebSocket and not as an HTTP response. The error message sent can (and in most cases should) be displayed to the end-user. A new file, UserMessages.hpp, has been added to hold user-visible messages that can be reviewed and translated. Change-Id: Icc725f3313446d4514cf6d092635158ee7171f5d Reviewed-on: https://gerrit.libreoffice.org/24133 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 11:56:23 -05:00
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
// A list of user-visible messages.
// This list is intended to be centralized for review and i18n support.
Use #pragma once LibreOffice core uses that, too, and we support an even more restricted set of compilers. Change-Id: I0d0e2c8608e323eb5ef0f35ee8c46d02ab49a745 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92467 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-18 03:39:50 -05:00
#pragma once
loolwsd: cleanup and improve WSD request handlers Standardized error handling in request-handlers. There is a new family of internal exeptions designed to signify the type of error and how to handle it. All handlers must throw one of those errors and they will be translated to the correct HTTP response when caught. Since some requests send a response as part of their handling (convert-to, for example) those handlers must return a flag signlaning whether or not they sent a response. If not, HTTP OK response is sent at the end of the handler. To complicate things, some requests upgrade the connection to WebSocket. In those cases errors must be sent via the WebSocket and not as an HTTP response. The error message sent can (and in most cases should) be displayed to the end-user. A new file, UserMessages.hpp, has been added to hold user-visible messages that can be reviewed and translated. Change-Id: Icc725f3313446d4514cf6d092635158ee7171f5d Reviewed-on: https://gerrit.libreoffice.org/24133 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 11:56:23 -05:00
wsd: spell out non-trivial autos to improve readability Change-Id: I0e1f169fc39e5c722704e1cae487147d929f7350
2018-02-07 03:17:59 -06:00
constexpr const char* SERVICE_UNAVAILABLE_INTERNAL_ERROR = "error: cmd=socket kind=serviceunavailable";
Only apply hard limit when configured with support key In other case, show the warning to all users (instead of just the last one) and link to our get professional help page. Change-Id: Id443ba6427acd4c05f7e0e2ce86025acfb553265 Reviewed-on: https://gerrit.libreoffice.org/49673 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-13 09:36:38 -06:00
constexpr const char* PAYLOAD_UNAVAILABLE_LIMIT_REACHED = "error: cmd=socket kind=hardlimitreached params=%u,%u";
constexpr const char* PAYLOAD_INFO_LIMIT_REACHED = "info: cmd=socket kind=limitreached params=%u,%u";
loolwsd: cleanup and improve WSD request handlers Standardized error handling in request-handlers. There is a new family of internal exeptions designed to signify the type of error and how to handle it. All handlers must throw one of those errors and they will be translated to the correct HTTP response when caught. Since some requests send a response as part of their handling (convert-to, for example) those handlers must return a flag signlaning whether or not they sent a response. If not, HTTP OK response is sent at the end of the handler. To complicate things, some requests upgrade the connection to WebSocket. In those cases errors must be sent via the WebSocket and not as an HTTP response. The error message sent can (and in most cases should) be displayed to the end-user. A new file, UserMessages.hpp, has been added to hold user-visible messages that can be reviewed and translated. Change-Id: Icc725f3313446d4514cf6d092635158ee7171f5d Reviewed-on: https://gerrit.libreoffice.org/24133 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-16 11:56:23 -05:00
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
Reference in a new issue Copy permalink