strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wsd: test: http: support external regression-test server

Browse source 
Change-Id: I82b4ab126e85be5b414f7dac138fdb7e1780cf9a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This commit is contained in:
Ashod Nakashian 2021-03-20 13:55:07 -04:00 committed by Ashod Nakashian
parent 4d413af916
commit 0d0dbaea79
1 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
test/HttpRequestTests.cpp
View file

@ -26,6 +26,11 @@
#include <Util.hpp>
#include <helpers.hpp>
/// When enabled, in addition to the loopback
/// server, an external server will be used
/// to check for regressions.
#define ENABLE_EXTERNAL_REGRESSION_CHECK
/// http::Request unit-tests.
/// FIXME: use loopback and avoid depending on external services.
/// Currently we need to rely on external services to validate
@ -251,6 +256,11 @@ void HttpRequestTests::test500GetStatuses()
std::pair<std::shared_ptr<Poco::Net::HTTPResponse>, std::string> pocoResponse;
if (statusCode > 100)
pocoResponse = helpers::pocoGet(secure, Host, port, url);
#ifdef ENABLE_EXTERNAL_REGRESSION_CHECK
std::pair<std::shared_ptr<Poco::Net::HTTPResponse>, std::string> pocoResponseExt;
if (statusCode > 100)
pocoResponseExt = helpers::pocoGet(secure, "httpbin.org", 80, url);
#endif
const std::shared_ptr<const http::Response> httpResponse = httpSession->response();
@ -271,10 +281,19 @@ void HttpRequestTests::test500GetStatuses()
// Poco throws exception "No message received" for 1xx Status Codes.
if (statusCode > 100)
{
const bool checkReasonPhrase = (statusCode != 103 && statusCode != 208);
const bool checkBody = (statusCode != 402);
compare(*pocoResponse.first, pocoResponse.second, *httpResponse, checkReasonPhrase,
checkBody);
compare(*pocoResponse.first, pocoResponse.second, *httpResponse, true, true);
#ifdef ENABLE_EXTERNAL_REGRESSION_CHECK
// These Status Codes are not recognized by httpbin.org,
// so we get "unknown" and must skip comparing them.
const bool checkReasonPhrase
= (statusCode != 103 && statusCode != 208 && statusCode != 413 && statusCode != 414
&& statusCode != 416 && statusCode != 421 && statusCode != 425
&& statusCode != 440 && statusCode != 508 && statusCode != 511);
const bool checkBody = (statusCode != 402 && statusCode != 418);
compare(*pocoResponseExt.first, pocoResponseExt.second, *httpResponse,
checkReasonPhrase, checkBody);
#endif
}
}