strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

loolwsd: Avoid unnecessary copying

Browse source 
Change-Id: Iff888e5ff4577f20fae63a7b62ab1481ea2d71ed
This commit is contained in:
Pranav Kant 2016-03-10 17:59:55 +05:30
parent 589261d9ed
commit 3731f0c0d7
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
loolwsd/AdminModel.hpp
View file

@ -84,8 +84,7 @@ public:
void addView(int nSessionId)
{
std::pair<std::map<int, View>::iterator, bool > ret;
ret = _views.insert(std::pair<int, View>(nSessionId, View(nSessionId)));
const auto ret = _views.emplace(nSessionId, View(nSessionId));
if (!ret.second)
{
Log::warn() << "View with SessionID [" + std::to_string(nSessionId) + "] already exists." << Log::end;
@ -287,7 +286,7 @@ public:
void subscribe(int nSessionId, std::shared_ptr<Poco::Net::WebSocket>& ws)
{
auto ret = _subscribers.insert(std::pair<int, Subscriber>(nSessionId, Subscriber(nSessionId, ws)));
const auto ret = _subscribers.emplace(nSessionId, Subscriber(nSessionId, ws));
if (!ret.second)
{
Log::warn() << "Subscriber already exists" << Log::end;
@ -317,8 +316,7 @@ private:
// Prolly, *move* expired documents to another container (?)
void addDocument(Poco::Process::PID pid, std::string url)
{
std::pair<std::map<Poco::Process::PID, Document>::iterator, bool > ret;
ret = _documents.insert(std::pair<Poco::Process::PID, Document>(pid, Document(pid, url)));
const auto ret = _documents.emplace(pid, Document(pid, url));
if (!ret.second)
{
Log::warn() << "Document with PID [" + std::to_string(pid) + "] already exists." << Log::end;