From 54e5a1000be777dbb9732b0f9c921983b6cc119c Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Tue, 4 Jun 2019 09:14:26 +0200 Subject: [PATCH] kit: mark Document as final Document has to be final: its constructor calls sendTextFrame(), which calls the virtual sendFrame(). So the only situation where this code works correctly is when Document is never subclassed. Change-Id: I7c13abdae57d9e1ba3416ec1963b58bce0d42e6f --- kit/Kit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kit/Kit.cpp b/kit/Kit.cpp index 99d34bf73..b18e62c74 100644 --- a/kit/Kit.cpp +++ b/kit/Kit.cpp @@ -855,7 +855,7 @@ public: /// per process. But for security reasons don't. /// However, we could have a loolkit instance /// per user or group of users (a trusted circle). -class Document : public DocumentManagerInterface +class Document final : public DocumentManagerInterface { public: /// We have two types of password protected documents