strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mobilewizard: warn children data type check

Browse source 
Occurs when using the latest LO master branch
the mobile wizard fails:

Util.js:107 Uncaught RangeError: Maximum call stack size exceeded
    at String.split (<anonymous>)
    at Object.splitWords (Util.js:107)
    at NewClass.on (Events.js:20)
    at Function.listenNumericChanges (Control.JSDialogBuilder.js:124)
    at _formattedfieldControl (Control.JSDialogBuilder.js:1312)
    at NewClass.build (Control.MobileWizardBuilder.js:145)
    at NewClass.build (Control.MobileWizardBuilder.js:150)
    at NewClass.build (Control.MobileWizardBuilder.js:150)
    at NewClass.build (Control.MobileWizardBuilder.js:150)
    at NewClass.build (Control.MobileWizardBuilder.js:150)

The builder recursive looks like an infinity loop,
and the cause is that the server is not sending the array children
data type.

Change-Id: I298c239b6018a457d3825be886ea22cb984f13cc
Signed-off-by: Henry Castro <hcastro@collabora.com>
This commit is contained in:
Henry Castro 2020-12-03 08:32:01 -04:00
parent d7bb312776
commit 5a65a06a0a
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
loleaflet/src/layer/tile/TileLayer.js
View file

@ -1045,6 +1045,12 @@ L.TileLayer = L.GridLayer.extend({
_onJSDialogMsg: function (textMsg) {
if (window.mode.isMobile()) {
var msgData = JSON.parse(textMsg.substring('jsdialog:'.length + 1));
if (msgData.children && !L.Util.isArray(msgData.children)) {
console.warn('_onJSDialogMsg: The children\'s data should be created of array type');
return;
}
if (msgData.type == 'borderwindow')
return;
if (msgData.enabled) {