strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

jsdialog: use attribute not class for disabled state

Browse source 
- but still use class for css rules
- after rework in styling to use attribute we can drop that

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I568eedf45440f6636c31430cb98adcfdeab6aa4e
This commit is contained in:
Szymon Kłos 2024-03-31 22:13:05 +02:00 committed by Gökay ŞATIR
parent 5224c3c72e
commit 7a087600e9
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
browser/src/control/Control.JSDialogBuilder.js
View file

@ -14,7 +14,7 @@
* from the JSON description provided by the server.
*/
/* global app $ w2ui _ L JSDialog */
/* global app $ _ L JSDialog */
L.Control.JSDialogBuilder = L.Control.extend({
@ -2399,14 +2399,17 @@ L.Control.JSDialogBuilder = L.Control.extend({
// empty, So, we ignore such messages or else the
// current document's Paste toolbar button will
// never be enabled.
$(div).removeClass('disabled');
$(div).removeClass('disabled'); // TODO: remove after css rework
div.setAttribute('disabled', '');
window.app.console.log('do not disable paste based on server side data');
} else {
$(div).addClass('disabled');
$(div).addClass('disabled'); // TODO: remove after css rework
div.setAttribute('disabled', '');
}
}
else {
$(div).removeClass('disabled');
$(div).removeClass('disabled'); // TODO: remove after css rework
div.removeAttribute('disabled');
}
};
@ -2424,8 +2427,10 @@ L.Control.JSDialogBuilder = L.Control.extend({
}, this);
}
if (disabled)
L.DomUtil.addClass(div, 'disabled');
if (disabled) {
L.DomUtil.addClass(div, 'disabled'); // TODO: remove after css rework
div.setAttribute('disabled', '');
}
if (data.selected === true) {
$(button).addClass('selected');
@ -2449,7 +2454,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
L.DomUtil.create('i', 'unoarrow', arrowbackground);
controls['arrow'] = arrowbackground;
$(arrowbackground).click(function (event) {
if (!$(div).hasClass('disabled')) {
if (!div.hasAttribute('disabled')) {
builder.callback('toolbox', 'openmenu', parentContainer, data.command, builder);
event.stopPropagation();
}
@ -2461,7 +2466,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
}
var clickFunction = function (e) {
if (!$(div).hasClass('disabled')) {
if (!div.hasAttribute('disabled')) {
builder.refreshSidebar = true;
if (data.postmessage)
builder.map.fire('postMessage', {msgId: 'Clicked_Button', args: {Id: data.id} });
@ -2488,7 +2493,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
builder._preventDocumentLosingFocusOnClick(div);
if (data.enabled === 'false' || data.enabled === false)
$(button).prop('disabled', true);
div.setAttribute('disabled', '');
builder.map.hideRestrictedItems(data, controls['container'], controls['container']);
builder.map.disableLockedItem(data, controls['container'], controls['container']);