strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Reorder resize event listeners

Browse source 
As event listeners are called in the order they are registered, and both
the resize listener I have moved and the one registered directly above
its new location call this._update, this._update is called *before* the
second event listener (whichever it is) gets a chance to execute. In the
old case, this causes us to request tiles for a different view level,
which at the start of the program requests tiles for a default position
and zoom level. In Android this triggers a core bug that sends us blank
tiles. These tiles are then later treated as valid for the section and
lead to a blank render.

Got all that? Good, because that confusion you feel is exactly why this
fix isn't a particularly good one! This "fix" is hacky, hard to
understand, and does it all through something I can reasonably describe
as "spooky action at a distance". The direct problem I've been working
on is fixed, but other nasty effects as well as rendering issues in core
are not.  Additionally, this commit has the downside of introducing a
commit that's unfortunately challenging to understand, and possibly
quite fragile if people don't come across it before changing stuff
around here in future

Finally, I also don't know that I'm not missing something that
necessitates a different order. It's entirely possible that I have

The structure of this makes me think somewhat of a DAG - a "directed
acyclic graph" - where we have various dependencies from all over the
place and need to execute them in an order that doesn't end up munging
them... maybe that could be a nice solution to this part of the puzzle

Sadly, for now, this appears to be an improvement with far less effort

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I05870f65a822a66e963407fcf461f18f5748ad1c
This commit is contained in:
Skyler Grey 2024-07-17 14:46:02 +00:00 committed by Skyler Grey
parent f0fd253a32
commit 7e1532cc2a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
browser/src/layer/tile/CanvasTileLayer.js
View file

@ -794,7 +794,6 @@ L.CanvasTileLayer = L.Layer.extend({
this._map.on('movestart', this._painter.startUpdates, this._painter);
this._map.on('moveend', this._painter.stopUpdates, this._painter);
}
this._map.on('resize', this._syncTileContainerSize, this);
this._map.on('zoomend', this._painter.update, this._painter);
this._map.on('splitposchanged', this._painter.update, this._painter);
this._map.on('sheetgeometrychanged', this._painter.update, this._painter);
@ -4398,6 +4397,7 @@ L.CanvasTileLayer = L.Layer.extend({
// always true since autoFitWidth is never set
map.on('resize', this._fitWidthZoom, this);
}
this._map.on('resize', this._syncTileContainerSize, this);
// Retrieve the initial cell cursor position (as LOK only sends us an
// updated cell cursor when the selected cell is changed and not the initial
// cell).