Don't pointlessly assign global.socket = app.socket

Note that the code changed is inside an anonymous function that is
called with one argument: window, for the function parameter called
global. Thus the assignment that this change removes sets
window.socket.

The window.socket variable is not used by code later, so this change
can be this minimal.

The window.socket variable has earlier been set to the WebSocket
object used to communicate with the COOL server. Let's keep it for
that purpose. app.socket is the app.definitions.Socket object. Even
though JavaScript is not type-safe, it is very confusing to use the
same variable for completely different object types at different
stages in the code execution. I am working on some new code that will
want to access the WebSocket object also later.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6273a6d6acee3fa46ab9fedc5742ae44c8bfa567
This commit is contained in:
Tor Lillqvist 2023-01-04 10:59:09 +02:00 committed by Tor Lillqvist
parent 410270fd14
commit 8233d030e5

View file

@ -70,7 +70,6 @@ L.Map.THIS = map;
map.loadDocument(global.socket);
global.socket = app.socket;
window.addEventListener('beforeunload', function () {
if (map && app.socket) {
if (app.socket.setUnloading)