strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

zotero: extract repeated query in a separate function

Browse source 
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I27db5073fcd46f0853e947c4cf9a246477271d84
This commit is contained in:
Pranam Lashkari 2022-12-27 01:21:19 +05:30 committed by Andras Timar
parent ef1cf7cf49
commit 952921577d
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
browser/src/control/Control.Zotero.js
View file

@ -234,15 +234,19 @@ L.Control.Zotero = L.Control.extend({
}
},
getZoteroItemQuery: function() {
return '?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style + '&locale=' + this.settings.locale;
},
_getDefaultSubCollections: function () {
return [
{ columns: [ { text: _('My Publications') } ], row: 'https://api.zotero.org/users/' + this.userID + '/publications/items/top?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style },
{ columns: [ { text: _('My Publications') } ], row: 'https://api.zotero.org/users/' + this.userID + '/publications/items/top' + this.getZoteroItemQuery() },
];
},
getDefaultCategories: function () {
return [
{ columns: [{ text: _('My Library') } ], row: 'https://api.zotero.org/users/' + this.userID + '/items/top?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style, children: this._getDefaultSubCollections() },
{ columns: [{ text: _('My Library') } ], row: 'https://api.zotero.org/users/' + this.userID + '/items/top' + this.getZoteroItemQuery(), children: this._getDefaultSubCollections() },
{ columns: [{ text: _('Group Libraries')}] }];
},
@ -379,21 +383,21 @@ L.Control.Zotero = L.Control.extend({
{
columns: [ { text: data[i].data.name } ],
id: data[i].data.id,
row: data[i].links.self.href + '/items/top?v=3&key=' + that.apiKey + '&include=data,citation,bib,csljson&style=' + that.settings.style
row: data[i].links.self.href + '/items/top' + this.getZoteroItemQuery()
});
that.fillCategories();
that.map.fire('jsdialogupdate', that.updateCategories());
}
});
this.getCachedOrFetch('https://api.zotero.org/users/' + this.userID + '/collections?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style)
this.getCachedOrFetch('https://api.zotero.org/users/' + this.userID + '/collections' + this.getZoteroItemQuery())
.then(function (data) {
for (var i = 0; i < data.length; i++) {
that.collections.push(
{
columns: [ { text: data[i].data.name } ],
id: data[i].data.key,
row: data[i].links.self.href + '/items/top?v=3&key=' + that.apiKey + '&include=data,citation,bib,csljson&style=' + that.settings.style,
row: data[i].links.self.href + '/items/top' + this.getZoteroItemQuery(),
children: [ { text: '<dummy>' } ],
ondemand: true
});
@ -402,7 +406,7 @@ L.Control.Zotero = L.Control.extend({
}
});
this.showItemsForUrl('https://api.zotero.org/users/' + this.userID + '/items/top?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style);
this.showItemsForUrl('https://api.zotero.org/users/' + this.userID + '/items/top' + this.getZoteroItemQuery());
},
showStyleList: function() {
@ -536,7 +540,7 @@ L.Control.Zotero = L.Control.extend({
{
columns: [ { text: data[i].data.name } ],
id: data[i].data.key,
row: data[i].links.self.href + '/items/top?v=3&key=' + that.apiKey + '&include=data,citation,bib,csljson&style=' + that.settings.style,
row: data[i].links.self.href + '/items/top' + this.getZoteroItemQuery(),
children: [ { text: '<dummy>' } ],
ondemand: true
});
@ -669,7 +673,7 @@ L.Control.Zotero = L.Control.extend({
var that = this;
this.dialogType = 'insertnote';
this.getCachedOrFetch('https://api.zotero.org/users/' + this.userID + '/items/top?v=3&key=' + this.apiKey + '&include=data,citation,bib,csljson&style=' + this.settings.style)
this.getCachedOrFetch('https://api.zotero.org/users/' + this.userID + '/items/top' + this.getZoteroItemQuery())
.then(function (data) {
that.dialogSetup(_('Add Note'), false);
that.fillNotes(data);