strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix trackchange comments are not displayed on docload

Browse source 
fix typo on clearList loop that prevents skipping trackchange
comments from being deleted

Also I removed the line in WriterTileLayer.js containing
clearList because clearList is already called on importComments
function so it was unnecessary

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ic4086a80b126aec62e382078f53d68bc17da8a1c
This commit is contained in:
Mert Tumer 2022-03-29 11:56:08 +03:00 committed by Szymon Kłos
parent 6a1bade376
commit aa7eda472b
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser/src/layer/tile/CommentListSection.ts
View file

@ -1757,7 +1757,7 @@ class CommentSection {
private clearChanges() {
this.containerObject.pauseDrawing();
for (var i: number = this.sectionProperties.commentList.length -1; i > -1; i--) {
if (this.sectionProperties.commentList[i].trackchange) {
if (this.sectionProperties.commentList[i].sectionProperties.data.trackchange) {
this.containerObject.removeSection(this.sectionProperties.commentList[i].name);
this.sectionProperties.commentList.splice(i, 1);
}
@ -1773,7 +1773,7 @@ class CommentSection {
private clearList () {
this.containerObject.pauseDrawing();
for (var i: number = this.sectionProperties.commentList.length -1; i > -1; i--) {
if (!this.sectionProperties.commentList[i].trackchange) {
if (!this.sectionProperties.commentList[i].sectionProperties.data.trackchange) {
this.containerObject.removeSection(this.sectionProperties.commentList[i].name);
this.sectionProperties.commentList.splice(i, 1);
}

1
browser/src/layer/tile/WriterTileLayer.js
View file

@ -40,7 +40,6 @@ L.WriterTileLayer = L.CanvasTileLayer.extend({
comment.id = comment.id.toString();
comment.parent = comment.parent.toString();
});
app.sectionContainer.getSectionWithName(L.CSections.CommentList.name).clearList();
app.sectionContainer.getSectionWithName(L.CSections.CommentList.name).importComments(values.comments);
}
else if (values.redlines && values.redlines.length > 0) {