strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

leaflet: avoid keyboard suggestions after undo/redo

Browse source 
problem:
undoing something on mobile does not trigger any input method
this causes problem in mobile working with suggestions
i.e: type "than" and then select "thank" from suggestion
now undo and then again select "thanks" from suggestions
final output is "thans"
this happens because undo doesn't change the textArea value
and no other way to maintain the history
So better to clean the textarea so no suggestions appear

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Idfdfd8acfa6d738bf695a473610d399b123e7019
This commit is contained in:
Pranam Lashkari 2020-12-17 20:25:38 +05:30 committed by Szymon Kłos
parent 09fbbf43b0
commit ea3d78c9bf
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
loleaflet/src/control/Control.Toolbar.js
View file

@ -954,10 +954,22 @@ function onCommandResult(e) {
map.fire('postMessage', {msgId: 'Action_Save_Resp', args: postMessageObj});
}
else if ((commandName === '.uno:Undo' || commandName === '.uno:Redo') &&
e.success === true && e.result.value && !isNaN(e.result.value)) { /*UNDO_CONFLICT*/
$('#tb_editbar_item_repair').w2overlay({ html: '<div style="padding: 10px; line-height: 150%">' +
else if (commandName === '.uno:Undo' || commandName === '.uno:Redo') {
if (e.success === true && e.result.value && !isNaN(e.result.value)) { /*UNDO_CONFLICT*/
$('#tb_editbar_item_repair').w2overlay({ html: '<div style="padding: 10px; line-height: 150%">' +
_('Conflict Undo/Redo with multiple users. Please use document repair to resolve') + '</div>'});
}
else if (window.mode.isMobile()) {
//undoing something on mobile does not trigger any input method
//this causes problem in mobile working with suggestions
//i.e: type "than" and then select "thank" from suggestion
//now undo and then again select "thanks" from suggestions
//final output is "thans"
//this happens because undo doesn't change the textArea value
//and no other way to maintain the history
//So better to clean the textarea so no suggestions appear
map._textInput._textArea.value = map._textInput._preSpaceChar;
}
}
}