Commit graph

7585 commits

Author SHA1 Message Date
Gökay ŞATIR
034b594bdd Impress: Adjust mobile edit button position.
* Remove 3px margin of read only view.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I8f72ea952e2bc734048fe4e02e6ba1784acb1369
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
c429815777 Impress:
* Use lineHeight rule for centering the elements on mobile.
* Use parent element's rules for setting the styles of img and preview elements.
* Disable mobile-slide-sorter. It is not in use for a long while.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I06517467f269669c70294fb5a4dd0960eb16feb5
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
4c4df83e99 Impress: Center the document on initialization.
It seems that fitWidthZoom function is impress-only.
I will turn back to this later.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I95b02d53299bf1b8ce7daf31121b67dccd1c817c
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
d89d2918ff Revert "impress: no slide preview if session was started with hidden slides pane"
This reverts commit bd015e5c6e.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib9420ca380a9099f5a1b2d84e7a2ab8d46f6f7e7
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
3d2e70c395 Revert "mobilewizard: pan the document area to top on presentation"
This reverts commit b783cb30e8.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I6132bbc0ce4800551569cf173261118c88c39e01
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
33082e9ad5 Mobile view and Impress:
There are some inconsistencies with impresstilelayer.

I think the reason is that impress has overwritten some of the canvastilelayer's functions like in updatemaxbounds (old one).

I bound impress' onresize function to canvastilelayer's synctilecontainersize and deleted the workarounds.

One 1year old commit will be reverted after this commit.

Only change that is not related to impress is the FIXME part on canvastilelayer. So i tested the mobile views.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I2dd127bd8d2280f2897d8c58281541f0aaa3c50f
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
b36b732e1f Move side bars into flex container.
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".

Tested on mobile, desktop, tablet views with & without notebookbar.

The problem was:
    On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
    Instead, i tried to use CSS rules with flexbox.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20

There is an additional fixup for master branch included.
2021-07-20 13:43:22 +03:00
Pranam Lashkari
a6cc06ae88 leaflet: refactored uno commands in top toolbar
added missing uno commands
modified uno property to use full command (i.e: use prefix ".uno:")

some item had custom handling and adding uno property would interfere the correct functionality
but to make freemium work properly each item needs a command
to solve the problem a new propery to store the command introduced: freemiumUno

This unifies the button properties with other JSONs

This is also necessary for freemium, without uno property button can not be blocked

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I43fb0796507987817b8eb82828a506b1f874d8ca
2021-07-20 14:41:55 +05:30
Pedro Pinto Silva
48ba9257ea Freemium: Dialog and triggers: Fix style and layout on mobile and sidebar
Mobile:
- Checks if we are in presence of mobile mode and adjust layout
accordingly based on class
- Makes sure that the illustration resizes
depending on device's size
- Adds subtle animation to get the user excited or at least curious to
tap it (avoids making the disable status to dimmed/not legible)
- Fixes layout and buttons

Desktop:
- Adds hover state not only to button but to the locker
- Makes locker a discreet overlay above the respective button, suggesting
"this button is locked" but make it react so user is willing to click to
discover what is it
- Added CSS rules for top toolbar

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idbe66746c5ad07647cd62eb94d3b22a840bf70d7
2021-07-20 14:41:18 +05:30
Pedro Pinto Silva
7062fe28e9 Freemium: Use vex attributes plus styling
Do not use external html file and instead use input attribute from vex
so we can send html while being able to use variables (those variables
should then be overwritten by integrator)

Also Fix styling and DOM elements creation:
- Avoid to many elements and messy notebookbar with multiple (states)
  - Replace disabled feature icon with lock icon
	- Also style it properly and make it similar in other properties as
	the existent disable status

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9c2a07ef1fe5f089d5e63cb53d2d6b7f0b5083a8
2021-07-20 14:41:18 +05:30
Pedro Pinto Silva
81aac851a7 Freemium options: Add external content and fix vex
- Add html file where structure can be changed
  - Add illustration as default (in the case integrator doesn't
	have one). Avoid any purple so to do not confuse the user about
	who is requesting the subscription
- Set custom vex button text (to do: translations)
- Add custom class to vex so we can target it better in CSS

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a4c0232f3728ba88f650ce28905ebfe2f6d9bfc
2021-07-20 14:41:18 +05:30
Pranam Lashkari
e02e1df76d Introduce Freemium options
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ib6b68ff74839cf84f2d8c8cfb7d380be9209f923
2021-07-20 14:41:18 +05:30
Gökay ŞATIR
653c611860 CommentListSection: Remove unused function's call.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I86c5793b33e7edcbe8484fd9d520d31b0eea33ff
2021-07-19 13:38:14 +03:00
Pedro Pinto Silva
280c2b7148 Mobile: Hide scroll indicator for busypopup
since there is no scrollable content

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2f2dda8df160772a5da766e7c04746f3f6e7bb3e
2021-07-19 10:22:08 +02:00
Pedro Pinto Silva
e0017b8734 Mobile: busypopup: Add class to mobile-wizard and add style
- So we can be sure nothing else is targeted
- Center illustration
- Container goes full width
- Fix Portrait and Landscape modes
- Add border radius so to differentiate this panel (busypopup) that
blocks the ui from any of the other ways we use the mobilewizard

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2391197477d465636143ca2b55c0723f60a4b339
2021-07-19 10:22:08 +02:00
Szymon Kłos
491ff730be BusyPopup: fix on mobile
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I602c8009b63b686c1f303930d71f77d81df3a6ab
2021-07-19 10:22:08 +02:00
Szymon Kłos
f48a3c6712 BusyPopup: fade out to not flicker
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ief67c0c221f61af0033aaac7b6be787bb68a3676
2021-07-19 10:22:08 +02:00
Szymon Kłos
3550daf575 BusyPopup: show after 0.7s delay
This will prevent us from flickering if popup has to be shown
for less than 0.7s.

Change-Id: I5904e5f836dae40b83ca24d19e0b2fb779eb504b
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-19 10:22:08 +02:00
Szymon Kłos
68e4498a87 BusyPopup: enable for mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If89a567bd4609ef6993b891a042a7958e4d340d3
2021-07-19 10:22:08 +02:00
Szymon Kłos
87cc41eb0b jsdialog: sidebar: add more options buttons for panels
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I49024be7a3a46665f709c1b6a063a25a0d6ddf38
2021-07-17 17:31:53 +02:00
Gökay Şatır
34b6f0d760 Revert "Avoid higlighting additional rows/cols"
This reverts commit a701f7c9094227422457d05cc5d90e9d1a9a7fc0.

I approved this one but it doesn't seem to work well, unfortunately.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iafc10a15dcf07aae661e7dd2562c6555f6b83596
2021-07-17 16:35:27 +02:00
Gökay ŞATIR
fc1948da83 Impress: Hide comment list panel when there are no comments on the selected part.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I33b30857d0ada79fe06f72e3e54042a8c5c4a64f
2021-07-16 21:14:18 +03:00
Gökay ŞATIR
9bd5154416 Calc Comments: Improvements.
Hide comment on scroll.

Don't show another while one is being edited.

Remove section properly, it was hanging on the background.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Id0f85d4c84d3741a5120e24055061c2fe183b98a
2021-07-16 21:07:28 +03:00
Gökay ŞATIR
df75abe909 Calc: Hide comment on scroll.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I4852c15891f2467566964524bd7eb05450878ad6
2021-07-16 21:07:28 +03:00
Gökay ŞATIR
09c695a3f1 Calc: Issues with comments.
Open new comments directly in the cell's position, without animation.

Focus on the comment box.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I0dda23baaa9c8cdd940fc9d429e0e72e5464b854
2021-07-16 21:07:28 +03:00
Szymon Kłos
894f77e71c Avoid higlighting additional rows/cols
When used 120% zoom and selected any row after 50
there were multiple rows highlighted.

Change-Id: I4bc5f4272bf65fb0f9d00d96527890281377c0a8
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-16 13:20:45 +02:00
Szymon Kłos
556ef0d85d notebookbar: reduce importance of 'not initialized' message
- when we receive any notification - mark notebookbar as initialized
- if we haven't received any information eg. in impress - warn
  reduce importance of this from error to warn as it is not important
  probably there is no widget which sends updates (correct for draw and
impress)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I88ae3a090014dd25e59e04993c0c244d8830435e
2021-07-16 13:20:45 +02:00
Szymon Kłos
a92c71e3ba jsdialog: style all buttons
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I919f4948962e378fcd4690ca9cfa73fa4a273146
2021-07-16 12:05:19 +02:00
Szymon Kłos
631930da92 jsdialog: handle images
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib8b0e17696791a6f9c32ab4e2879d226b7889dfe
2021-07-16 12:05:19 +02:00
Mert Tumer
cb5a91cce2 Parameters for perf-test
now it's possible to pass parameters
typing_speed, typing_duration, single_view, node_inspect

also replaced the old perf-test with new-perf-test

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I03f1f14db4ddd9afb9d4a9a60a87c135497db70c
2021-07-16 10:41:05 +03:00
Mert Tumer
1e015b3d07 moved initializing fontcombobox with select2 to Toolbar.js
This way both notebookbar and classic toolbar will have the select2
styling

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I9b8294cb1c0308fcfeeed8f9e886e3075c2eb3a1
2021-07-15 21:15:00 +03:00
Gökay ŞATIR
c3f6d9fbd4 ScrollSection: Make vertical scroll bar always visible on desktop.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I39cfe37dddc603cc35a4cb02a2bfd45db224df52
2021-07-15 18:53:21 +03:00
Henry Castro
21aa279659 loleaflet: check the 'statusindicatorstart' label
The LO Core server will send the label of the status
indicator start.

Change-Id: Ie33aa56fcf2bb87362ad91c79498292c51bd32a8
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-07-15 15:21:24 +02:00
Gökay ŞATIR
72076ff8cb _refreshRowColumnHeaders: Function is calc-only.
Thanks to cypress tests. It was being called in Impress document.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I4681486cdd0930429f824c5636a2becb26700ff6
2021-07-14 22:24:57 +03:00
Gökay ŞATIR
115d20082d CanvasTileLayer: Correct the check for the tile source.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I4990f8c9d44c92f711fb4d973bf44ef77812c757
2021-07-14 21:51:32 +03:00
Szymon Kłos
07459e2b7b mobile-wizard: remove old uno status getters
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I73d3b5fdd034fe61ff32a4ef3cddfb9b85b6166e
2021-07-14 18:29:23 +02:00
Szymon Kłos
8152a3f9b5 mobile-wizard: don't use uno status updates
we receive that information by welding updates

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9ff7f5d26740b1f13d1f1cccd88793ca35a4ee76
2021-07-14 18:29:23 +02:00
Gökay ŞATIR
587e09acd4 Adapt addSection function with pauseDrawing.
User can pause drawing before adding multiple sections.
When resumeDrawing is called, reNewAllSections function will be called automatically.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ie83265b5a57c11bd828a980c1797d6bfa3d6e287
2021-07-14 19:24:51 +03:00
Szymon Kłos
e3202f6783 jsdialog: apply selected state for toolitems
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I85015f5f10e38a26ed6811180be1eb309679b399
2021-07-14 14:48:08 +02:00
Szymon Kłos
1b9a73c0b8 mobile-wizard: don't show hidden decks
this fixed mobile Page Setup for writer

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I262da01529dff4740089f03181c90f9b59b9935c
2021-07-13 20:39:57 +02:00
Szymon Kłos
c2058a8b95 mobile-wizard: handle toolbox update properly
if any of explorable toolitems was opened - open it also
after update

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If98f68befb1b0e7283564c2bda3f18524e498977
2021-07-13 20:39:57 +02:00
Szymon Kłos
0d3c00dff8 mobile-wizard: when popup is opened don't allow to go back
we need to force proper closing of popup to avoid empty popup
when it will be opened next time

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8e6b3164dc0d828bcb10c37c657d403664f0395a
2021-07-13 20:39:57 +02:00
Szymon Kłos
2a9678595f mobile-wizard: use mobile colorpicker for shadow color
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I04b0262ec27fc325297e1abf55a9193a8bbcefbf
2021-07-13 20:39:57 +02:00
Szymon Kłos
ea56502a7e mobile-wizard: on control update use the same visibility as old control
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5b2a8824895c90480b6038d899d1ca52347fbcaf
2021-07-13 20:39:57 +02:00
Szymon Kłos
5f2167c2bf mobile-wizard: show mobile colorpicker for slide background
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia02ff7562df2e1051d05c82ab77d29acd44f824a
2021-07-13 20:39:57 +02:00
Szymon Kłos
74be366bc1 mobile-wizard: fix explorable entries inside toolboxes
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id2e3de7942cf8f7b4016f2c250c80971cb9d9d01
2021-07-13 20:39:57 +02:00
Szymon Kłos
0d96e1ce97 mobile-wizard: build also toolbox container
we need it because toolboxes are sometimes hidden dynamically
and we need the DOM element with correct id for hiding.
example: colorbar_others / colorbar_writer in Characters Panel.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idccb9cd46feda34c3093b61354a4352677bb582b
2021-07-13 20:39:57 +02:00
Szymon Kłos
da39e28fa7 mobile-wizard: on explorable entry update save visibility state
When update occurs and explorable entry was opened eg. color picker
in shape effects panel we need to rebuild it as opened.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7a564bb32c8e7ee075a2ac32235088bdda19130e
2021-07-13 20:39:57 +02:00
Szymon Kłos
e5fc1d0bca mobile-wizard: fix shape glow panel
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5903b0f8fe0b39d7243db59a0627f62644942156
2021-07-13 20:39:57 +02:00
Szymon Kłos
0689ff580a mobile-wizard: fix Panels icons and visibility
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I25e7f7704f3c0fd1cbd23fcf8c3a0750e631ef9d
2021-07-13 20:39:57 +02:00