Breaks mobile view in Impress.
TypeError: Cannot read property 'length' of undefined
This reverts commit 9db6f855a0.
Change-Id: I839cde8bb683fc0b933da806f4a4771114eb32f5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90785
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is prefereable to move it when the document is initializing
rather than the iteration of toolbar items
Change-Id: I6fd856ed8b7e1b4e3224be09d37d2e86b9dce166
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90759
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This approach is preferable rather than iterating the toolbar items
Change-Id: I81107dde1d6c99b3e5af9793c7b2dff517747ff9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90758
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This test sometimes failed on me just because the load was aborted due
to the timeout, doubling the limit makes the problem go away.
Change-Id: Ided724d67a513391b86836065d4e627581857a92
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90771
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
We actually have commands for submenus too, so
we can use them to generate IDs.
Adjust the icon names, which are now generated from
commands.
Change-Id: I76bb69fb8f83cddfb3d36c3ee74739091bc08f2d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90763
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Broken since: b62dcc0255
The issue here cypress sets the window size and not the device size
when tries to emulate mobile view.
https://github.com/cypress-io/cypress/issues/970
For now, let's keep window size media rules too.
[tml: Window size changes depending on orientation. Device size does
not. We need to change each rule that used only max-device-width into
one using two subrules using max-width combined with comma (i.e. the
OR operator), one for portrait using 767px as the limit, one for
landscape using 1023px as the limit.]
We do this in other places of the css code anyway. In a long term, it
would be good to find a better way to emulate mobile view by cypress
or to detect mobile from JS code, so we can enable mobile mode easily
for cypress tests.
Change-Id: Ic7974f44fcbf6ed2883e93acd28153709514c216
While I was debugging Impress, I received unexpected "undefined"
value of the variable "parts"
Change-Id: Id8b6737155516fd0d8cfaa350170e9c631c55dcf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90756
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
I now think that much of our media queries with (max-device-height:
767px) actually should use (max-device-width: 767px) if the intent is
that they detect the case of mobile phones, as opposed to tablets.
Many mobile phones have a screen.height (which is what
max-device-height in CSS refers to) that is clearly larger than 767.
But a screen.width of 768 is what at least my 9.7 iPad has.
Change-Id: I3b44e32ec583837897b4aa390fc0ab92be59d163
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90752
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
We don't have any other information for the submenu
only it's text and it's children, so let's use
the children's command to find out what submenu we have
here.
Change-Id: I188186142fc1dbe483fcce5b5456e0cb1524382e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90750
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This is an improvement of the commit 569b342c20,
It is better to check the cell cursor width instead of spacing to scroll
the view when very large merge cell occurs
Change-Id: I049cda34f886738ce9fbd3776113a219c5bd038f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90751
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
updating css rules according to the latest html structure
Change-Id: I373e185a444e8f5db3096cd05c9f47f470ef73c3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90747
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
To make it work both with release and debug core
build.
Also disable some tests failing with core/cp-6-2.
Change-Id: I5617712e19dc8aaba0c5f9fbdf9c17d9a19fb18b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90725
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
During parallel build.
Change-Id: I18d78250650e5d16ff9a4ff8588a2e955a934f44
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90721
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In some use cases this time was too long and hammerjs
recognized a pan end by 'pointerup' event. We have
500 ms time set for long press in loleaflet code,
so use the exact value here.
Change-Id: Iab47c668ffa591ccfd7d2eeed10f2c3ec5664b89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90723
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
There is no assertInTextEditMode() in calc_helper.js.
This reverts commit bc5bf2eb2a.
Change-Id: I97526eb8ea0297a2ea28080f09c85e4284d70932
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90719
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The issue comes up when we get a drag-end event
without a drag-start event.
Not sure wether this error can happen in real life
or it's just the cypress test framework mobile emulation
which can lead to this issue, but an additional check
won't hurt.
Change-Id: I352a5b523e8400ffc5e77ebefd91166e40517019
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90724
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This sometimes causes unit-integration to fail and now is consistent
with other member functions of Session that handle missing protocol.
Change-Id: I43c7fcae964cfcb5911ff57d63bd4cb569e6b97c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90732
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id479cb6f1623630b84583c6d2ddd89c9779db7dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90737
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- adjust lc_wrapthrough.svg so it's visible the diference between that and the new icon option lc_wrapthroughtransparencytoggle.svg
- create and add first paragraph option
Change-Id: I224284e973340a15d60fa705117dd33ebb7b1450
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90734
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The next translation update will kill the extra string anyway.
Change-Id: Ieda2ea51837e12fe40d2c85ff2d99afc65a2989b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90731
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This should never happen, since the _onMessage is re-assigned when
loadDocument is called, but it is better to ensure to forward all
messages.
Change-Id: I9a792bc077b26f2f92c30c4e7851c9d2b2637bfb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90449
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The changes only populate the font list when the data
is received by the client, the other approach iterates
all toolbar items to refresh each one.
Change-Id: I837b52275b49e025fa353dcf088f97c19779bc79
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90450
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
When the cursor has a large width due to full merged row cell
it has an undesired effect that scroll to last columns
Change-Id: Ic939b8d9c3007faa46897893cc462cf3dbbee563
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90671
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Which indicates that the application stepped into edit mode.
Change-Id: I196851c618fd3b6c670b26184e6bbca8050f2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90711
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Using CTRL+A is simpler, but with using the Hamburger menu we can
make sure that menu item is working. CTRL+A is not an actual
feature on mobile. Also it's good that we use hamburger menu, so
we can check interaction of hamburger menu and other wizards
using the same bottom panel.
Change-Id: I640e515070046ad18b00be69509ed895844962a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90710
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is hard have a determinate circular progress bar, so let's use
horizontal progress bar for both determinate & indeterminate.
They both look a bit different (the indeterminate is vertically
narrower), but there was no simple trick to make them look the same, so
I gave up for the moment.
Change-Id: Ife3690204a8abd8bf17afe5c7d749a3ac2730c20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90691
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Ideally, perhaps, we should avoid relying on CSS media queries to
detect mobile phones. Here I just add a placeholder to remember where
is a good (?) place to add such in JS instead.
Sadly cannot use the more elegant template literal syntax for
multi-line string literals, as some of the Jenkins builders don't seem
to like it.
Change-Id: I718f86f41cae461abbca3d7cd2751de3236bff18
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90705
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Remove grim duplicate dialog, consolidate clipboard warnings
in the clipboard code, and only show them after attempting the
copy/cut/paste and failing - rather than unconditionally.
Switch back items to use UNO commands, since we filterExecCopyPaste
in the existing _sendCommand anyway and warn suitably.
Add existing l10n hacks to the clipboard code itself.
Change-Id: Ia8befcdea3cce1934cbb9352174ba95b04eced07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90651
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
With this change we can have "In Background" option in Wrap context menu,
that puts the image behind the text.
Change-Id: Ibd652bb593dd5a737bed3b4447be5b4bee7d4b70
Change-Id: I7652a5382b4a828ae21e8ce1cf6da21b7ce78b91
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90652
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I63408cdd8b693445a358050abee03044617c7287
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90702
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
