Which was the case before commit
5d57f5aef3 (storage.ssl.enable should be
in sync with ssl.enable by default, 2019-10-11), otherwise we fail to
connect to the test wsd, since its certificate is typically not trusted.
With this
make check CPPUNIT_TEST_NAME="unit-copy-paste"
passes again.
Change-Id: If3a8a293831313e74eacc1cbc092922d2c72f08c
storage.ssl.enable=false by default is not good. loolwsd default config should
work, e.g. in case of snapshot docker images. When ssl.enable=true, this implies
storage.ssl.enable=true, because browsers do not allow mixed content, so it is
not possible to connect to the storage with plain HTTP, while the content from
loolwsd is served with HTTPS.
TODO: find out what to do in case of upgrade, when the user has an old config
file. Probably storage.ssl.enable should default to ssl.enable when it is not
present in config file.
Change-Id: Ifdcb070745d649dd9840dccf2e5641058a13d4e4
Reviewed-on: https://gerrit.libreoffice.org/80660
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Before we used css based screen width detection.
Delete condition which is not working in Impress,
use explicit JS check added before.
Change-Id: I06819391bd470fd2185bc64318afbe5d9614f0a8
document
A file is created Control.MobileSlide.js for the purpose to create a
button control at the bottom right of the Impress document only if the client
browser is identified as Mobile. The button has the function to create a new
Slide.
Change-Id: I494687a91cf4dc06d08e98c6844b06fb69b2448e
Reviewed-on: https://gerrit.libreoffice.org/80665
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Sadly I have no understanding why not doing that caused such a
mysterious end result. But I am glad I thought of trying this simple
thing before spending any more time trying to understand what is going
on.
Change-Id: I129f8fffa32fa087e21c444f9657394de0e255a1
I had a not good debugging session trying to find out when
the CSS properties of the document container are changing dynamically.
The best scenario is to use the unique name documentContainer, so we can
track all CSS properties dynamic changes, and it can set breakpoint in a
suspicious change for deeper analysis.
Change-Id: I3accef1c374689f04da336cd0a84047b498540b1
Reviewed-on: https://gerrit.libreoffice.org/80610
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
We don't need to return with two children in _removeStylesPanelAndGetContent()
method if we use only the first one in _addChildrenToTextPanel() method.
Change-Id: I11137ce0620e86ad7d2c5ebcaba752f3171b96e0
Extend the box under the panel when insert the styles panel's content.
Also change the id to 'box42' to have it unique in the current context.
Change-Id: I51a6975bd1da3b36b81e2783050910b781177c5c
The document type is detected when 'doclayerinit' event is fired.
At that point we know the document type so we can remove safely
the empty elements that they are useless to the document and
of course a clean document to debug. I hope in the near future
the server side can remove these unwanted elements,
anyway how is useful an empty html element?
Change-Id: I25f5b8cbcd176c4cc66abcb37b7d0d4b588d1d96
Reviewed-on: https://gerrit.libreoffice.org/80557
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
slide-sorter element
Unfortunately the static properties affect the spreadsheet and writer
views, and it is prefereable to change it dynamically when the impress view is
loaded. So the other views will have an empty slide-sorter element.
Change-Id: I03a969c6de74999509314184a4aad9bc5c9e3380
Reviewed-on: https://gerrit.libreoffice.org/80546
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
