- Sidebar parents: be sure it's container childern is always full width
- Sidebar parent: Fix margins vs paddings
- Expander: Decrease color contrast so to avoid to be in the way of the
actual components
- Fix expanders (arrow) position and paddings
- Use CSS vars
- Fix and style listbox and spinfield to be slimmer and more compact
than the regular ones (crucial here to effectivly use space)
- Some of these things should be ported top the general jsdialog css
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I50def4b41144d56a3cc2de41b3ed00ed550fa74d
- Add lateral animation so the users understands that it is in fact a
sidebar
- Also that animation should help with the way toolbars and sidebar
appear, each on on their own time causing the sidebar to appear first
and abruptly (appearing to be floating for a couple of milliseconds)
It would be good to have a longer animation time when loading the page
then when simply pressing the button so something like :
- Currently the default 1000 is somehow skipped
- this.map.sidebar = L.control.sidebar({animSpeed: 200});
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I95b6bf51900449e85c24cee6d5d47f8af9a0f134
So it can be easy to analyze the backtrace of the
failing assertion.
Change-Id: Icdcf55b1404f858eba1d499bd65719a0e2da21db
Signed-off-by: Henry Castro <hcastro@collabora.com>
when calling hasTableSelection(). Do not depend on stray/duplicate
tableselection messages that can ensure a valid _currentTableData
member of TileLayer.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I957fdfc43c1435ca98eb204dcb3ec1e76b85ce89
Otherwise the unit test will take too much time
to fail.
Change-Id: I9a85a79ad2ced5d220394cdf71a7f703265e50ef
Signed-off-by: Henry Castro <hcastro@collabora.com>
When adding a freshly arrived textinput message to the queue, check if
there is an outstanding one queued, and if so, remove it, and prefix
its text to the text in the fresh message. Don't do this if there are
messages inbetween that affect what the textinput messages do
semantically, including textinput messages from other clients.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I712eebfb10d410bb424157c8df46b2848a236d88
For some servers we receive failure with HTTP 403 Forbidden in WOPI::CheckFileInfo
"Reason: The client software did not provide a hostname using Server
Name Indication (SNI), which is required to access this server"
fixes#2771 : https://github.com/CollaboraOnline/online/issues/2771
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I761b179580481f8882a4526c1d8be4f1c14ad929
Event orders or propagation of events are different while using cypress tests.
Newly created comment losts focus while menu is being closed. This scenario is very difficult to reproduce by user (i couldn't).
I added a case for cypress test.
Since this behaviour would cause a regression in production, it is activated only for cypress tests.
Regression without if statement would be: Click insert comment button via menu, open and click the same button once again. Since the first comment is not deleted, the second comment will cause an error (can't add sections with the same name).
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Iaecdd36b56664e207b3a74de5d2b013a845f3fba
if make is killed or interrupted during the execution
of their recipes, the target is not deleted. So there is
an opportunity to check the logs, why are taking to long
time to finish the test.
Change-Id: I6e8176a48ff721ecb2b2efc01b1f149907dd359b
Signed-off-by: Henry Castro <hcastro@collabora.com>
Add profile zone around kitPoll function and SocketPoll constructor to
improve trace event generation
Signed-off-by: Gopi Krishna Menon <krishnagopi487.github@outlook.com>
Change-Id: Ia46e9add59a57935997649fe39861a8d851e1ff0
"Async" here refers a specific kind of data in the Trace Event JSON
format, not asynchrony in general.
Actually, we don't have code that would generate such yet in
loleaflet. Just the createAsyncTraceEvent function in Socket.js. Quite
possibly the "Complete" events (a.k.a. ProfileZones) are all we need.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I611ccd4b964bcacdd1050893f70dbdb813ee3c34
At least I didn't fully understand what the old code actually was
checking.
Also, use sizeof instead of magic numbers.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I01602a2e256b1fbe39793c9f1439e025461c5a72
Our JS code does not send 'textinput' messages with a 'type' parameter
either, so it is pointless to do it in a unit test.
(We still have code that checks for the 'type' parameter in received
'textinput' messages. That is pointless, too, and should be removed.)
Also, document what testWriterTyping() apparently is doing.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I4954379339f14e4a310a76788521001048d84e37
Since a99edb5d29 this gets a different lifecycle, and is often
joined and gone by the time we get to cleanup.
Change-Id: Ic21ca837d484a9a853c7f8f683e876406b00a943
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Set min-height property to prevent exceeding the available size.
slide-sorter: Set max-height to prevent over-sizing relative its parent.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib8c50bc9f6f6ac4311cefa3b0e016da728efe95b
* Use lineHeight rule for centering the elements on mobile.
* Use parent element's rules for setting the styles of img and preview elements.
* Disable mobile-slide-sorter. It is not in use for a long while.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I06517467f269669c70294fb5a4dd0960eb16feb5
It seems that fitWidthZoom function is impress-only.
I will turn back to this later.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I95b02d53299bf1b8ce7daf31121b67dccd1c817c
There are some inconsistencies with impresstilelayer.
I think the reason is that impress has overwritten some of the canvastilelayer's functions like in updatemaxbounds (old one).
I bound impress' onresize function to canvastilelayer's synctilecontainersize and deleted the workarounds.
One 1year old commit will be reverted after this commit.
Only change that is not related to impress is the FIXME part on canvastilelayer. So i tested the mobile views.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I2dd127bd8d2280f2897d8c58281541f0aaa3c50f
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".
Tested on mobile, desktop, tablet views with & without notebookbar.
The problem was:
On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
Instead, i tried to use CSS rules with flexbox.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20
There is an additional fixup for master branch included.
added missing uno commands
modified uno property to use full command (i.e: use prefix ".uno:")
some item had custom handling and adding uno property would interfere the correct functionality
but to make freemium work properly each item needs a command
to solve the problem a new propery to store the command introduced: freemiumUno
This unifies the button properties with other JSONs
This is also necessary for freemium, without uno property button can not be blocked
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I43fb0796507987817b8eb82828a506b1f874d8ca
Mobile:
- Checks if we are in presence of mobile mode and adjust layout
accordingly based on class
- Makes sure that the illustration resizes
depending on device's size
- Adds subtle animation to get the user excited or at least curious to
tap it (avoids making the disable status to dimmed/not legible)
- Fixes layout and buttons
Desktop:
- Adds hover state not only to button but to the locker
- Makes locker a discreet overlay above the respective button, suggesting
"this button is locked" but make it react so user is willing to click to
discover what is it
- Added CSS rules for top toolbar
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idbe66746c5ad07647cd62eb94d3b22a840bf70d7
Do not use external html file and instead use input attribute from vex
so we can send html while being able to use variables (those variables
should then be overwritten by integrator)
Also Fix styling and DOM elements creation:
- Avoid to many elements and messy notebookbar with multiple (states)
- Replace disabled feature icon with lock icon
- Also style it properly and make it similar in other properties as
the existent disable status
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9c2a07ef1fe5f089d5e63cb53d2d6b7f0b5083a8
