Commit graph

67 commits

Author SHA1 Message Date
Pedro Pinto Silva
700f6ad3b6 JS Sidebar: Fix inconsistent wrapper width and fix mobile glitch
- Makes sure sidebar is always the same width (when selecting objects
etc sidebar was changing)
- Fix mobile glitch: on  load and even during readonly mode sidebar
was first flashing and then appearing

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9ebf306d27430a2c9a6c7105a0dc178020ef12cc
2021-07-23 17:17:01 +02:00
Gökay ŞATIR
3b80336b75 Hamburger menu icon visibility: This issue is master branch-only.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Id7765467ca1c144d2cd9cf04adfd2e39823dac08
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
c429815777 Impress:
* Use lineHeight rule for centering the elements on mobile.
* Use parent element's rules for setting the styles of img and preview elements.
* Disable mobile-slide-sorter. It is not in use for a long while.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I06517467f269669c70294fb5a4dd0960eb16feb5
2021-07-20 13:43:22 +03:00
Gökay ŞATIR
b36b732e1f Move side bars into flex container.
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".

Tested on mobile, desktop, tablet views with & without notebookbar.

The problem was:
    On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
    Instead, i tried to use CSS rules with flexbox.

Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20

There is an additional fixup for master branch included.
2021-07-20 13:43:22 +03:00
Pedro Pinto Silva
e0017b8734 Mobile: busypopup: Add class to mobile-wizard and add style
- So we can be sure nothing else is targeted
- Center illustration
- Container goes full width
- Fix Portrait and Landscape modes
- Add border radius so to differentiate this panel (busypopup) that
blocks the ui from any of the other ways we use the mobilewizard

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2391197477d465636143ca2b55c0723f60a4b339
2021-07-19 10:22:08 +02:00
Pedro Pinto Silva
92a06d1357 Mobile: menuwizard (hamburger): Fixes contents position
- Add mobile class to #toolbar-wrapper to avoid targeting anything else
  - Sets Menuwizard so it goes above toolbar (position absolute) so to be
  properly aligned from the top
  - Sets toolbarwrapper with normal z-index (according to its parent) so
  menuwizard can be above it

Note, no need to touch #toolbar-hamburger.menuwizard-opened has it comes
already with z-index properly set

Behavior might be related with changes from
ff20ec701de0e8440c029f0b01bc7b14fa9b5c08

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1a66057b7827309a6ad3871927099ac1c9339657
2021-07-09 21:05:40 +03:00
Gökay Şatır
3a362f68ce Calc: Activate comment section for mobile.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I0dcc6edfd33209d031e1ff20d81aaedaee6f9016
2021-07-09 21:05:40 +03:00
Gökay Şatır
7b471f70fd Mobile wizard: Adjust for flex view.
Scroll bar wasn't visible on hamburget menu.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I204b8a60d5b813de5735dbe741b861460a039f30
2021-07-09 21:05:40 +03:00
Gökay Şatır
e43878c9a8 Adapt mobile and tablet views to css-flex.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Icf3b1a8313b35c78012b931550922823bc387ea7
2021-07-09 21:05:40 +03:00
Andreas-Kainz
3d5a85a399 Mobile show border-top ad bottomBar
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I43cc306c2e5b01d92969ad03a8d4f8f6379eaaa5
2021-06-09 07:07:37 +02:00
Andreas-Kainz
840032b961 Mobile Calc Formularbar arrangement fix
Formularbar was vertical-align: top which cause issues on mobile formularbar.

Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I88140808657dd44e6b94fdf99485ce14079a3920
2021-05-30 14:34:52 +02:00
Andreas-Kainz
fe5cfbaf1f Mobile BottomBar fix height
The height of the bottom bar items is 35px the height of BottomBar was defined with 34px so that it look always as the bottomBar was cutted.

Height is changed from 34px to 37px (check the blue select frame, it now wasn't cuted)

Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: If30e56c582ca652cb35e73f669f440696c6b03b4
2021-05-30 01:30:11 +02:00
Szymon Kłos
01d75feafd Revert "Mobile Topbar Alignment"
This reverts commit 7161e13d54.
because cypress test was failing: mobile/writer/shape_properties_spec.js
probalby because of document-container modification

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2d9a2f44a7e0bfe3b1d16abcb816accb87622774
2021-05-28 22:11:19 +02:00
Andreas-Kainz
7161e13d54 Mobile Topbar Alignment
Make the TopBar 43px height instead of 36px so it look better valigned and more like a header toolbar
Calc fix formulabar alignment

Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I263bbc51db539a4c0201488cd28d588ce273979f
2021-05-27 16:18:18 +02:00
Pedro Pinto Silva
4e477e1589 Welcome dialog: do not mix desktop and mobile plus styling
- Fix problem introduced with d0253673a6
  - Desktop was always without close button

- Add mobile specific class
  - So we can style it apart from desktop
  - So we can style it apart from mobile(other dialogs)

- Mobile: fix padding (remove for child element)
  - So we can use more efficient the horizontal space

- Mobile: Dismiss button
  - Make it full width

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icb6a5a0a4191b39ecf76eaafac06e182430490d0
2021-05-04 07:58:21 +02:00
Rash419
a8467d551b Fix: mobile: toolbar-down: swipe indicator now visible at the start
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib28ce57172f9c93e49eab4eeca3abeaa783a1fd4
2021-04-21 12:31:41 +02:00
Ezinne Nnamani
f700867731 Loleaflet: Impress slide previews in vertical orientation are modified to fit
Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
Change-Id: I49e69d5ecb765e09bcd1d9c584883a1e2841ac0d
Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
2021-04-01 14:14:08 +01:00
Pedro Pinto Silva
ad26e90596 Mobile: Macro Selector: Only show ellipsis when in empty state
- Display ellipsis inside of #command element when a library is still
  not selected
	- To communicate clearly to the user that there is still stuff to be
	selected
	- But also to hide that visual (ellipsis) when there is content to show
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>

Change-Id: I5d0a1e627de9e83908c2d79e0d52abd428f0280c
2021-03-25 17:24:57 +01:00
Pedro Pinto Silva
4ac5b9d2bb Mobile: Macro Selector n Warn: Layout improvements and style..
- Warning
  - File name: Increase contrast
  - Add icon to dialog
- Make it visible when a command is selected (commands get border)
- Use consistent radius
- Use consistent colors (CSS vars)
- Add bottom border to each li so to make it clear that there are more
  elements (and that is a list) and that it can be scrolled
- Avoid fixed height for Commands list
  - it was resulting in odd extra space when a library group has only
    one macro
- Macro Name: Use ellipsis in the content until the use selects library
- Add parent id to css rules( #MacroSelectorDialog )

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0e5aaf40e143b708104462da39b506feb29f6569
2021-03-25 17:24:57 +01:00
Pedro Pinto Silva
0c6bf9c28c CSS var: Add one more gray and replace instances
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8091ebd6e720dba8b6af4c503f515899e7f5f2d1
2021-03-25 17:24:57 +01:00
Pedro Pinto Silva
a4ca812257 leaflet: annotation: wizard: style context menu for mobile
- Bigger targets
- Add existent icon or create for better mobile scanning
- Improve layout

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iccfdfb3d02e3c4ee148fdcfa05ba3c0a320a6c78
2021-03-11 14:33:18 +01:00
Gökay Şatır
52759920a5 mCustomScrollBar: Remove.
It's not used anymore.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I4424018e6b1820de0d86c9058207fe19f46e0c16
2021-03-03 14:04:11 +03:00
Gökay Şatır
68ac78ceec Impress: Remove mCustomScrollBar
Use native scroll bars.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I63eeac7916e9f7edc2decc0e9338c36bda48ee50
2021-03-03 14:04:11 +03:00
Gökay Şatır
5f1090dcb1 CanvasTileLayer: Position canvas on mobile, tablet and desktop.
Remove "spreadsheet-row-column-frame" div. Since row & column headers and groups are drawn onto the same canvas with tiles, that div shouldn't exist.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
2021-02-02 09:49:48 +01:00
Pedro Silva
b349f30d20 Mobile: make sure no box-shadow is ever applied to w2ui-button
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Id9778057c5b0db070a987e0286aff977cb01b2cc
2020-12-04 12:08:19 +01:00
Pranam Lashkari
9f19059022 leaflet: now comments are displayed in wizard
Change-Id: I18fc2ab823e257993247d94d878b5b00599a4508
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
2020-11-30 06:31:15 +01:00
Pedro Pinto Silva
88e42f4b91 Mobile: Vex with checkbox: Fix long strings
vertical align text, fix boundaries,
add ellipsis for very long strings, add padding

Change-Id: I12098be368d22e5cb0907c4cc591bbe7ccfa0e4b
2020-10-27 22:40:19 +01:00
Pranam Lashkari
715d3c6a51 leaflet: vex: corrected misaligned checkbox in vex
problem:
i.e: show sheet in the mobile

Change-Id: I826ac9b86d273a0df7c274b003a483b1c20ebaf9
2020-10-27 22:40:19 +01:00
Pedro Pinto Silva
f949eb51a1 Mobile: toolbardown: restrict check rules to device-mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I963f46cfa109808f53305cddc30ef85abd30b880
2020-10-27 16:50:36 +01:00
Jan Holesovsky
c5c533266e mobile: Fix the gap between the toolbar and the actual document.
In the read only case, there were few pixels gap; kill it.

Change-Id: I2012bcbfa9cc3c5f3e50bee7621780661e0bd8ef
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
2020-10-27 13:54:58 +01:00
Jan Holesovsky
b4e9426aee mobile: The last few pixels at the bottom of the sheet weren't moving.
Change-Id: I443b772508286de46279f4ae429e8543d3c2e51b
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
2020-10-27 13:54:58 +01:00
Jan Holesovsky
3f25d63cb3 mobile: The calc grid was not aligned with the row headers on mobile.
Apparently the readonly-only case was wrong; let's kill it.

Change-Id: I07366cc7cf9a8d421e7b59d9bc50bbb242e2adb3
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
2020-10-27 13:54:58 +01:00
Pedro Pinto Silva
dfd51b19e0 Mobile: Formulabar: hide unnecessary break element while
keeping its space

Change-Id: I9fc2c0e5804057f5c9f204a1fe7a6bb8eb216421
2020-10-14 09:38:09 +02:00
gokaysatir
596d70187c loleaflet: Hide portrait view previews on layout view.
Header code is updated to avoid creating/deleting it every time.
Some CSS adjustments to increase maintainability. Example: There were 2 scroll bars in mobile-wizard. Scrolling was not smooth. And some other improvements.
On layout view, 2 separate slide-sorter containers were visible. One of them is hidden now.

Change-Id: Ic4201b176812f6ca00402777423feced7ee8284c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102521
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-09-16 14:19:20 +02:00
Pedro Pinto Silva
bef32043d6 CSS lint: add more rules and fix problems
- Fix duplicated properties (ignore cases where it's needed
for browser compatibility);
- Fix space inconsistencies before !
- Fix space inconsistencies after colon
- Fix space inconsistencies after and before combinator (>, +, ~)
- Invalid calc
- Many rules added to json, namely no-extra-semicolons

Change-Id: I78af6bc546aeb1d7d7090e2ef278c895f0393a07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-09 11:48:31 +02:00
Pedro Pinto Silva
175ac6e740 CSS lint: Code refactoring
- Detected many duplicated selectors within the same file (squashed them)
- Detected inconsistency (sometimes spaces sometimes tabs). Tabify as in JS.
- Detected quotes' inconsistency (sometimes none, sometimes '', sometimes ""). Use '' as in JS
- Avoid touching on files from 3rd party sources (jquery, w2ui), ignore files

Change-Id: Idd82945f29ac6c5c9f522e5d5df4a783a367654d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102009
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-08 17:02:30 +02:00
Pedro Pinto Silva
80542f6cf9 Fix inconsistencies wrt slide-sorter between impress and draw
- Inconsistencies between impress and draw (slide-sorter)
- Fix missing slide-sorter divider
- Mobile: Fix white borders
- Read-only mode inconsistencies (slide-sorter)
- Mobile: landscape: divider is present at the left edge of the screen (remove)
- #presentation-toolbar misaligned and lack bottom border

Change-Id: Ib45438e955f4e65b35bae67b5d0edbc510a4987c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102182
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-08 10:25:57 +02:00
Szymon Kłos
c42255ad71 Reduce height of textarea in annotation vex
Size has fixed value which is too big for small screen
devices. Reduce it for now, more intelligent calculation
seems to be hard to implement in existing vex dialog
structure.

Change-Id: Ic16845a96000b17aa668f39fc2871fca57076d0c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100655
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102178
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-08 09:59:17 +02:00
gokaysatir
9c23e57042 loleaflet: Slides preview section improvements.
Change-Id: I4018cbc30d7b8b03f117bb229bf637706c70dc26
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101546
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-31 11:09:27 +02:00
gokaysatir
8895a48d1f loleaflet: Insert shape window last row visibility.
Last row wasn't fully visible on Calculator mobile view.

Change-Id: Ia326fddc3510eabbca9b3d9b4bd90bf30f95f785
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100982
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-27 20:48:21 +02:00
Pedro Pinto Silva
1cbb871336 Mobile: Fix misalignment due to vex sizing
- make sure avatar container is set to content-box instead of border-box

Change-Id: I342f01136bee99a0154527f34703b323cd62aeb5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101381
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-26 10:02:35 +02:00
gokaysatir
a5e77d71c2 Loleaflet: Impress image previews are adjusted.
Change-Id: I0c333b58e823702678c4c292de2f58adabbdb3c1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101319
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-25 22:08:35 +02:00
Henry Castro
14cc329613 loleaflet: fix CSS style properties for landscape
orientation

Change-Id: I75e64d4f24405cb0c5a263d03d65a7b89ce7b528
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100681
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-08-14 02:04:22 +02:00
Pranam Lashkari
653ecb1698 tdf#133283 leaflet: fixed reordering of slide with drag and drop in touch screens
Changed the gestures:
1st tap to select the slide
2nd tap will open the mobile wizard
long press and then drag and drop the slides

Change-Id: I44a874f69eed4586667f7fbe825d5da943565071
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97345
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-07-29 21:17:03 +02:00
Pedro Pinto Silva
515fee128b Notebookbar: styling
- Overall styling
- Fix tab’ alignment and paddings
- Fix tabs’ states
- Make use of text-shadow to emphasize instead of changing font-weight in order to avoid changes in size
- Add document-type class in notebookbar (similar to what I did for menubar)
- Style jquery-ui tooltips
- Style .unolabel
- Start to use css --var for font and colors (still no changes in the code per sea [like reducing the values etc] just start using it)
-- add comments
-- Use it depending on doc-type for notebookbar tab unolabel
- Add missing icons
- Fix extra border (toolbar-wrapper)
- Add document-header

Change-Id: I24552b118657d8ead47a74a6d189bd2448aac808
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98721
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-07-20 09:35:25 +02:00
Henry Castro
e5188272c7 android: fix thumbnails images when portrait orientation is set
Change-Id: I70aee6b569f78795487cbff736130e0e7413e852
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/96123
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-07-07 17:29:32 +02:00
Marco Cecchetti
7f105d02a8 loleaflet: function wizard for all functions subdivided in categories
Change-Id: Ib8e6bb4155ab3a0562c7a76a6eeb58c4d725058d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89200
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-04-29 13:27:21 +02:00
Pedro Pinto Silva
411ba06ea3 Mobile: Calc: Adding CSS rules for when #formulabar has inputbar_multiline as a css class
meaning adding css rules for when the inputbar is in the multiline mode (expanded)

Change-Id: Ib8557f1e502c06e50a26b0a94ccab793b44feda0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92570
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-04-20 16:38:57 +02:00
Szymon Kłos
610e2dbd58 Move user list to a separate file
Change-Id: I1cd8881d8ea342b96bd5ea5bd4972f971c89881d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92210
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-15 16:51:48 +02:00
Pranam Lashkari
8bc03a5a37 "+" position corrected for active state add sheets button
This chage only affects mobile view
> moving changes to new files
> Increase document container's bottom position (it was cropping tabs container)
> Fix default browser borders that were afecting position

> Desktop
> Also Fix document container on desktop
> Fix icons' elements being cropped (perv, next and plus)
> Adjust Margins for those w2ui elements

> Discovered that plus.svg whas not centered and fixed it

Change-Id: Id54a491e9c2a6afef468aca8d858bf91b83d03ce
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91270
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-04-09 16:33:44 +02:00