The helper functions were improved in the meantime.
Change-Id: Ie8ae8caf5b33567681010a7a0cfc45d2da061f8b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92973
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
New tests to exercise the Formula-Bar in
both desktop and mobile modes.
Change-Id: Ibc174232f7b614132913c1d66af0051b51151a29
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91537
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We can use should method everywhere with a callback function
parameter. When there is no a specific item, which this should
is connected to we can use 'body' or any other existing item.
Change-Id: I3e1c5ca930b28304e886971ee50201d93a086b45
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92931
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's better to use should, when we need an indicator.
Change-Id: I0f08c8862411e3c7627302bbda7b632b0bc0e15c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92930
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's better to use should, when we need an indicator.
Change-Id: I5d1fe825fdd6b20f98ce179c7cb6260ec0966928
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92918
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We don't actually need cy.waitUntil() extension here,
becasue we can do that same check with should()'s special
usage.
Change-Id: I2b14afe84d2fa70f493aae873e3f1534540e96ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92917
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This parserOptions was added for cypress test so
move that into the tests' own config:
b2ec95dcfd
Change-Id: I3c565d212409cc01621eca97cd59ae7869d852cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92857
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
So we can use cypress calls to wait on the tested state
using cypress' retry functionality. It's also useful to
have the acceptInput state in the DOM, so we can check
it in the interactive test runner.
Change-Id: I17cd8f88b270f7a329d35e77dec4eedd7aa1c2a3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92682
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Plus rename one test file: focus.odp -> slide_operations.odp.
Change-Id: I278fc22ec55bcfbd47d2ecda95b759c16b615403
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92681
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It was added initially to have some dekstop test too.
Now it fails, so no need to keep it.
Change-Id: I94aae2b5e86c46dfd5afa5decabb3333cefd1302
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92680
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We can use cypress methods on #copy-paste-container and so
we don't need to use explicit wait() method here. The added
cypress call will do the waiting more effectively.
Change-Id: Ib15ffb1d72e422ef303f9e0e17b29d740cd4e7f6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92678
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
So we don't need to trigger a fake copying to get the
content. It will make things easier.
Change-Id: I0964fe697602d77078f10792355fbda23879c7c9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92645
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Since we are in an asynchronous environment, we can't just use
variables locally that easy. Cypress has alias feature to
introduce global variables and access them. Since these are
global we should init them anytime before use.
So a stable workflow seems to be this one:
* Set alias to an initial value (e.g. 0)
* Wait until it's actually set (e.g. cy.get().should())
* Set the alias to the value you need in the test
* Wait until it's actually set
* Move on with your test and assert on something using this alias
So we need indicators also for this variable to be set, before we
use it. This will make it work a sequential way, how we need it
to work.
Change-Id: I047373aa884b1ac7bac419cfb1811534c0e95862
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92417
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
So enable the related checks.
Change-Id: Id8af54e8a47de96a9147f074570e0c2b35205e3d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92361
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We can store the original position in a 'variable' and
we can use that variable to assert on.
Change-Id: I026c1f3adc445b94d7d7720608ca36a373678352
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92350
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
These checks were not actually unreliable, but the checkbox
handling code was changed.
Change-Id: I4b3f7dc161d9a774466cdfb6bca49de8d1311714
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92339
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Checkboxes have wierd flickering on mobile wizard.
Change-Id: Ie9756f5dc7213a113ea6d05c7c02594a5d1eb1a3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92308
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's a known issue, that these checkboxes have wrong state.
Change-Id: Idca61bc261d03e19e5aa9266bbf8727da94de642
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92214
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This helper method was introduced as a reliable
alternative of cy.get(<selector>).contains(<content>).
However we can have the same result using contains()
differently: cy.contains(<selector>, <content>), which
works reliable.
Change-Id: I11553f7d280a0f3a94a8f353410308113dd1c825
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92194
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Also improve afterAll(). Having test files with the same suffix
led to test failure. We can have better result with a regex.
Change-Id: I8d678aa17eb0e28e643cc86f584aab713ca153ca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92157
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In parallel build try to run the specific test files
for a second time if they fail. Let's be realist,
testing an online application always has some
unreliabilities, let's make things more reliable with
running test more times and abort the build only if
the test fails consistently.
This is enabled only for parallel builds now, so we
have it on Jenkins. A simple make check will be more
deterministic. I also added an option to disable second
chance for parallel build: see CYPRESS_NO_SECOND_CHANCE
make file variable.
Change-Id: Ib7c554a238ded7ee15908b9f0c2d2c92ef0dcf32
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91987
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's useful to run a test suite more times, until it fails
when a failure comes up randomly.
Change-Id: I33708eff1db65f571c2cde323aaa683e6e1676e7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92031
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Using an indicator after changing the trasnparency solves the issue.
Change-Id: I21f3f0571dbc42685594c868c056ce1b314df714
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92030
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
I don't know why it happens, but I found a bug report about it
with a solution:
https://github.com/cypress-io/cypress/issues/4889
So let's check whether changing this setting solves this issue.
Change-Id: If1f1162d9c7cfb4f68f816285644dc88b35f872b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91956
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
cy.get().contains() behaves unexpectedly. With pseudo code:
// First find the item using the selector
do {
item = get(selector)
} while (item == undefined)
// Then wait until it get's the right content.
// Item points to an object which can change it time.
do {
} while (item.content != specified_content)
What we actually need is something like this:
// Wait for an item which matches both the selector and content.
do {
item = get(selector)
} while (item == undefined || item.content != specified_content)
The new selectItemByContent() method behaves like this.
It just looks wierd when you experience a test failure in the
interactive test runner and you check the DOM and you can see
the right item with the rigth content and the test still fails.
Change-Id: I0b1466a165451e831401e1f4b500ce16bd3f38b0
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91955
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
So we don't need to close the mobile wizard before copying.
The main issue was with contains() method, which first
selects the HTML items and waits until these items gets
the content 'Copy'. What we actually need is to wait until
an item appears with the content 'Copy'. Not the existing
items's content is updated with the 'Copy' text, but new
items are created.
Change-Id: I235d2756ce41a099267fa335c215d3eca6f468c2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91913
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Import cypress-wait-until directly in the test file. This module
is not intended to use everywhere, so it's not a big issue
if we need to import it before use.
Change-Id: I33ff8ae1eae2ec124b286cd7760d5571e5c67531
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91874
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
