Commit graph

24070 commits

Author SHA1 Message Date
Darshan Upadhyay
3a3518b454 Translated using Weblate (Hindi)
Currently translated at 26.5% (156 of 588 strings)

Translated using Weblate (Hindi)

Currently translated at 20.0% (1 of 5 strings)

Co-authored-by: Darshan Upadhyay <darshan.upadhyay1188@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/hi/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hi/
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5cb618bd36c160658d61cf70cb6f6b51d7be628c
2024-05-21 16:13:24 +02:00
Andras Timar
c9cca42137 Translated using Weblate (Hungarian)
Currently translated at 100.0% (588 of 588 strings)

Translated using Weblate (German)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4a6fe12f0bda8dc1c3aa2c8761f11b8e7adb0d0e
2024-05-21 16:13:24 +02:00
Lily Logua
e2dba9956a Translated using Weblate (German)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Lily Logua <lily.logua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2a4d903f72fefdd474f5daa824b14a0e9ec8ee5c
2024-05-21 16:13:24 +02:00
Pedro Pinto Silva
0ad09fda60 Impress: fix slide preview animation and color
Replace svgs introduced in 3efbfaeccd
- Animation and smiley svg: Use gray
- Don't use a smiley face, use instead something more semantic such as
a checkmark

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I38e341ae393c59e785adff9207f8111d68c341ef
2024-05-21 15:06:45 +01:00
Gülşah Köse
a73991b7f3 Hide Invert Background button until implementation
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I061901d748641ffbb40f60e2fa03fcc31df2cd7e
2024-05-21 13:44:25 +01:00
Gökay Şatır
85b93bfb9d Fix coordinate calculation error of cell selection area.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5f130924455cd29018baf6fbc14c1ceffd29cf46
2024-05-21 14:10:13 +03:00
Gülşah Köse
2acc5a94c9 Introduce new formula auto complete feature
When we start to type a formula in a cell eg: =S
We will see the possible function names in a popup.
If we move with "ArrowDown and ArrowUp" and enter, or direcly select a
function with mouse, function name will be automatically inserted into
cell. Then we will see the usage details of the selected function in
another dialog.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ic06ca0d904770e95bb85ccdf9a73f60b7d5c5eb0
2024-05-21 12:09:20 +01:00
Rashesh Padia
a6cf4eb118 zotero: fix: can't select language or store as option in citation style
- problem: in combobox widget we were always passing the
`_defaultCallback` which will send `dialogevent` to server but in
zotero's case the callback is different
- also fixes some `undefined type` errors

Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I7bd7aff6a1a3a9715123c1335ea83ab13fd7b22a
2024-05-21 16:06:27 +05:30
Rashesh Padia
93e9259aaf css: decrease max-width at which filename is hidden
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: Ibbd2aed0739af6627d982db954487ad98159500e
2024-05-21 12:34:29 +02:00
Caolán McNamara
166f12b545 shutdown AsyncDNS before WebServerPoll shutdown
and start it after WebServerPoll start.

AsyncDNS depends on COOLWSD::getWebServerPoll()
existing.

/lib/x86_64-linux-gnu/libc.so.6
	__GI_abort
		/build/glibc-bkR840/glibc-2.27/stdlib/abort.c:81
/lib/x86_64-linux-gnu/libpthread.so.0
	__restore_rt
		??:?
/lib/x86_64-linux-gnu/libpthread.so.0
	__GI___pthread_mutex_lock
		/build/glibc-bkR840/glibc-2.27/nptl/../nptl/pthread_mutex_lock.c:67
/usr/bin/coolwsd
	ConvertToAddressResolver::dispatchNextLookup()::{lambda(std::string const&, std::string const&)#1}::operator()(std::string const&, std::string const&) const
		??:?
/usr/bin/coolwsd
	net::AsyncDNS::resolveDNS()
		??:?
/lib/x86_64-linux-gnu/libpthread.so.0
	start_thread
		/build/glibc-bkR840/glibc-2.27/nptl/pthread_create.c:463

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I372802b872bc899874404e7317ecd9ecb1d0757a
2024-05-21 12:12:55 +02:00
Gökay Şatır
f480e10d75 Fix cursor visibility issue.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5ba8a44b51592b52ed9bfc378d4461b8fc7dccd6
2024-05-21 12:45:40 +03:00
Ashod Nakashian
f1001cddcc wsd: remove unused (Is)ViewWithCommentsFileExtension(s)
Change-Id: I25158862746ce6a3e4ee16ff9d661ec96810ce24
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
8acded5b25 wsd: fileserver: better compression failure handling
We now always cache the uncompressed file data even
when compressing fails. If no compressed data exists,
we return the uncompressed version.

Change-Id: I885275dac526f4d47ea74d6badcb609390e7c139
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
8a808591ca wsd: simplify file-server caching
This removes explicit file-reading logic
with the existing utility function that
is more robust and avoid the C++ streaming
abstractions altogether.

Change-Id: I170b8497a4f9185f1b29e632da27a3520ca0347a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
c153d88c65 wsd: generic readFile
Change-Id: I7b4328785399a2601193d71b5d6f5d1c9f933bfb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
e292041078 wsd: refactored readFile to take buffer
Change-Id: I31a76e25cff150bcf33d503e6ed9b7fae0e0ed42
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
e4f30f38e3 wsd: FileServer cleanup
Change-Id: I4ebdbee733922be312a7a5b9b59bcb6c6329a06b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Miklos Vajna
a161ee30f4 cool#9072 browser: better error handling when navigator.clipboard.write is advertised but fails
In case an integration doesn't allow clipboard interaction via
<https://sdk.collaboraonline.com/docs/advanced_integration.html#allow-the-clipboard-permission-query>,
we end up in a situation where navigator.clipboard.write is not
undefined, but is broken.

By the time navigator.clipboard.write() fails, it's too late to fall
back to the old copy code, as the security context is already gone.

Fix the problem by improving the failure handling: show the popup to try
again copying, remember that navigator.clipboard.write() failed and
prefetch the text selection, so next time a copy is tried (via the
keyboard), the selection doesn't need re-creating. (Normally the
selection change would trigger the prefetch, so select->copy->copy-again
would still fail.)

Note that paste doesn't have a similar problem, since there we always
try the old paste code first, and only use the new paste code if the old
one fails.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I12ea4810395970421000d213744d1838213c7a07
2024-05-21 09:47:54 +01:00
Michael Meeks
216b14ee39 Send Content-Length and Connection: close to help browsers.
Possibly the combination of "gzip" and us being unhelpful about
lengths could lead to browser hangs; who can say.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I632dfc46afde3883544292d687bdff023bccc8ac
2024-05-21 10:28:25 +02:00
Caolán McNamara
c3a8683f69 use new startThread
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4cf56d0b2aae394a3e2c4f40cf64f0de4de9f418
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-05-21 09:22:43 +01:00
Pedro Pinto Silva
3760e64c6b Toolbar-down: Fix Search input field and other elements alignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib1e1b1247dc42e721921c6bf1b68726cf0c916e5
2024-05-21 08:06:50 +01:00
Pedro Pinto Silva
3a749bf0ff Writer: Accessibility Check: Add missing CSS class
Now that accessibility checker has change its command it's best to add
back in the CSS class that was being added automatically (based on the
uno command) for various reasons:
- Main one: the ".unoSidebarDeck.A11yCheckDeck" is less than ideal
class name (it includes a dot in the middle)
- Integrators might have customizations targeting the previous known
css class

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7685d000a2110872cdbe83323136b7a6be604ca3
2024-05-21 06:38:57 +01:00
Andras Timar
890e5c6d06 Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I95c712ad7c923a4dc941252d58f17771079b7544
2024-05-21 07:28:42 +02:00
Software In Interlingua
e94798c02b Translated using Weblate (Interlingua)
Currently translated at 4.5% (1 of 22 strings)

Translated using Weblate (Interlingua)

Currently translated at 15.4% (17 of 110 strings)

Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ia/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ia/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1a7fd795b02c7e1632d239789ba0569a0ec59e52
2024-05-21 07:27:15 +02:00
bittin1ddc447d824349b2
623a228502 Translated using Weblate (Swedish)
Currently translated at 100.0% (587 of 587 strings)

Co-authored-by: bittin1ddc447d824349b2 <bittin@reimu.nl>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I21de4133a990885939ae2a145680159f781ca2f1
2024-05-21 07:27:15 +02:00
Ali
a1e5880cd7 Translated using Weblate (Arabic)
Currently translated at 82.8% (396 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 82.8% (396 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (587 of 587 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I357c4d4b539b0331d074d9d3608f0e63c6269527
2024-05-21 07:27:15 +02:00
Neil Guertin
1b586a5a41 Do not return null character from TraceFileRecord toString
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I0458ca2cb4214cc6d235a1f1322282e7b271e3f1
2024-05-20 21:29:50 +02:00
Caolán McNamara
a8a2a95b0e cid#318933 Big parameter passed by value
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I90bb07726656e8066387ea6615045b8dbf813358
2024-05-20 21:28:19 +02:00
Caolán McNamara
b4490dcb68 return early on error case for clarity
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0cf892b5772d12b3ca914186c000b18dba912429
2024-05-20 21:28:19 +02:00
Caolán McNamara
5075b59955 cid#318857 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iaa1058edc3e8189af93bdb0dd8c227c1a3640a98
2024-05-20 21:28:19 +02:00
Caolán McNamara
853b257302 cid#368510 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iee1524be2f956aa049ad603a7245e022daecbcd4
2024-05-20 21:28:19 +02:00
Caolán McNamara
7e02a1ebd5 cid#368509 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I3305f8b993a67d22849800ac6cc65f4b64506c35
2024-05-20 21:28:19 +02:00
Caolán McNamara
15f7d56b2d cid#368508 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Icd74082ef6c32c9c0e266dc876a67675d95e7edf
2024-05-20 21:28:19 +02:00
Pedro Pinto Silva
c623afe97e Tablet: Tabbed view: tabs container too wide
Tab buttons and their background (gray) looks odd, extending the full
width even if there is no more tabs to show.

This sub container cannot be allow to extend (flex-grow). Otherwise,
we end up with tabs background extending all the available area.
We can safely turn this off because the parent element
".notebookbar-tabs-container" already sits in place and extends the
whole area.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6ec3fa6f40d4138420569e9acf60c906a7c43035
2024-05-20 16:38:32 +01:00
Pedro Pinto Silva
716015b9cc Remove erroneous css selector and its rule
It seems when updating CSS we introduced the  "w2ui-toolbar"
with missing dot: 826592458c

But it seems the problem is inherited from long ago with
"#toolbar-up-more,w2ui-toolbar" (comma instead of dot) introduced in
6901ad9251

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia7023581979f0644b90437a6d65aaae8288360f2
2024-05-20 16:38:23 +01:00
Pedro Pinto Silva
f843b77e9c Desktop: compact mode: Fix hidden button with undefined img
1. Load with notebookbar mode
2. Switch to compact mode via UI
3. Inspect -> see the existence of "#closemobile-button"
  - a div (unotoolbutton) with id closemobile that is hidden, has a
  button (unobutton) with id "closemobile-button" that is generated
  with an undefined img "lc_closemobile.svg" -> we don't have that

Add an alias. I don't think we ever use this. It seems to be a
temporary state that never gets to be shown to the user (is also
hidden) and when the UI is updated the HTML structure
changes. Nevertheless best to reference an image that exists

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I500737d0e9a7c321f9f92e55c9348ca7064a6625
2024-05-20 16:38:23 +01:00
Pedro Pinto Silva
9d8c7cca55 Remove unused close icon and its legacy w2ui css rules
Mobile:
- This is not used anymore and the respective element is now being
  targeted as `toolbar-mobile-back`
- closedoc.svg: .editmode-off .mobile-wizard-back .sub-menu-arrow

Desktop:
- close_toolbar.svg is not used anymore. We re-use the same
closedoc svg and it's been targeted as #closebutton

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia02378811886824c77fa525911a2bf8901887037
2024-05-20 16:38:23 +01:00
Pedro Pinto Silva
6a98d42f9e Dark mode: Add missing invert background icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icd11c0e7138e68cf9f185496ebeacf45f4fcf42f
2024-05-20 16:09:28 +01:00
Rashesh Padia
44551037fd css: fix progress bar overflowing in compact mode
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I8f60eadf53f173f26d47d3959589a233673703ee
2024-05-20 14:44:46 +01:00
Gülşah Köse
5313acd1f9 Add Invert Background Color buttons
We have the that button for Writer, Calc, Draw, Impress
menubar and notebookbar

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I745c010749b8c5b88c0d181418f2a47921a94620
2024-05-20 12:38:20 +01:00
Neil Guertin
6bb1054c52 Upgrade to cypress-tags 1.2.2
cypress-tags has fixed their npm publishing
Upgrade to take advantage of dependency updates
Reverts commit 873485f479

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ib4128dd4224a70777eaace0bf1e4bc14974a5189
2024-05-20 06:44:54 -04:00
Méven Car
f6e824d324 UI: slightly make the font size combo larger
So even '88.5 pt' fits in without getting cut.

Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I950b99b2bed7b1e038e1847586b517807f3aa9b0
2024-05-20 12:37:50 +02:00
Michael Meeks
1ff01c484e bgsave: unit test for a Kit crash during save disabling bgsave.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8702776b73b5af8bb87aafe3551800d268b9f9c4
2024-05-20 10:28:42 +01:00
Pedro Pinto Silva
5ec388e8b0 Toolbar-down (status bar): Don't over style disable status
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2907f25f63c05b9b59deca19f1d883e27e9ebeb
2024-05-20 08:42:04 +01:00
Pedro Pinto Silva
f2cfd9a8b9 Toolbar-down (status bar): Fix hover status
For all status bar buttons
- Fix missing pointer
- Also, at leat for now, don't add border and don't add different
background. This is a status bar and adding those contributes to the
overall bulkiness. In the future we could perhaps remove the vertical
padding of the status bar and introduce back the background on
over (and remove the border radius). This would make the status bar
slimmer and slicker (so maybe we can turn its visibility on by default)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2b01d1d6c35ff2b3f487de0417170398d587a565
2024-05-20 08:42:04 +01:00
Michael Meeks
91863875a7 perf-test: update for latest substitutions in cool.html.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I220d30074c412fe849f746bc7722d5f896544b1c
2024-05-20 09:27:33 +02:00
Aron Budea
7ed490700b Add empty handler for LOK_CALLBACK_VERTICAL_RULER_UPDATE
To silence errors until feature arrives. Occurs after
following core commit:
11b936629dd4ef9308d63b312900b8b7c8ff19b4

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I6d9b01b265e3f07db2bc4ac7da46cbfcd0e17da5
2024-05-19 00:53:35 +02:00
Michael Meeks
24e0196471 bgsave: detect crashed bgsave process, and/or early termination.
Warn, flag save as failed, and disable bgsave in these cases,
perhaps we will not crash  main kit process next time around.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ia4f3d079a5503739efc11e408ed431c3b652860b
2024-05-18 18:57:54 +01:00
Michael Meeks
766b919c55 bsave: attempt to catch and avoid jsdialogs during save.
No known test vector for this, but it may happen and we don't
want to hang saving with non-interactive interactive UI coming
from the bigsave process, that can't get events back.

If this happens - something is very odd, and we should disable
background save; so do that and try to clean-up in time.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ifde2fe9ac8719321e38695725981b1f8b2b554f5
2024-05-18 18:57:54 +01:00
Michael Meeks
81e837cba4 bgsave: disable bgsave if we get an error:
Core patch to simulate:

Change-Id: Ifc221a0600956aea1ca67cb690e45b271142845d

--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2755,7 +2755,7 @@ bool SfxObjectShell::DoSave_Impl( const SfxItemSet* pArgs )
         pMediumTmp->DisableFileSync(true);

     bool bSaved = false;
-    if( !GetErrorIgnoreWarning() && SaveTo_Impl( *pMediumTmp, pArgs ) )
+    if(false) // !GetErrorIgnoreWarning() && SaveTo_Impl( *pMediumTmp, pArgs ) )
     {
         bSaved = true;

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-05-18 18:57:54 +01:00