It just causes confusion with the name "DocumentBroker".
DocumentBroker objects exist only in the WSD process. Instead just use
"kit".
Change-Id: I3d9915c4759899ea6ed9084cf3ec6dc0f3b88ee5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92474
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
LibreOffice core uses that, too, and we support an even more
restricted set of compilers.
Change-Id: I0d0e2c8608e323eb5ef0f35ee8c46d02ab49a745
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92467
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Very useful with vim plugin YouCompleteMe
with libclang C-family Semantic Completion
Change-Id: I9dfa9b16c5eb11c410d26e21086283c142a57228
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91860
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Very useful with vim plugin YouCompleteMe
with a TSServer-based completion engine for
JavaScript and TypeScript
Change-Id: Ib2961940f171691e10c2af10ebb911283ee1ff20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91861
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Since we are in an asynchronous environment, we can't just use
variables locally that easy. Cypress has alias feature to
introduce global variables and access them. Since these are
global we should init them anytime before use.
So a stable workflow seems to be this one:
* Set alias to an initial value (e.g. 0)
* Wait until it's actually set (e.g. cy.get().should())
* Set the alias to the value you need in the test
* Wait until it's actually set
* Move on with your test and assert on something using this alias
So we need indicators also for this variable to be set, before we
use it. This will make it work a sequential way, how we need it
to work.
Change-Id: I047373aa884b1ac7bac419cfb1811534c0e95862
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92417
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This avoids flicker and unnecessary CPU utilization, and
makes Cypress tests more reliable, since destroying an
HTML element can fail tests, even if they are created
right after (it becomes a matter of random timing whether
a test that checks the presence of such an element passes
or fails).
Change-Id: I57f7afa26831c79d85b740fbc0894a7c30f380fe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91539
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Preparing to avoid re-creating the input-bar
on every update message. This will not just avoid
flicker and unnecessary CPU utilization, but
it will make Cypress tests more reliable, since
destroying an HTML element can fail tests, even
if they are created right after (it becomes a
matter of random timing whether a test that checks
the presence of such an element passes or fails).
Change-Id: I8ff887578ebd719b05bb62059d3f0a0bbb929898
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91538
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
In the future should be merged with Signing.js
Change-Id: I3b5db8b20dcead4e0f1f80643de474fdba8245af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92348
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
So enable the related checks.
Change-Id: Id8af54e8a47de96a9147f074570e0c2b35205e3d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92361
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Since we now have the window.enableWelcomeMessage value
Change-Id: I2870c9d0ab025182788e1f6e131b0f8ef260c299
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92351
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
We can store the original position in a 'variable' and
we can use that variable to assert on.
Change-Id: I026c1f3adc445b94d7d7720608ca36a373678352
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92350
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This reverts commit df4a241d0f.
Reason for revert: As we agreed, we have to improve the default,
but this patch actually just doubles something that is working
out of the box.
Change-Id: Idc22dabc3621d537f1bba3bc3b13a7d943c80c36
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92299
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Now we have window.enableWelcomeMessage on the JS side to avoid any
queries at all when the feature is disabled.
Change-Id: I8420089f775bfbf5bcd557c7c720172fbce8c22e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92338
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
For the moment, we are missing a way to disable it when the feature is
switched off in loolwsd.xml; so let's just avoid it for the moment.
Change-Id: Ic0cde3ef3c415c9ac7009e4db285b04560018b74
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92276
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
If eg. welcome-cs-CZ.html is not available, try welcome-cs.html and
fallback to welcome.html (which should be the en-US version).
Change-Id: I5df6a6d6da97fb3c111a709a63a54ee86248f73d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92274
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
And do some small additional amendments, like decrease the retry timeout
to one day, don't hide the menu entry based on the About dialog, or
consistently name the cookies.
Change-Id: I4170161a44230b05333798dc68d8c3ffe07e26d4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92267
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* Whenever a new version of Online is deployed,
users will be shown a welcome dialog with latest updates,
release notes etc.
* Location of the content for the welcome dialog can be
set up in loolwsd.xml, and that file will be served to
the client by loolwsd (That part handled in a prior patch)
* If the welcome dialog is disabled in the config, or the welcome
file (at welcome/welcome-$LANG.html by default) does not exist,
then we will disable the checks for a week
* A command to show the welcome dialog has also been added under
the help menu as 'Latest Updates'
Change-Id: I490f4ed92920bbcc9308a53014a3fb5a1d477a54
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92266
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
These checks were not actually unreliable, but the checkbox
handling code was changed.
Change-Id: I4b3f7dc161d9a774466cdfb6bca49de8d1311714
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92339
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
