When going back to the root level show not only headers.
Change-Id: I86d91f03b6f9aaa1ce14fb9ccbb567a62fb4fb15
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
with inline-block with many styles there were
empty spaces
Change-Id: I5752b26694b630e871b26a1fd7044db58808ccfe
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Allow dragging event even when the mouse is outside the document.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2b871e9a7556b465d55aa0d1b50ac9f489246d17
In commit 64dc25f70 a new branch of coordinate transformation was
introduced to avoid breaching the coordinate limits supported by
canvasRenderingContext2D.transform(). But this caused additional burden
on testers by forcing them to test all branches and made the code harder
to maintain.
It is straighforward to implement the features of
transform()/translate() that we need and use them always and not rely on
those apis. This is what the patch implements.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If690a254b44fb4e6ca9a5536785de6f3310413d8
there are no freezes active and view is anchored on A1.
Description of the fixed issue:
Open a blank sheet in mobile Calc. Make sure the cell A1 is
full visible, place cell cursor on A1 and zoom in a bit. The cursor
rectangle now is drawn incorrectly over the headers for every zoom
animation frame.
Description of the fix:
The root cause is that the clip area in this situation is incorrectly
set since the conditional assumes that the pane is a fixed one as its
top left is (0, 0) which is not correct when there are no active
freeze.So set the clip area to the correct rectangle derived from the
computed transformation like it is done for any free-pane.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I827e7992acaa56e60e1938fc83b566d7adb8a30c
- Add proper html structure
- Add style to communicate that his is a empty state and thus different
from the regular mobilewizard view
- Add icon
- Fix alignments and sizes
- Add suggestion as action (insert comment)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9815efe1a5b96862dba9d0e4c5863b5975132596
The issue is: On creating a page break on a empty writer file and
hitting backspace, the deleted page or parts of it is still rendered.
We get a 'status' message containing the document size every time it
changes. So avoid the issue do not draw tiles that are not within the
document area.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I88d1715e861f068326d28d2930d01e3b5355be02
canvasRenderingContext2D.translate() and friends only seem to function
with numbers < 2^24, at least on Chrome 89.
So when the pane being drawn where this limit is hit, lets do the
translation ourselves.
But in the case of zoom-animation more complicated transformations are
needed. Till we implement the manual matrix transformations correctly,
lets not animate overlay objects when the view area has hit this limit.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib48d6029ba1c6f1d7ade35060baf4ebe3e0a5fd3
- Position the number of replies near to the chevron to indicate what
that is supposed to do.
- Reply counter gets the same color as its icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd692f40f5f3420d7577147e8ca7bcf306e59899
The view area after zoom is computed by the following rules:
1. If there are not edit cursors or it is out of view, anchor on the
top left cell.
2. Else, compute the new view area w.r.t top left cell, but if the edit
cursor is not in that resulting area, translate it such that edit cursor
is just inside the closest edge of the final view rectangle.
Notes:
As part of the implementation the default behaviour of view scrolling on
cursor msg was disabled while the new view area is being set.
If there was an active edit cursor to start with, ensure it remains the
same way. This is acheived by replaying the last print twips cursor
messages after the new view area is set.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Iaada6ec1f4a06f7ad05dec759e702bd37240dff8
by setting a top padding of right amount.
Before the patch the top border of toolbar "appear" white on the part that
intersects with row-headers and it was gray where it intersects with the
document content(tiles). These were due to the background of body and
tile-pane div respectively.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ia3b95d41ea150d815469498e3e2044d7e1d36a4d
(cherry picked from commit 66416be43980205dea1a2addefbf5954e013c3cc)
When CellCursor command result arrives we focused
the document what caused annotation closing.
Change-Id: Idf2eb8c5b3b0049dd0aeb7c82cca80083b304698
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Dragging is impossible when cursor is active so
displaying them only leads to confusion
Change-Id: Ib0586ce6ac38354b84076972e01be136f7ec66f9
Signed-off-by: mert <mert.tumer@collabora.com>
Previously a 'click' on 'start download' - also resulted in a pair
of mouse down/up events getting sent to the map, the TileLayer, and
thus the core - resetting the object selection during the download,
and causing nasty issues in the second 'Confirm copy to clipboard'
which had a different & random selection depending what was under
that popup.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I7f6510494500dd36beb232e4720a66f2d9e09f27
scrollIntoView scrolled whole page inside iframe
when selection in the fontwork dialog was changed
Change-Id: I40f59c1821d1327aaf6ce910e07587f0dcb5af31
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
show only .odg and .pdf formats in file tab
Change-Id: If95d871d0ec546569a3ccb0334b9acbd971a9f86
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- center main div
- set minimum size for children in %
- make sure everything is centered
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab199dca2a4907ca7292cc8b56cf6535b3013c0d
I saw that happening now and then when experimenting with the Insert >
Comment functionnality in the iOS app. The message in those cases
seemed to be 'jsdialog: { "id": "0", "jsontype": "notebookbar",
"action": "close" }'.
Change-Id: Ia8e07f849f88bb46cedd95f7c38534232c388efe
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Unclear whether it is actually useful or not any longer. Quite
possibly cross-platform changes in the JavaScript since
CollaboraOnlineWebViewKeyboardManager was introduced have fixed the
problems that it was solving.
Fixes https://github.com/CollaboraOnline/online/issues/1432
Change-Id: Ifa000d0a7d0a3dc87527536719063b368266f038
Signed-off-by: Tor Lillqvist <tml@collabora.com>
We have these on the Top toolbar but in notebookbar case
We have only insert and duplicate options and they are
located in Insert tab. So deletion is not possible
with notebookbar. This patch re-enables presentationbar
with the correct hints of these items according to the doctype
Change-Id: I885b6353bce82232cfdfb5577f8cfbee16b219c7
Signed-off-by: mert <mert.tumer@collabora.com>
problem:
In the android keyboard when you try to erase in an empty area
and then enter some character,
The first character will likely travel with the cursor,
And that is caused because after entering the first character
cursor position is never updated by keyboard (I know it is strange)
so here we manually correct the position
steps to reproduce:
1. type "=sum" in formula bar or an empty odt (or even just "=s" is okay)
2. now tap on backspace for total character +1 times (in this case 5 or 3 times)
3. now type "=s" it will become "s="
but this can be reproduced with any special characters (i.e: }, + etc...)
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9cc00e5d50d21384155b16b60318090e4de70ac2
Changing ui mode on mobile causes problems eg. after save as
or reloading the document.
We don't support notebookbar on mobile also
Change-Id: Iaa8d80dbdd139833c0505354be870f33b4f95413
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
