Which is good, Util::alertAllUsers() is enough of a complicated mess.
Change-Id: Ibac302ea8a7506baa992d71e3891b5764b6ed279
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92569
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Any use of them is already inside such ifdefs.
Change-Id: Ide63a58eeb1c97bb0431c3f0cfa51359476352bc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92557
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
We need to make sure we don't accidentally get into either a
touch or mouse event codepath, which would cause an error as the
events and cases differe a bit. For example touch event has no
'button' member, which means a touch 'panstart' event would be
ignored in every case, which would then cause an error in
'panmove' and 'panend' because some variable wouldn't be set.
Change-Id: I08e4850b735f753639f7001b736c2883cf2d683f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92550
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Otherwise right we can't change right ruler margin as no mouse
event goes through.
Change-Id: Id2f536ab6cb82908e17e4c293762160e8dd2fb8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92546
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Don't pop an empty container, also use stol() so it does not throw
std::out_of_range.
Change-Id: Id81cb00ccfb0ecc234b8f6fa89edf5a0d8c6d353
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92524
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reduces the risk of starting to look into something that is actually
never used in the mobile apps, when your intent is to re-work
soemthing for the mobile apps.
Change-Id: I04c562758a1b336690c7adbfd32b260cf26d9f87
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92554
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tell if the key loading happened due to a Poco vs std exception.
If we show the response headers, show the request headers as well.
Change-Id: Idb32e8c4d9cc5565647b99d6ddae27cd2faba46f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92518
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
It just causes confusion with the name "DocumentBroker".
DocumentBroker objects exist only in the WSD process. Instead just use
"kit".
Change-Id: I3d9915c4759899ea6ed9084cf3ec6dc0f3b88ee5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92474
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
LibreOffice core uses that, too, and we support an even more
restricted set of compilers.
Change-Id: I0d0e2c8608e323eb5ef0f35ee8c46d02ab49a745
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92467
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Very useful with vim plugin YouCompleteMe
with libclang C-family Semantic Completion
Change-Id: I9dfa9b16c5eb11c410d26e21086283c142a57228
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91860
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Very useful with vim plugin YouCompleteMe
with a TSServer-based completion engine for
JavaScript and TypeScript
Change-Id: Ib2961940f171691e10c2af10ebb911283ee1ff20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91861
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Since we are in an asynchronous environment, we can't just use
variables locally that easy. Cypress has alias feature to
introduce global variables and access them. Since these are
global we should init them anytime before use.
So a stable workflow seems to be this one:
* Set alias to an initial value (e.g. 0)
* Wait until it's actually set (e.g. cy.get().should())
* Set the alias to the value you need in the test
* Wait until it's actually set
* Move on with your test and assert on something using this alias
So we need indicators also for this variable to be set, before we
use it. This will make it work a sequential way, how we need it
to work.
Change-Id: I047373aa884b1ac7bac419cfb1811534c0e95862
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92417
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This avoids flicker and unnecessary CPU utilization, and
makes Cypress tests more reliable, since destroying an
HTML element can fail tests, even if they are created
right after (it becomes a matter of random timing whether
a test that checks the presence of such an element passes
or fails).
Change-Id: I57f7afa26831c79d85b740fbc0894a7c30f380fe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91539
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Preparing to avoid re-creating the input-bar
on every update message. This will not just avoid
flicker and unnecessary CPU utilization, but
it will make Cypress tests more reliable, since
destroying an HTML element can fail tests, even
if they are created right after (it becomes a
matter of random timing whether a test that checks
the presence of such an element passes or fails).
Change-Id: I8ff887578ebd719b05bb62059d3f0a0bbb929898
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91538
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
In the future should be merged with Signing.js
Change-Id: I3b5db8b20dcead4e0f1f80643de474fdba8245af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92348
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
So enable the related checks.
Change-Id: Id8af54e8a47de96a9147f074570e0c2b35205e3d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92361
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Since we now have the window.enableWelcomeMessage value
Change-Id: I2870c9d0ab025182788e1f6e131b0f8ef260c299
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92351
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
We can store the original position in a 'variable' and
we can use that variable to assert on.
Change-Id: I026c1f3adc445b94d7d7720608ca36a373678352
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92350
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
