Commit graph

14 commits

Author SHA1 Message Date
Henry Castro
2644c113c2 mCustomScrollbar: add event listener to pointer or touch events
Some mobile devices support both pointer and touch events,
so if we add event listener it will fire 2 times.

Change-Id: Ida9862e9ee24e47ccbe3963b5c4ff18a173fffe0
Reviewed-on: https://gerrit.libreoffice.org/82799
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:31 +01:00
Henry Castro
59d3c2d20d mCustomScrollbar: remove unnecessary access to Window top property
When the frame is null, it is referring to a container frame window that
it is always not accessible.

Change-Id: Ie96a05327928b2b72ce5577409e368061b2afa1e
Reviewed-on: https://gerrit.libreoffice.org/82798
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:13 +01:00
Henry Castro
cb7813ef35 mCustomScrollbar: reduce the number of _coordinates function calls
The _coordinates function is called several times to compute
the same coordinate value.

Change-Id: I6e187b74709515ddde77d60649e564cb2b484fb4
Reviewed-on: https://gerrit.libreoffice.org/82797
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:01 +01:00
Szymon Kłos
cff5791f2e Prevent view from jumping on zoom in/out on mobile
Change-Id: I29262d518d61a4a06d66271033c958e56ff16a2b
Reviewed-on: https://gerrit.libreoffice.org/70592
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 42a739a7bc53f9992056de4e00db90a5e613c04c)
Reviewed-on: https://gerrit.libreoffice.org/70887
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-04-17 16:28:55 +02:00
Szymon Kłos
6cc7bad2e0 Calc scrolling with selection fix
Scrolling with selected sheet was endless.
This change allows scrolling using mouse wheel
when scrollbar is close to the end of screen
and prevents from doubled updates.

Extension of work done before in:
ec24337b11

Change-Id: Id76818158c0d9988b323ec52a408efd5ae6a9da5
Reviewed-on: https://gerrit.libreoffice.org/70266
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-04-05 10:59:21 +02:00
Tor Lillqvist
f028fd58f2 tdf#122359: Un-revert and edit in a attempt to reach a compromise
Change-Id: I0f23c70b3c4a07bae24e490eb8d1a5e56a4ba9ee
2019-01-25 12:20:01 +02:00
Tor Lillqvist
ec24337b11 tdf#122359: Revert e27ae38beb for non-MOBILEAPP
This will then re-introduce another issue, that the document view
jumps to the caret position when zooming, but that is a less serious
issue.

Change-Id: Iac22f4c2bc753e4311bd6c646c85937ee24b08e5
2019-01-23 17:44:41 +02:00
Tor Lillqvist
e27ae38beb Fix jumping after touch zooming also for mobile clients of normal Online
Don't check window.ThisIsAMobileApp but instead use a much more
convoluted test to catch only the cases where we do want the document
to be scrolled, and ignore the case that causes the irritating
jumping.

In _onUpdateCursor() in TileLayer.js, we know that the scroll
parameter is not undefined when and only when _onUpdateCursor() is
called from _onInvalidateCursorMsg(). We pass that information down to
the onUpdate callback handler passed to the _tweenTo() function in the
_scrollTo() function in jquery.mCustomScrollbar.js where it shows up
as property of the options object.

In that location we also make use of the incidental fact that
options.timeout==1 only when that code is called from mouse-wheel scrolling.

Quite possibly all this could be done much cleaner.

Change-Id: Iefa257bceb54137f25534ccb6786c1d2e315931c
2018-11-22 14:58:56 +02:00
Tor Lillqvist
0656ed4990 Brown paper bag fix
My previous commit broke scrolling for normal Online with touchpad
(and presumably wheel mouse). So do it only in the mobile app case.

Change-Id: Ia085549b66ed4584c75d5efb78948f19a33c7907
2018-11-21 19:28:20 +02:00
Tor Lillqvist
fbce9a4439 Better hack that seems to fix the jumping after touch zoom gestures
Unlike my previous (reverted) attempt, now scrolling using the
scroll-bar keeps working.

Seldom has coming up with an one-liner been as painful as in this case.
But that's how 3rd-party JavaScript is, I guess.

Change-Id: I18c26da7b41d7e12dd63763651010641ca2a0069
Reviewed-on: https://gerrit.libreoffice.org/63718
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-21 18:22:17 +01:00
Tor Lillqvist
683b347032 Revert "Awful but effective hack that seems to fix the jumping after touch gestures"
See discussion in https://gerrit.libreoffice.org/#/c/63437

This reverts commit 657076d620.

Change-Id: I7bc2330011bc389041375928d0cae98eeea8a647
Reviewed-on: https://gerrit.libreoffice.org/63550
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-19 10:09:05 +01:00
Tor Lillqvist
657076d620 Awful but effective hack that seems to fix the jumping after touch gestures
(Only for mobile devices for now. I am not brave enough to do it also
for mobile device browsers using a normal Online.)

Likely breaks rendering of the scroll bars somewhat.

Change-Id: I40bf1cb29fc99ba808b8bb570691d96019a1f8f7
Reviewed-on: https://gerrit.libreoffice.org/63437
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-17 09:32:54 +01:00
Tor Lillqvist
d8b982e75e Add Emacs mode line
We want this file to stay as it was in upstream, so please do continue
to use TABs in it, and 8 column tab width.

Change-Id: Id355ac32bbe899470d4f66c4cf84fef3f3add0d8
Reviewed-on: https://gerrit.libreoffice.org/63436
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-15 18:04:11 +01:00
Tor Lillqvist
393c8ff278 Move the malihu-custom-scrollbar-plugin js and css into our tree for hacking
I plan to add some hacks into it to fix the horrible jumping around
after touch-based interaction, specifically for the iOS app.

Change-Id: Ia6cfbfe7f487b52ba7652e49eb3fdb59af0c82ae
2018-11-15 18:33:41 +02:00