Commit graph

11313 commits

Author SHA1 Message Date
Henry Castro
15fe4b8dca android: fix "AAPT : error: resource drawable/writer not found."
Adding an empty image using the command "touch", generate a weird error
when merging resources:

* What went wrong:
Execution failed for task ':app:processDebugResources'.
> A failure occurred while executing
com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > Android resource linking failed
    android/app/src/main/res/layout/activity_document_browser.xml:163:
AAPT: error: resource drawable/writer (akaorg.libreoffice.androidapp.debug:drawable/writer) not found.

android/app/src/main/res/layout/activity_document_browser.xml:229:
AAPT: error: resource drawable/calc (akaorg.libreoffice.androidapp.debug:drawable/calc) not found.

android/sid/android/app/src/main/res/layout/file_explorer_grid_item.xml:49:
AAPT: error: resource drawable/ic_more_vert_black_24dp
(aka org.libreoffice.androidapp.debug:drawable/ic_more_vert_black_24dp) not found.

android/app/src/main/res/layout/file_list_item.xml:58:
AAPT: error: resource drawable/ic_more_vert_black_24dp
(aka org.libreoffice.androidapp.debug:drawable/ic_more_vert_black_24dp) not found.

android/sid/android/app/src/main/res/layout/fragment_directory_browser.xml:13:
AAPT: error: resource drawable/ic_menu_back
(aka org.libreoffice.androidapp.debug:drawable/ic_menu_back) not found.

android/sid/android/app/src/main/res/menu/view_menu.xml:5:
AAPT: error: resource drawable/ic_folder_black_24dp
(aka org.libreoffice.androidapp.debug:drawable/ic_folder_black_24dp) not found.

Change-Id: I99b0857941687846e90ad53f30cac6a7ef83beaa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92594
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-20 22:58:34 +02:00
Henry Castro
66415e4e45 android: add missing gradle-wrapper.jar
It is required to execute the script

./gradlew tasks

The wrapper downloads the gradle version if not installed

Change-Id: I3d52f779aa6931bc4e3d57309558fdccbe98024b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92095
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-20 21:47:26 +02:00
Henry Castro
c9cc637cd5 android: fix create-l10n-all-js.pl paths
builddir != srcdir

Change-Id: I42668bec84efeefae445416eac03321ca02b5aba
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91862
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-20 21:17:57 +02:00
Muhammet Kara
f507302993 Welcome: Add config for enabling the dismiss button
Change-Id: Ia2fbf066493d91a2b10866e66d11332b5cfc10fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92593
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-04-20 20:35:08 +02:00
Pedro Pinto Silva
55a985dc73 Add missing latest updates icons
Change-Id: I41fa30979a121672516cea06905e071ff8486297
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92586
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-04-20 20:10:15 +02:00
Tor Lillqvist
c440dceb9e Add ios/Mobile/Resources/Settings.bundle/Root.plist
Change-Id: I578104460e59fcc2e7a2887a49f4e771fe9c3fa0
2020-04-20 21:01:06 +03:00
Pedro Pinto Silva
411ba06ea3 Mobile: Calc: Adding CSS rules for when #formulabar has inputbar_multiline as a css class
meaning adding css rules for when the inputbar is in the multiline mode (expanded)

Change-Id: Ib8557f1e502c06e50a26b0a94ccab793b44feda0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92570
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-04-20 16:38:57 +02:00
Tor Lillqvist
fdf5687d7c Bin some dead code, this gets rid of a use of Util::alertAllUsers(), yay
Getting rid of Util::alertAllUsers() calls in arbitrary places is good
because the semi-obscure way in which it works in the multi-process
web-based Online is potentially hard to fit together with the desire
to make the single-process mobile app able to handle several open
documents.

Change-Id: I6055a993ee31941e3592508aac5f0edf6497a836
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92571
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-20 16:38:40 +02:00
Muhammet Kara
1c296d5947 Welcome: Prevent a million cookies during development
By default, cookies are stored with full path of
the web app, and we have an extension made of the
hash of the build. So each new commit means a new
web app for the browser, causing many cookies stored,
and the welcome dialog being shown after each commit.

From now on, we will be storing our cookies to the
'/loleaflet' path.

Change-Id: I4cb25ab0a53c4743cb929a7f6c20ab019da29409
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92575
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-04-20 16:36:04 +02:00
Miklos Vajna
eeb4d53a1e admin_fuzzer: fix too large param to mem stats size setter
Change-Id: I30dfa5cd917769e05cfdd4fad2a0e5ee8cc79dfb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20 15:44:21 +02:00
Tor Lillqvist
5fff61ef14 There doesn't seem to be any use of FileUtil::alertAllUsers()
Which is good, Util::alertAllUsers() is enough of a complicated mess.

Change-Id: Ibac302ea8a7506baa992d71e3891b5764b6ed279
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92569
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-20 15:35:05 +02:00
Tamás Zolnai
227b9812b8 cypress: mobile: add tests for calc cell appearance options.
Change-Id: I452c07a01f903edfffaeb63042418534ed0ae039
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92564
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-20 14:43:56 +02:00
Tor Lillqvist
0fa4553dcf Put FUZZER-specific members inside #ifdef FUZZER
Any use of them is already inside such ifdefs.

Change-Id: Ide63a58eeb1c97bb0431c3f0cfa51359476352bc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92557
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-20 12:57:05 +02:00
Tomaž Vajngerl
9885fc136e ruler: show ruler for all tablets, not only iOS
Change-Id: If127220052bf956c88e4b927a882a1d049e91dac
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92551
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:46:43 +02:00
Tomaž Vajngerl
ad19d910ca ruler: make sure touch and mouse events don't cause an error
We need to make sure we don't accidentally get into either a
touch or mouse event codepath, which would cause an error as the
events and cases differe a bit. For example touch event has no
'button' member, which means a touch 'panstart' event would be
ignored in every case, which would then cause an error in
'panmove' and 'panend' because some variable wouldn't be set.

Change-Id: I08e4850b735f753639f7001b736c2883cf2d683f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92550
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:45:22 +02:00
Tomaž Vajngerl
02505f1e8f ruler: show context menu on longpress in touch environment
Change-Id: I627977b7fc04df93e129bc2967bf966f6534a204
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92549
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:45:07 +02:00
Tomaž Vajngerl
e11202ea49 ruler: insert tabstop from a context menu (right click)
Change-Id: I0699b53a6972b304f358948d49619a5004329eff
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92548
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:45:01 +02:00
Tomaž Vajngerl
54461e0e1a ruler: only handle left mouse event in the tab-stop area
Change-Id: Ifd3fe9f1b532a4dfec250482044bf860caefbd2b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92547
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:44:51 +02:00
Tomaž Vajngerl
2e6c2bff23 limit tabstop container between left and right ruler margin
Otherwise right we can't change right ruler margin as no mouse
event goes through.

Change-Id: Id2f536ab6cb82908e17e4c293762160e8dd2fb8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92546
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-20 12:44:42 +02:00
Miklos Vajna
72cfcf7f3e admin_fuzzer: fix too large param to cpu_stats_size setter
Don't pop an empty container, also use stol() so it does not throw
std::out_of_range.

Change-Id: Id81cb00ccfb0ecc234b8f6fa89edf5a0d8c6d353
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92524
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20 11:18:05 +02:00
Tor Lillqvist
6b8456679f Surround some code that is unused in the mobile apps with #if !MOBILEAPP
Reduces the risk of starting to look into something that is actually
never used in the mobile apps, when your intent is to re-work
soemthing for the mobile apps.

Change-Id: I04c562758a1b336690c7adbfd32b260cf26d9f87
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92554
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-20 11:17:29 +02:00
Tamás Zolnai
f5b15b2564 cypress: fix some comments
Change-Id: I49a1d1ad255ae474ff0415ae5db6ad06caac2cfb
2020-04-20 11:05:00 +02:00
Pranam Lashkari
3b393ac4fc leaflet: resolved FillGradient command never being sent
Change-Id: I1abfd8a6a977d402ad8fd3b2382dcb74bbd291cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92515
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-20 09:54:58 +02:00
Miklos Vajna
4992de990d Proof: improve logging
Tell if the key loading happened due to a Poco vs std exception.

If we show the response headers, show the request headers as well.

Change-Id: Idb32e8c4d9cc5565647b99d6ddae27cd2faba46f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92518
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20 09:22:59 +02:00
Tor Lillqvist
927f77354c Bin unused variable
Change-Id: I382e8bd8f2430dbab7f9ec623299c461b747e0a4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92512
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-19 23:28:53 +02:00
Tor Lillqvist
e835bbf413 YAGNI: Bin bool parameter that is passed as true at the one single call site
Change-Id: I13b0ff612f8ca0970b3ab7fac3e92761c3c332d4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92509
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-19 22:05:29 +02:00
Michael Meeks
3e4ac31c7c killpoco: remove WebSocket includes from a couple of places.
Change-Id: I06740cd978bec8e6a74beb8ed9ef8f4f970a2535
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92470
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-04-18 18:29:04 +02:00
Tor Lillqvist
378a2b5295 Bin a couple of unintentionally committed LOG_TRC() calls
Change-Id: Ieadc06a38d71aed723191f1738f8f39154978091
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92476
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-18 16:35:15 +02:00
Tor Lillqvist
7a416cbf0a Clarify what ChildProcess and WSProcess are
Change-Id: I13dd37c840d2c8b811bb56614fbc9f8ee2e44d40
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92475
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-18 16:34:49 +02:00
Tor Lillqvist
2a16f34812 Don't use "kitbroker" as part of the thread name in a 'kit' process
It just causes confusion with the name "DocumentBroker".
DocumentBroker objects exist only in the WSD process. Instead just use
"kit".

Change-Id: I3d9915c4759899ea6ed9084cf3ec6dc0f3b88ee5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92474
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-18 16:33:56 +02:00
Tor Lillqvist
4eb598711c Use #pragma once
LibreOffice core uses that, too, and we support an even more
restricted set of compilers.

Change-Id: I0d0e2c8608e323eb5ef0f35ee8c46d02ab49a745
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92467
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-18 15:00:18 +02:00
Tor Lillqvist
21dfba7db7 Clarify what a DocumentBroker is and in which process they exist 2020-04-18 10:41:39 +03:00
Tor Lillqvist
4bc181e6c6 Use '#define FOO 0' instead of '#undef FOO' for stuff that is checked with #if
Change-Id: I8141022fc5cb622eeb63e5b28a99f0cd0a7affc4
2020-04-17 17:21:13 +03:00
Tor Lillqvist
53ef0936c1 Add ENABLE_WELCOME_MESSAGE
Change-Id: I54900694bd729419bd9c81ae2e7866b6597c3109
2020-04-17 17:21:13 +03:00
Tamás Zolnai
2fb4a9a1a8 cypress: mobile: add more test for text alignment options in calc.
Change-Id: Ib3f92d879cdf5bc5a54ba4fa005b3da05737d580
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92449
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-17 16:16:00 +02:00
Szymon Kłos
3a1cd33c90 Move ruler & menubar toggling to UIManager
Change-Id: Idaaa90e48bcfb3620e78ad8e4c859eacdb4ff7cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92416
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-17 15:59:17 +02:00
Henry Castro
5bc712c917 loolwsd: generate compile_commands.js
Very useful with vim plugin YouCompleteMe
with libclang C-family Semantic Completion

Change-Id: I9dfa9b16c5eb11c410d26e21086283c142a57228
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91860
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-17 14:41:32 +02:00
Henry Castro
cf61a5cf94 loleaflet: generate jsconfig.json
Very useful with vim plugin YouCompleteMe
with a TSServer-based completion engine for
JavaScript and TypeScript

Change-Id: Ib2961940f171691e10c2af10ebb911283ee1ff20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91861
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-04-17 14:26:02 +02:00
Tamás Zolnai
19821f0772 cypress: mobile: update calc text alignment test.
Change-Id: I14893d70ffff312b897c48fe43a4e2add34bb29b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92419
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-17 14:12:45 +02:00
Tamás Zolnai
729e8f8679 cypress: mobile: use a better workflow for using aliases / variables.
Since we are in an asynchronous environment, we can't just use
variables locally that easy. Cypress has alias feature to
introduce global variables and access them. Since these are
global we should init them anytime before use.
So a stable workflow seems to be this one:
* Set alias to an initial value (e.g. 0)
* Wait until it's actually set (e.g. cy.get().should())
* Set the alias to the value you need in the test
* Wait until it's actually set
* Move on with your test and assert on something using this alias

So we need indicators also for this variable to be set, before we
use it. This will make it work a sequential way, how we need it
to work.

Change-Id: I047373aa884b1ac7bac419cfb1811534c0e95862
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92417
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-17 13:41:29 +02:00
Szymon Kłos
75e11420d5 Introduce UIManager
Change-Id: I944622a352aae7951f3e69286bb163645fa23276
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92405
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-17 12:12:13 +02:00
Miklos Vajna
ee1d96fd05 wsd: 3600000 * 1000 would not fit into an int
Change-Id: Ib1ada4e2c51d1eff846130669255582e2cef097d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92406
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-17 11:33:47 +02:00
Miklos Vajna
ec3341591b clientsession_fuzzer: fix build
Change-Id: If793ad5d23f5b33d92ccfb681b279821f04a362b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92397
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-17 09:57:15 +02:00
mert
6c1f49d404 Android: fix tapping on file name doesn't open files anymore.
Change-Id: Ic5e34a1ee484fedc888d8fae58354241a3cd7beb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92212
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tümer <mert.tumer@collabora.com>
2020-04-17 07:56:23 +02:00
Tor Lillqvist
2c07a36b69 Fix comment
Change-Id: I726f3cd30a9a7d393a414efbaebabdc1807f4ecc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92388
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-17 07:23:58 +02:00
Ashod Nakashian
2f703dc5ae wsd: _isModified -> isModified()
Change-Id: I70e35dfede8ae37603bc26cb800223a369ae5e8f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92099
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-04-17 02:36:39 +02:00
Ashod Nakashian
40684c4687 wsd: const correctness and cosmetics
Change-Id: I46751dc0a6d7c693fd9ab371c1e9a12bac309611
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92098
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-04-17 02:35:52 +02:00
Ashod Nakashian
08b6151b24 leaflet: update the formula-bar in-place
This avoids flicker and unnecessary CPU utilization, and
makes Cypress tests more reliable, since destroying an
HTML element can fail tests, even if they are created
right after (it becomes a matter of random timing whether
a test that checks the presence of such an element passes
or fails).

Change-Id: I57f7afa26831c79d85b740fbc0894a7c30f380fe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91539
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-04-17 02:34:28 +02:00
Ashod Nakashian
ebfa3f82fa leaflet: refactor _launchCalcInputBar()
Preparing to avoid re-creating the input-bar
on every update message. This will not just avoid
flicker and unnecessary CPU utilization, but
it will make Cypress tests more reliable, since
destroying an HTML element can fail tests, even
if they are created right after (it becomes a
matter of random timing whether a test that checks
the presence of such an element passes or fails).

Change-Id: I8ff887578ebd719b05bb62059d3f0a0bbb929898
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91538
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-04-17 02:34:12 +02:00
Muhammet Kara
e2a6737a5b Move uno:Text param from core to online - online part
Change-Id: I3d3e9bf4496d9c327a437acb5d0e4e65dfe2d3c8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92391
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-04-16 23:12:06 +02:00