- Make it bigger
- Also size is not enough, specially for slides that have backgrounds
- Add white inner margin so there is a clear distinction between
- what is the slide preview (image) and its contour
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifee386b98d74c937efa35c19551334482ec18632
In dialogs we put tab list directly where tab control is placed.
We don't need special container anymore (setTabs is not used).
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9d26a64362ee2c6ae08b44bf2dc54baf7936d0d8
focused entry has a 1px border, make sure there is a space for it
in the treeview so we can see laft and right border
also make sure it works with RTL
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae65811b7e1a2c74f47be1cea09607e48ef661af
Fixes https://github.com/CollaboraOnline/online/issues/6254
Before this commit and with recent a11y changes generic btn hover
styles were bleeding out to multiple places where icon btns are present
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3855d081595a2d3aa56e58137e21aba5d7bf8532
before this commit the triangle was misplaced, under the icon instead
of side by side
(might be related to https://github.com/CollaboraOnline/online/issues/6236)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id8d118471dcb02b5bc79399a4319ee514af03c5b
icons or being set with a non 1:1 ratio, missing width in the css.
Also better to reuse the btn-size
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I55b005d83718da81d9a7a44193b6f9de7192d41e
Wait for user to press Alt+C combination.
Set width for mobile comment containers.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I4e4b47ba8b0b2dc05edc3aec6e6836009ce07b05
If the page widget (elements that end their id with Page) have just
one column this will not take effect.
Why: the grip-grap (for both columns and rows) of 4 px set in the
jsdialogs.css is enough for many cases but when we have a Page with
more than 1 column the 4 pixels is too small to distinguish the
different sections.
Dialogs affected by this commit: All with child content id ending in
Page. Examples of improved dialogs:
- File properties
- Char format
- Settings of Footnotes and Endnotes
- Paragraph (format)
- Bullets and Numbering (position tab)
- Page Style (border, Header)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iebe9f01b758f1af8b43317cdf01a44f74c70cc42
similar to d1991e177c
but his time addressing:
- outdated css rules (remove them). They are outdated because we
already have `.unotoolbutton.notebookbar .unobutton`. Plus all of the
with exception of `vertical-align: middle;` were being ignored
- Do not allow browser to calculate width and instead set the same
value as in height
- Move `vertical-align: middle;` to a better place
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idb2de12365727d0ed2886729d9effbf36ede31ab
Create a new CSS rule to make tabs' content lower enough from the tabs' buttons.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I3354b93711f1e93aa9c97c31b3717cad7b917351
with a11y we now have those labels set via <label> elements and thus
they are getting browser specific default style for line-height
- Set to the same line-height that they used to have before, when they were
<span> and were inheriting the line-height from <body>
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If9afa2217e5d357ea27b8e7fbb0d63f3acdee80c
This was introduced with the a11y changes (button is getting
browser default padding style)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic648cedc1d3c72e0ae53e8bd244f1a04da868d8b
Before this commit buttons were being generated with padding
this is not needed ( we already have safe margins applied to
the parent -> 'unotoolbutton' )
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4f1b4328131550d906cde3328c7de02daffd76a1
Before this commit we were setting buttons in places such as
the sidebar with weird ratio (not 1:1) this might lead to problems
when aligning, adjusting gaps. Better to adjust gap or margin if we
need bigger spaces in between
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id60cd6353de2ace2a066c0d1624000a09f0ca98e
- re-use btn-size variable
- make it clear that this set of rules is intended to sidebar elements
- Improve selector (more clear and so it doesn't target other
elements outside of the sidebar)
- Move it to jssidebar.css file
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib03c412a1e05fd6ed315f58a70486f14eaf5b9ea
Do not place px in light or dark mode css instead use the shared
cool.css :root for that
- This avoid outdated values in the future
- There was already one like that: --annotation-input-size
had different values between light and dark mode
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5cd95a36e160003101f6f92108bb5244bfafcdd4
Since we have change the generated HTML and now we have proper buttons
and img inside of them, there is not need to resort to this methods
since the img will automatically be centered aligned within its button
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I944f5c677c6d79f2f28645e4e8d081868f094262
After accessibility work we need to change how we target those
and also we need to revert that `height: 100%` and replaced with
24px so we can know for sure how much th element will occupy
and to safeguard for cases when the svg is bigger
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia4102ccc5c58d4807d8b05d360342c1ea7128c3b
This is a follow up on f9ad2ea3c3
with Change-Id: I1c200f2208b4f762d01dc6dd85459dbedce7b03e . It
leverages the flex added there to align and justify items.
What it fixes: Radio buttons not being aligned from the "left"
side and behaving slightly different in terms of alignment
if anything else changes around
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9cb6f24c16603f40acf797c6b68d4305f38cdc58
to make some space between elements in grid
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5379a1a7fd96cb1fe351cb5b52ce1433eaa7eb53
they will be aligned to the grid size so look more unified
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4900e7d4005d172226c23919505702f6926260b7
Target .ui-tab instead of .ui-tab-content
.ui-tab-content doesn't exist anymore, we can safely remove it
from CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I17df0fb9de73ffe8665291d9dded8715bed9963c
- Don't create empty parent button just to have a another button
inside
- Update CSS so the text rules are applied to the button's text
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f3a54a131a7a44109789a6612af8047963d8e7b
This changes tabs into button elements so they can
be switched using keyboard Enter key. It's also better
from a11y point of view
Styles has to be !important to override button styling
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia4ced59544be18ae79d41b4f837eeb31ab80b8ef
the commit 51bb1d3 with the following change-id
I16a5df46bced608952c22bf979808bc735645366 introduced incomplete
CSS rule, rendering the whole css file invalid
So we should add back the rules and just remove the vex classes
but and upon further investigation button are already inheriting
font-family from jsdialogs.css: .jsdialog-container .ui-dialog-content
so we can just remove it altogether.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab42230efc7341e8967ce776f0d3decf41655ba6
After reading Rizmut's commets, we should probably revert this for now
at least until we decide on the icon size while avoiding bluriness
This reverts commit e6782d6b5d.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Tabs were changed to buttons and thus we need to readjust the CSS
so text color and others are correctly applied to the text
Also add :not exception so the tabs are not styles as regular buttons
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1bc1681e86f17ee7afb435f7c3fc099b80abac2e
This makes any resizing or position easier
and it's what is expected from "buttons" (it's the default value)
and those icons are buttons even if the html elment is somehting else
Bottom line: better to account for any border and padding in the values
we specify for width, height, border and padding. This makes sure that
the content box shrinks to adapt to those values.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I39af02f983611bc751e764c26d13d955b7774928
- Make sure the grid columns of 'Find' and 'Replace'
share the same minimum
- the maximum parameter in minmax function (so min-content) is
ignored when that value is lower than the min value but it is
there for when the language has quite long 'Find' or 'Replace'
making that max width increase according to its contents
- Remove extra margin from checkbox so it gets aligned
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ica38b407f2a5936e3657dc067ac0658ef5b8aeed
Don't show scrollbars for hidden content.
Affecting data -> Sort and data -> validity dialogs in calc
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3124d921ef7819f274e9f583a605e63b66722388
