if make is killed or interrupted during the execution
of their recipes, the target is not deleted. So there is
an opportunity to check the logs, why are taking to long
time to finish the test.
Change-Id: I6e8176a48ff721ecb2b2efc01b1f149907dd359b
Signed-off-by: Henry Castro <hcastro@collabora.com>
Add profile zone around kitPoll function and SocketPoll constructor to
improve trace event generation
Signed-off-by: Gopi Krishna Menon <krishnagopi487.github@outlook.com>
Change-Id: Ia46e9add59a57935997649fe39861a8d851e1ff0
"Async" here refers a specific kind of data in the Trace Event JSON
format, not asynchrony in general.
Actually, we don't have code that would generate such yet in
loleaflet. Just the createAsyncTraceEvent function in Socket.js. Quite
possibly the "Complete" events (a.k.a. ProfileZones) are all we need.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I611ccd4b964bcacdd1050893f70dbdb813ee3c34
At least I didn't fully understand what the old code actually was
checking.
Also, use sizeof instead of magic numbers.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I01602a2e256b1fbe39793c9f1439e025461c5a72
Our JS code does not send 'textinput' messages with a 'type' parameter
either, so it is pointless to do it in a unit test.
(We still have code that checks for the 'type' parameter in received
'textinput' messages. That is pointless, too, and should be removed.)
Also, document what testWriterTyping() apparently is doing.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I4954379339f14e4a310a76788521001048d84e37
Since a99edb5d29 this gets a different lifecycle, and is often
joined and gone by the time we get to cleanup.
Change-Id: Ic21ca837d484a9a853c7f8f683e876406b00a943
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Set min-height property to prevent exceeding the available size.
slide-sorter: Set max-height to prevent over-sizing relative its parent.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib8c50bc9f6f6ac4311cefa3b0e016da728efe95b
* Use lineHeight rule for centering the elements on mobile.
* Use parent element's rules for setting the styles of img and preview elements.
* Disable mobile-slide-sorter. It is not in use for a long while.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I06517467f269669c70294fb5a4dd0960eb16feb5
It seems that fitWidthZoom function is impress-only.
I will turn back to this later.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I95b02d53299bf1b8ce7daf31121b67dccd1c817c
There are some inconsistencies with impresstilelayer.
I think the reason is that impress has overwritten some of the canvastilelayer's functions like in updatemaxbounds (old one).
I bound impress' onresize function to canvastilelayer's synctilecontainersize and deleted the workarounds.
One 1year old commit will be reverted after this commit.
Only change that is not related to impress is the FIXME part on canvastilelayer. So i tested the mobile views.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I2dd127bd8d2280f2897d8c58281541f0aaa3c50f
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".
Tested on mobile, desktop, tablet views with & without notebookbar.
The problem was:
On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
Instead, i tried to use CSS rules with flexbox.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20
There is an additional fixup for master branch included.
added missing uno commands
modified uno property to use full command (i.e: use prefix ".uno:")
some item had custom handling and adding uno property would interfere the correct functionality
but to make freemium work properly each item needs a command
to solve the problem a new propery to store the command introduced: freemiumUno
This unifies the button properties with other JSONs
This is also necessary for freemium, without uno property button can not be blocked
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I43fb0796507987817b8eb82828a506b1f874d8ca
Mobile:
- Checks if we are in presence of mobile mode and adjust layout
accordingly based on class
- Makes sure that the illustration resizes
depending on device's size
- Adds subtle animation to get the user excited or at least curious to
tap it (avoids making the disable status to dimmed/not legible)
- Fixes layout and buttons
Desktop:
- Adds hover state not only to button but to the locker
- Makes locker a discreet overlay above the respective button, suggesting
"this button is locked" but make it react so user is willing to click to
discover what is it
- Added CSS rules for top toolbar
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idbe66746c5ad07647cd62eb94d3b22a840bf70d7
Do not use external html file and instead use input attribute from vex
so we can send html while being able to use variables (those variables
should then be overwritten by integrator)
Also Fix styling and DOM elements creation:
- Avoid to many elements and messy notebookbar with multiple (states)
- Replace disabled feature icon with lock icon
- Also style it properly and make it similar in other properties as
the existent disable status
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9c2a07ef1fe5f089d5e63cb53d2d6b7f0b5083a8
- Add html file where structure can be changed
- Add illustration as default (in the case integrator doesn't
have one). Avoid any purple so to do not confuse the user about
who is requesting the subscription
- Set custom vex button text (to do: translations)
- Add custom class to vex so we can target it better in CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a4c0232f3728ba88f650ce28905ebfe2f6d9bfc
Also clear its input buffer explicitly.
Change-Id: I8badbb96d98eaf10433a65fcfd13b0d6d5893594
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Ignore input in a somewhat gentler way.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I758302dc3bb1aa87f9fbfa726f73f4b9339e08c2
This is really a garbage in -> garbage out situation.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ic1c33f44081f259e5cf5994ad901e1593fe8dfcf
Given that "digit" is always less than 16, we can avoid the "- digit"
in the condition (because the division turns that into 0 anyway), making
it effectively constexpr.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Iaf9e53d3543f2237c00768f214114a02a4746020
- So we can be sure nothing else is targeted
- Center illustration
- Container goes full width
- Fix Portrait and Landscape modes
- Add border radius so to differentiate this panel (busypopup) that
blocks the ui from any of the other ways we use the mobilewizard
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2391197477d465636143ca2b55c0723f60a4b339
This will prevent us from flickering if popup has to be shown
for less than 0.7s.
Change-Id: I5904e5f836dae40b83ca24d19e0b2fb779eb504b
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
When running tests in parallel, closing the server listening
port before all DocBrokers are terminated runs the risk of
the listening port getting recycled by another test. This
means that the new test might get unexpected connections
from the old test that is shutting down.
This improves test stability.
Change-Id: I2c6ac9e7ed9953813e0da6ab19b960b1edc1d1a8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
