Commit graph

758 commits

Author SHA1 Message Date
Pranam Lashkari
4bf0302a78 cypress: fixed test and enabled missing test for annotation
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8c1b4e6a679f31b9ebfa814b67f18b25eab3d2be
2021-01-01 16:10:59 +01:00
Pranam Lashkari
9e2b9f8972 cypress: modified annotation tests to work with comment wizard
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I25ff9c590aa12d1787d8966cc4f68151ed8d505f
2021-01-01 13:18:10 +01:00
Tamás Zolnai
c29ed235ba cypress: improve moveCursor() helper method.
View also jumps with cursor movement, so we can't be
sure that the vertical/horizontal pozition actually
increase / decrease. Better to test only that the position
was changed.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2358348c3f6d4f2278eff4e2db4a8409bc86b25a
2020-12-31 18:53:26 +01:00
Tamás Zolnai
dd22bde4d9 cypress: php-proxy: this workaround is not needed anymore.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2d74a30aa177051a0faf4c8f946779c2389a8d34
2020-12-31 18:53:26 +01:00
Tamás Zolnai
ae7e93144f update cypress: 5.6.0 -> 6.1.0.
Test code needs an update because .should('not.be.visible')
does not pass on non existing elements anymore.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If8a89d2996d154d287672dacb3668ec5399d99f2
2020-12-30 19:49:42 +01:00
Tamás Zolnai
63ee524010 cypress: disable welcome dialog via loolwsd config.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I15c060e5eac1993116828dfaefe8916030fe2b63
2020-12-30 19:49:42 +01:00
Tamás Zolnai
09fbbf43b0 cypress: extract clean-up code into a function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I572b164f89023cd66fca2d392b830417eb6a9d74
2020-12-29 10:42:51 +01:00
Tamás Zolnai
5ebbe451e0 cypress: simplify run_iteratively.sh script.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibdecf2a70d83a4ef4b021657b3238951d7bbd3b2
2020-12-29 10:42:51 +01:00
Tamás Zolnai
e8961e5123 Revert "downgrad wait-on: 5.2.0 -> 3.3.0"
This reverts commit a409b221f8.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I5662bfbf7b1209c0919eca2b8debefae9c82450d
2020-12-28 15:11:06 +01:00
Tamás Zolnai
8db4b19469 cypress: move includes of 3rd-party packages to support file.
Now we handle support file better for parallel test run too:
a13b1a93bc

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4a88f815ddb1c4d79042134cc07e0c418d4ea10f
2020-12-28 15:11:06 +01:00
Tamás Zolnai
d6663d807f cypress: record the loolwsd's command line output.
So we can catch crashes / debug messages of core code.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib11426e7fdd8f219be4715b3f1e2983ad33d7f2b
2020-12-18 21:20:27 +01:00
Tamás Zolnai
a13b1a93bc cypress: try to handle support file better during parallel run.
When we run cypress tests in parallel (e.g. make check -j4), the
tests randomly fail with an uncaught error. The issue might be
because the same support file is shared between the different threads,
and they might access it at the same time. We try to create different
instances of the support file via preprocessing. Let's see whether it
makes the issue go away.

Issue's error message was:
"An uncaught error was detected outside of a test:
SyntaxError: The following error originated from your test code, not from Cypress.
Unexpected end of input"

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7b256cd686fb2b0e79ab602e95d197388a5aadca
2020-12-17 19:12:44 +01:00
Pranam Lashkari
182515dcbf leaflet: open comment wizard on comment insertion
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I90bb301c35ba6d52c26a22dd0b686961b94181fd
2020-12-15 23:06:44 +05:30
Tamás Zolnai
8b815908c9 cypress: import 3rd-party packages everywhere they are used.
I see some random test failures:
"An uncaught error was detected outside of a test:
SyntaxError: The following error originated from your test code, not from Cypress.

> Invalid or unexpected token"

There is no backtrace or code pointer or anything to find out
what is the actual problem, but it might be related the missing
import of 3rd-party code.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ia2243852e825eee18c226d89fd17e92960daa129
2020-12-15 18:23:20 +01:00
Tamás Zolnai
a409b221f8 downgrad wait-on: 5.2.0 -> 3.3.0
We get syntax error from outside cypress test code.
It might be one of the 3rd-party packages. Revert wait-on
package to a previous version and let's see whether the
issue goes away or not.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I902536fd7124ebaca58a3491400606c89e5e7483
2020-12-15 16:54:43 +01:00
Tamás Zolnai
e368d04695 cypress: NC: make test retries work.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic8ca85e34de5ee26ee27d24a001de060b6169e86
2020-12-15 15:09:03 +01:00
Tamás Zolnai
f5c3e7c0ac cypress: php-proxy: reenable retries.
It works now, to run the same test twice.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0e288049aad42b9534ce3743c6d5a8d4a22bf926
2020-12-15 15:09:03 +01:00
Tamás Zolnai
319fb3d692 cypress: pass test state to afterAll() method in multi-user tests too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ia353c6933fae8098ae983d2196added263ba5784
2020-12-15 12:24:02 +01:00
Tamás Zolnai
2ab7c60743 cypress: make 'Merge cells.' test case more stable.
We need to wait until the layout change changes also
the cursor position, and then we can select the
table.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id66606e0992f3b298f656567d38753263ef29ab5
2020-12-14 17:38:03 +01:00
Tamás Zolnai
12f0e2cd31 cypress: use moveCursor method for table selection.
moveCursor follows the event-indicator rule,
which makes it more stable.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ief6e6c4d3a058c95652113229fd0ecbb65fb3e48
2020-12-14 17:38:03 +01:00
Tamás Zolnai
98146288ca cypress: improve moveCursor helper method.
Add a modifier parameter, so we can easily extend this
code with 'shift' modifier later.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I820c2c89838ba2a367d561e362d3c04f8487022e
2020-12-14 17:38:03 +01:00
Tamás Zolnai
b5d5129f0d cypress: add text cursor tests for Writer (mobile).
I've seen some inconsistencies related to cursor
movements in the existing cypress tests. I added
these tests which checks cursor behavior directly,
which might help to find out the issue with cursor
handling.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If158ccef359bb28ade8d7336594fdafdd46868f4
2020-12-14 17:38:03 +01:00
Tamás Zolnai
6720a3a3f6 cypress: update impress interferences test code.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I23f6c0298887d119793ce2b7184b3c14572f64b5
2020-12-10 13:36:34 +01:00
Tamás Zolnai
e8bad8ed60 cypress: add 'run-interfer-desktop' make command.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibfb2bd3e6158da72a160cdfdc8507f9887cbdcfa
2020-12-10 13:36:34 +01:00
Tamás Zolnai
f917ece93a cypress: add 'check-interfer-desktop' make command.
To run interference tests for desktop tests.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibe06399846a37345ab08fd830b6350fe12ba2e37
2020-12-10 13:36:34 +01:00
Tamás Zolnai
7a190deb21 cypress: restructure makefile: group interference related code.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I95bb115e41704d2912f3ed48b7e193ea648364f5
2020-12-10 13:36:34 +01:00
Tamás Zolnai
cb662aab1f cypress: let's be more specific here about which selection marker we have here.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I965819fa4f5cf7b299dfd411a44fef6e267db250
2020-12-08 20:21:36 +01:00
Tamás Zolnai
c2d41174f6 cypress: remove some unneeded assertions related to cell selection.
The visibility of the selection marker is already checked
by clickOnFirstCell() method.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I5bf258b7c912ff1730b6d26900563ad8b454106f
2020-12-08 20:21:36 +01:00
Tamás Zolnai
963f97349f cypress: add helper methods for text selection.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id799c5389adb518e42aac7c5838e27405d4ecb1f
2020-12-08 20:21:36 +01:00
Tamás Zolnai
a5ec1800d9 Revert "cypress: remove this workaround."
This reverts commit 550f04f94d.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I536cef824919fe94d3985a82bdfe13f7de0b1935
2020-12-08 17:50:39 +01:00
Tamás Zolnai
5f80d8290a cypress: fix 'run-multi' make command.
5 seconds gap between the two users was moved from
js code into the makefile in:
9ff0f3e9fe

We need it for interactive run too.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic8aa541ce30f3146a61875ea66c904e65f0d6cf9
2020-12-08 14:24:18 +01:00
Tamás Zolnai
7422663234 cypress: put loolwsd log under cypress_test/workdir folder.
So it's easier to find the loolwsd.log of the last
called command.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4d597a3d6683360ef03f15061a68a30db8ae498e
2020-12-08 14:24:18 +01:00
Tamás Zolnai
bd6cfefc29 cypress: add 'run-interfer-mobile' make command.
For running interference test in interactive mode.
The interference user is run in the background and
the user running the test code is displayed in the
interactive test runner.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I3595a618f78603ed3e5321969a7395b60555470b
2020-12-08 14:24:18 +01:00
Tamás Zolnai
d7bb312776 cypress: use moveCursor() helper method in table tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic24458ca4aa32c3a883e6cfc018ca0429071cb43
2020-12-08 13:46:40 +01:00
Tamás Zolnai
550f04f94d cypress: remove this workaround.
The related issue was fixed in:
dc18239d07

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id0770d11fcaf8eb385b60ddf4286e804127999ca
2020-12-08 13:46:40 +01:00
Tamás Zolnai
35fe0b9541 cypress: remove these useless lines of code.
It does not actually do anything. Font size is not
stored as a 'font-color' attribute.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8e39a7c1064bce386c85ff21811fc6f95253adc0
2020-12-08 13:46:40 +01:00
Tamás Zolnai
4950ca4197 Revert "cypress: use moveCursor() helper method in table tests."
This reverts commit e1ed5d3c299f2664d108375a5ea3cb90814556a4.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I9684921837ed6f55a74fb45750bff6c890996a59
2020-12-04 23:10:56 +01:00
Tamás Zolnai
337e570d1c cypress: use moveCursor() helper method in table tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iace8fab305bba260c19d8fc7086caa24d20f6782
2020-12-04 16:33:26 +01:00
Tamás Zolnai
77dc334325 cypress: generalize mobile interference tests for Impress.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idcccd74d0c58f768189b488f85158e225130c41b
2020-12-04 16:33:26 +01:00
Tamás Zolnai
9b181385b1 update cypress: 5.5.0 -> 5.6.0.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I6a290e8520311a89d2c5e214152be58bd7e2904e
2020-12-04 16:33:26 +01:00
Tamás Zolnai
0c08b6dad0 cypress: php-proxy: reenable table related tests.
There was an issue about tile invalidation related to
Writer tables. This was fixed in the meantime, so we can
enable table tests. I added an additional fix for
these tests to make it work with php-proxy too.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id3f8288b65e597a49f0a45c8d106d5ed9f6ead46
2020-12-03 14:56:19 +01:00
Tamás Zolnai
f5feb26173 cypress: disable this multi-user test.
It randomly fails recently. The issue is something related
to the text selection at the end of the test. We'll need
need to investigate that later.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ifba3d52d569fa41920e073b809ed12b60f761103
2020-12-03 14:56:19 +01:00
Tamás Zolnai
93403db249 cypress: generalize mobile interference tests for Calc.
Also use a bit longer waiting time for mobile wizard to
become idle. With the interfering user the timing is
a bit different.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4f24c700cd718bd129b713f2fd12819f92772b64
2020-12-03 14:56:19 +01:00
Thais Vieira
a335e6763e impress/cypress: add tests for font size
and font name.

Signed-off-by: Thais Vieira <thais.vieira@collabora.com>
Change-Id: I959a7bc455371504897e03dcc0be8b26178b0202
2020-12-03 11:33:14 +01:00
Tamás Zolnai
979afcc0a1 cypress: NC: disable failing 'Automatic spell checking.' test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I6762c08b9a921eb942ee537195cbe530f3260dc1
2020-12-02 15:03:38 +01:00
Tamás Zolnai
a95de9a799 cypress: remove this prototype of interference testing.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibb7c84a2c701770cb4064c04223fc1fe041d624e
2020-12-01 13:25:20 +01:00
Tamás Zolnai
52bb718620 cypress: introduce interference testing for mobile tests.
Added `make check-interfer-mobile` command for running
interference tests. Now it works with writer tests.
I'll generalize it later.


Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2181a8653d61cc6ed873e2887a3e42767f46f177
2020-12-01 13:25:20 +01:00
Tamás Zolnai
e631406805 cypress: make sure the cursor is visible after step into editing mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ia30f6fe79c3318c2663d8da1d3d197fb936b0088
2020-11-30 15:23:18 +01:00
Pranam Lashkari
1c1274a5fd cypress: disabled annotation/comment tests
mobile tests annotation tests do not work with new comment wizard
tests needs to be rewritten so temporarily disabled tests

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I66e8f88cdbf921060af083e84d73b372e03f8dda
2020-11-30 06:31:15 +01:00
Tamás Zolnai
94c7c23f31 cypress: don't use togglemergecells as an indicator here.
It's state is inconsitent and so it fails randomly.

Change-Id: Icd84d618fc87e64228918ad2e6e1ac602eac0e05
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-11-26 14:48:24 +01:00