Move Align settings into a drop down menu instead of buttons, cause calc has 7 align options.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I1bbe1ed8b8ef7ada8e56486fef44b962e8dc50d7
Cypress error said annoration was covered by sidebar.
Hide sidebar and select 50% zoom to show annotations on screen.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6a63c4e95ea0de5ad0338344098e49b387b6c54b
- menu was visible and covered center of the image
- sidebar was covering image in the impress - change zoom
- temporarily introduce delays so slower sidebar will not break tests
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I65eb7a7337880ce48f89669c038a88fde5c67493
and enabled cypress test mobile/writer/annotation_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: If72e6f98acf5fcad1202332fa6521d7ad0e35e83
added id field in table option of menubar and moved _refreshRowColumnHeaders to canvastilelayer from calctilelayer
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia2e492cb6edcd65ba2444da34795fe367b25e887
Default cypress view is too small, scroll first and then
attempt clicking in the bullet icon. This fixes failing tests
on this spec. No need to skip the test anymore.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idffbfec94f94c784b03815c21ece0b8d38a8ba0e
* No AA bleeding: render pixel aligned (ie. 0.5 offset) for all hair-lines
* Two pixel wide line, around the cell - black; with the inner pixels /
line exactly on top of the cell border.
* inside this breaking the outline - an internal white border which is
exactly 1 pixel inside that black border - for a high contrast look.
The change introduces CPathGroup which is just an array of CPaths that
allows separate styling. CCellCursor and CCellSelection classes
specialize CPathGroup and implements the above three guidelines.
The view cell-cursors and view-selection also use the same
implementation with different styling.
The cypress tests are updated accordingly for the name change in the
test-div.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I8881337df6cf8d543bd48e8de4560d9aab681dff
(cherry picked from commit d12c8f24bcc2e9d00da7a2fef114f1522f478e93)
because it is tunneled now as drawing on the canvas
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I76c7d218abf155b2bd835d9f74b46d02e2808bbc
when two or more tests share the same document one or both the test are failing
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I638a76f8f98eff019a298bcafcbe89155442bcde
problem:
every time running cypress test would change the properties,
in alphabetic order
this will make sure to avoid unintentional changes
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id7b955ad2154ec6393a4cb9d115f369db25b5008
introduced annotation tests for mobile calc, move insertComment function to mobile-helper
added new classes in annotation edit fields to distinguish reply and modify
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I22072037c858c97250d50a8c323893cfbdc31b60
Set up support for performing end-to-end tests on the fullscreen
presentation.
Added 2 tests:
1 - check text fields (slide number, slide name) are correct for the
current slide
2 - check the background for current slide is referenced correctly
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If8d3cda49254a910aa0c5d2d672834aa5b029e0b
Fix some issues it found and disable the following checks for now. Some
of them needs module support to work and some of them needs project
compilation using tsc rather than per file compilation.
cypress_test/ extends loleaflet's eslintrc so, its package.json needs to
have the typescript lint plugin as well.
Disabled checks:
@typescript-eslint/no-unused-vars // This can be enabled after fixing
all places it finds.
@typescript-eslint/no-inferrable-types // Lets do explicit typing
whenever we can.
no-var // This needs a lot of conversion of var to let.
@typescript-eslint/no-explicit-any
@typescript-eslint/no-namespace // ES5 has no module support
no-inner-declarations // ,,
no-constant-condition // This is sometimes useful
@typescript-eslint/triple-slash-reference // ES5 no module support.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib4fd8b4fcee42216d4322fd043a1873302db375a
- split helper method for loading document into 2 pieces
because in case of interactive dialogs on doucment load
we need to perform some action before we can check if document
is already loaded
Change-Id: If6caf2168498a6d185c4a5199cf4b10b32ca23b7
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Now we hide selection handlers while typing due to
not being able to use them, these tests fail to find
rotation marker. When text is found on mobile selection marker
wraps the found text and they become visible. when not found they
become hidden again. Checking the selection marker for this test cases
should be enough.
Change-Id: I6037450bc17438e4819ae3b724849f74f26910d4
Signed-off-by: mert <mert.tumer@collabora.com>
For calc we have 5 svg nodes inside the overlay pane (fixed, top-left,
top-right, bottom-left, bottom-right). The shape selections will be in
all panes except the 'fixed' pane. The 'fixed' was used to contain the
split/freeze lines but that got moved to canvas. Before this patch the
'fixed' svg was getting selected by the selector...
'.leaflet-pane.leaflet-overlay-pane svg'
...which is empty in this case. Lets always select the bottom-right one
which is covers the whole view area when there aren't any active freezes.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Iea2bbeff3c492a82e75ecdeb1aa70fa3c33f3426
but in a dedicated div inside the canvas container div, covering the
canvas.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ie43a4cb98c9cdb7e3ca81faa78bcc2419fa90a32
Some tests were relying the cursor position for checking the document
dimensions. Those code lines are removed from the tests.
Document size is not able to checked from html elements. Instead, a unit
test may be prepared for that task.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Idd4fd52656b2969bf0bfa9534a807a7a8bd3f987
php-proxy slows down things and make it visible, that
cellA1Bounds and cellC3Bounds can be initialized to the same
value. So let's wait fo the cell cursor to be updated before
we set the cellC3Bounds value. Changed the toString() function
to exactly match with the json in the overlay items' text attribute.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idde0f516ff568cb14b5d53224fd75ebc6167abe9
In the cypress.json we configure retries for headless mode only,
however when we run 'cypress run' with 'headed' flag we still have
retries, that we would like to avoid for consistency.
Cypress differentiate modes based on the command: e.g. 'cypress open' or
'cypress run'. We however differentiate based on headless or headed mode,
whether we run the test in an opened browser or in the background.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib34ac3de105dfe410116019e3c3c2afe253636f2
We always have a cell selected, so we can move the cell
cursor left and right anyway.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I11c255bd38fb927652c9afd2f111ce9e2acce103
Using autofill marker as an indicator is not that reliable,
because it's missing by document load. The cell cursor overlay
however is always there.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I87e92efe78d492b3c66fb04e3b2ca25d4f122584
cypress video recoring does not work when we have two cypress
instances at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib807a001aa497ec9c7ef98df4f8f40236890879c
Currently only the cell-cursor and document selections are part of the
canvas overlay. The others are still part of svg layer.
For now only the bounds of the canvas-overlay items are asserted. The
canvas overlay items update their bounds data as JSON text on cypress
only divs inside the overlay section div every time there is any change.
Unlike cell cursors, the selections need not be always a single
rectangle. To add tests for the more general cases, the json format of
test data is helpful.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I70e6328116c44317f31deb9c8bea62e781d8c421
Workdir folder is for the build system, and for copies
of data files. cypress folder it for output of tests, like
videos, screenshots, cypress logs. So let's put wsd related
logs here too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icdb757d50d3c2bfef6013b92055b49ba222193e2
To make workdir structure easier to understand.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1d0d8a16bd12cf9fc9abf9d350509f20ad322a7a
It can be confusing to have the same error message twice.
This reverts commit 6786f563f8.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I66f0495262fc5e5c0a228fdfc417e2e3301ad03e
This assertion is triggered by interference testing:
make check-interfer-desktop spec=calc/tunneled_dialog_spec.js
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib16c97d7c45192a493720d028f38eb5efba4346f
To avoid issues coming from the delayed autosave.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib98b35396efb4fdfdf84846dd23619c666accbdb
So we have separate canvasShouldBeFullWhite() and
canvasShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0932a7615c84c35293c2cc8dade0db6468de8224
So we have separate imageShouldBeFullWhite() and
imageShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2ada6b9e6f6d93b8a48e9ddd3c851ef3e6fcd632
By now, we don't run the same online branch against more
core branches, so this code is obsolete.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I90768d16628e735129880cc4cf823bf0b7d9ad1e
We use this method in various contexts, where it's not
necessary that we have the cursor of the focus. Focus can
be tested in focus related tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic27de45917657d4ac1734565d81d5bbf190ad333
It does not work when two cypress instances running at the
same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iae7fe4c4dcc4bb0a970763001e4f966b60f988f2
It's not necessary to have any text in the first cell, so
double click won't work for every test document. However the
spreadsheet is always there so we can move the cursor through
the different cells.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icea63a971fb77d915e027569a80c9a8a8b855a01
This reverts commit 129ae61684.
This is actually undefined, whether the cell cursor would be there
or not. We get cell cursor messages after loading the document,
so if we step into editing mode before these messages, then we
will have the cell cursor, but if we wait some seconds after
opening the document, then the cell cursor won't be displayed.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7a4e9e5adbbbe312f21789fe872726bbf67565e6
There is no more span inside the HTML representation
of a text field. After this commit:
b982d0e6f94ca70765231ff4242c829f5bec5def
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic64a20dcb0534876af062a1fb40cb0e39fd27f10
CanvasSectionContainer has now capability of creating divs below sections, for testing.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia735758ce27af558718da50935502723112e838e
It causes an issue for calc to use cypress's dblclick() method
and it will select the wrong cell. In the log, I see only a
double click when we simulate user events with cypress, however
when I do double click manually, first I see a single click and
then a double click in the log. So let's do the same with cypress
simulation too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I18e92fc354558e09bb5cb3a12e45cbb669ac97bc
Visibility of the blinking cursor is not good enough
on dekstop, beacuse it changes position after it is
displayed. So let's wait some time to step cell editing
mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I86fe7fd5be68f36126ba3d390b29740b33cf3d8e
So we can specify which cursor we need here. The default is
the document cursor, but this methods can be used for
formulabar cursor or dialog cursor too. More cursors might
exists at the same time, that's why simple '.blinking-cursor'
selector does not work.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1fd04e188ab53e70d0e8303fd7502f183c18bef3
We have a dummy spreadsheet document with a column of cells each in a
different font size. The font size of the current cell is displayed in
the sidebar.
In the test we step through the cells first downwards and then back.
Thus the sidebar image that contains the font size will be updated as
we step through the cells. At first nothing will be found in cache,
but when returning, the images should be found in the cache. If the
cache in the JS client is not consistent with that in the server we
will throw an exception.
Change-Id: I439263c7923d985679fafa0125cd2d7f635e0995
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It's a useful option to create a video during headless run.
It's much closer to the headless build wrt. timing, than
interactive test runner.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic9889209ac07b9fe0a9b6e326e60513412950780
In master view, the 'Master Slide' list should be empty and so it's
not shown on mobile wizard. No, I disable this test, because
it needs the core code to be updated.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I12562c453673ac85e050303ebb5803fee6f1892a
It fixes a hang related to retries. It might be useful
in our case too. I've seen hangs on Jenkins, which might be
related.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8320f9b38c59074d2b5dd3d7b0cad0c5828b0849
It crashes if the mobile wizard is closed before exiting
chart editing mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I47143543220aaebf474e1d1aa560c7df2c2a14f5
We had an issue with loading two views to the same document
at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8b1ba92eca5e59bfa50cbcd637f1076d5e15c664
This reverts commit f6bf6f49ed. I did not
consider that this makes it harder to do a local developer setup with
reverse proxy + make run; also that if you don't read the doc to set up
a reverse proxy, then the default now serves http content and advertises
https, which is not helping sysadmins.
This needs more thinking how to improve one scenario without hurting
others.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ic789faa2dc5bb19a79d651dc81d4eaaf0b48607a
Before this commit failure logs were gathered inside an error log
file and they were displayed after all tests are finsihed.
After this commit we print this failures logs when the error occurs
and also at the end of the test run. Sometimes Jenkins does not finish
the whole build because of timeout abortion. In this case, it would
be helpful to see some failure logs.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibe7cb6aa2c9f99912d604c4b642cda363352ffcd
cy.click() will grab the focus to the textarea.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I20f0df2fd8a31d3ff4b85ba38fdc503c10987dbb
The intention is to have defaults which are close to how people
typically use Online in production.
However, keep using ssl for 'make run', so that the https environment in
the browser is unchanged.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I7fd725a83b0e9ca1012f2c0e0c3bf038e5fa0059
Now we have it in the general calc helper file.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id7f12441b9612a630f6b348a9e6db6235f4b6c45
By now 'make check-mobile' and 'make check-desktop' commands
are not supposed to run in parallel. So 'make check-mobile -j3'
won't run mobile tests in parallel (three tests at once).
However, before this commit running these make rules with more
jobs, led to build failure. With this commit the build does not
fail, but still ignores the jobs and run the tests on a single job.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I13e13fdefcfb393ae5a42b4e065bbfe00278236a
