Commit graph

10 commits

Author SHA1 Message Date
Tor Lillqvist
f847897e77 Drop the pressesEnded method that did just logging
It didn't even call the method in the superclass, which surely was
wrong.

Change-Id: I081e3d6650a71c8527b31f1b3fc5f5df9b41379b
2020-10-09 12:33:14 +03:00
Tor Lillqvist
3101e45c21 Fix the describeUIPresses debug output
Change-Id: I806a232e9ec0922b42c5405f707295a05dbf5cd8
2020-10-09 12:33:14 +03:00
Tor Lillqvist
91957175b0 Introduce @available check for -[UIPress key] which is from iOS 13.4
Change-Id: I661a4a57a4e5422f7e5f45d81635d54ea0f330e1
2020-10-09 12:33:14 +03:00
Tor Lillqvist
301c76354c tdf#133279: More hacks to improve keyboard functionality in tunnelled dialogs
When keyboard input has been directed to one text field in a tunnelled
dialog, and the user taps in another field, we (for some unclear
reason) then get a UIKeyboardDidHideNotification, but we do want the
keyboard to stay usable, so make sure that happens.

Change-Id: I6d0ba9ab65027ad1f687b2bc98b2294e061376d5
2020-10-09 10:34:30 +03:00
Tor Lillqvist
4eea5bd4e8 tdf#129371: Handle Cmd-A, Cmd-C, etc in _COWVKMKeyInputControl
We can't let the normal UIResponder and UITextView mechanism try to
handle the clipboard (well, "pasteboard" is what it is called on iOS
and macOS) commands as the UITextView has no idea about the *real*
document being edited. The paste command in theory might work, but
best to let LibreOffice core handle that, too.

Change-Id: Id130708ceb5718660af26367538a17a14238843b
2020-10-08 20:33:57 +03:00
Tor Lillqvist
c8b1b8623a tdf#133279: Add another workaround for loleaflet weirdness
Ignore a hide command that quickly followed a display command.

Change-Id: I7be71dbc3ccdffb9db78de4a6b70d59baee14457
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103713
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-30 21:28:52 +02:00
Tor Lillqvist
894c51d6d4 Fix warning: block implicitly retains 'self'; explicitly mention 'self' ...
... to indicate this is intended behavior.

Change-Id: Id5318bb20b8066364c5e2fd3b704b5a73bac1b42
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103711
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-30 18:36:33 +02:00
Tor Lillqvist
3df718aac7 tdf#133284: Improve hardware and on-screen keyboard in the iOS app
This is a quite complicated change that should both fix tdf#133284
(cursor keys on a hardware keyboard do not work in a spreadsheet
document) and also improve the interaction with
CollaboraOnlineWebViewKeyboardManager that manages the on-screen
keyboard. We need to jump through complicated hoops in order to get
the hardware cursor keys handled right after loading a spreadsheet
document.

In the CollaboraOnlineWebViewKeyboardManager case we try harder to
keep loleaflet's _textArea buffer in sync with what the UITextView in
CollaboraOnlineWebViewKeyboardManager uses to provide suggestions
above the on-screen keyboard.

Also merges in related changes from today to
CollaboraOnlineWebViewKeyboardManager.

Change-Id: Ic4acb54bd4e815aa8bfb2bf40b08493446ae5ab0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101878
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-01 17:24:36 +02:00
Tor Lillqvist
67c2ca90da Update CollaboraOnlineWebViewKeyboardManager
Update to latest commit, d7f8383603aa156611d901f5f073666ab45d5e6a.

Change-Id: I24c2bf8fed7d692ba8ea747f3384c8e154f7c8af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101556
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-08-28 19:14:31 +02:00
Tor Lillqvist
2a8db1b5ab Use CollaboraOnlineWebViewKeyboardManager
For now, just copy its source files here. When/if I figure out what is
the appropriate way to package that framework for use in other
products (like the Collabora Office iOS app) I will use that instead.

Change-Id: If808f96b6a72c80e54dc84fce80a551503c96335
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101268
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-08-25 13:41:20 +02:00