Commit graph

232 commits

Author SHA1 Message Date
Tamás Zolnai
35290a0487 cypress: mobile: improve logging related to calc spellchecking test.
Change-Id: I8a57e9d90eff157f22d0cb37a59a4059ac862fd7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91839
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 18:06:11 +02:00
Tamás Zolnai
af40fb3618 cypress: add some logging for helper functions.
Change-Id: Ib8ff54208d47c7d921615f72b530e2404c26f3a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91828
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 16:36:59 +02:00
Tamás Zolnai
7826d75b45 cypress: mobile: extract openHamburgerMenu() and closeHamburgerMenu() method.
Change-Id: Ib288ccabee7aa06c5e9b8b0c54ac88055c1ae820
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91827
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 16:24:53 +02:00
Tamás Zolnai
dd42ea0da7 cypress: mobile: extract openMobileWizard() and closeMobileWizard() method.
Change-Id: I02e33406510ade9cfc6de5f31854cee99a7c1fc0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91823
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 15:32:16 +02:00
Tamás Zolnai
b045fa90f2 cypress: mobile: create a separate mobile helper file.
Change-Id: I3d57a8a691f8085db12b00e7b508295ce8f33a26
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91807
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 13:50:07 +02:00
Tamás Zolnai
aeb48c3ad5 cypress: Catch any "Error:" in log.
Change-Id: Ia82f896e7ff4299e25ac38283f0e518bef25f875
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91808
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-07 12:40:16 +02:00
Andras Timar
8f45843b78 typo: sinfieldcontrols -> spinfieldcontrols
Change-Id: Id5312df67259cfc177e29635fb27ba2498c58100
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91776
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-06 20:39:44 +02:00
Tamás Zolnai
d41348e841 cypress: add the issue link about hash values.
Change-Id: Ied7d05a2b5d112c222076d5799e44dd89a2f8641
2020-04-04 17:09:41 +02:00
Tamás Zolnai
17464beec3 cypress: mobile: fix calc test documents.
After this commit:
9374a28835

The view jumps to the cell cursor, so we should have
the cell cursor at the first column to avoid view
change after opening the document.

Change-Id: Ie577ab932496a5506e69b84bf7ff362d98950e92
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91682
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-04 12:24:29 +02:00
Tamás Zolnai
d55bb5e32b cypress: mobile: fix 'Focus on second tap.' test.
The actual problem was with the test document.
The selected cell was in the fourth column and
the view jumpped to it. So I moved the cell cursor
into the first column, so there will no jump when
opening the document.

Plus reworked clickOnFirstCell() a bit.

Change-Id: Ic132d1ef5392c1653060f84caa6c39f2033f8598
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91661
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-04 12:24:23 +02:00
Tamás Zolnai
4246d1e73a cypress: Catch also timout error of the new cypress-wait-until package.
Change-Id: I0b9856bbf933040a107c6cb8fe738d7a9f30a4a1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91653
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-03 18:19:33 +02:00
Tamás Zolnai
4bdd0497ed cypress: mobile: avoid animations in mobile wizard.
Cypress sometimes fails with 'DOM element is detached'
failure because of the animation in the mobile wizard.
Disable animation instead of waiting for 100 ms.
I tried to override $.fn.show() function, but it's
actually overriden by JQuery.ui code.

Change-Id: I0e8e937a501a99b1106d7a450088760f67102bc2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91569
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-02 17:13:25 +02:00
Tamás Zolnai
e814adfb28 cypress: integrate cypress-wait-until package.
There are cases sometimes, where we can't use cypress'
nice retry feature for waiting to an assumption to
be true. A workaround for this issue is the cypress-wait-until
package, which makes us able to use the retry feature for
any use case.
An example is the position of an element. I don't know
a way to wait on the position to get changed in the cypress
test framework. So we can use cy.waitUntil() here instead.

Please use this new package when it's really necessary,
do not replace the better cypress calls with it.

Change-Id: I8c553456e351664e30043b8ccd5ace51f1c0298d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91554
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-02 13:50:06 +02:00
Tamás Zolnai
3f358cbb80 cypress: mobile: try harder to remove selection in calc spellchecking tests.
It's a known issue that text selection is persistent,
which made these tests unstable. So use a different method
to remove the text selection.

Change-Id: I46b0ba268a39bae9e79ce62686b2d1e0eab1adda
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91486
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-01 15:04:58 +02:00
Tamás Zolnai
d90aed7cf0 cypress: mobile: make impress spellchecking test more stable.
Change-Id: I3fe512eb5da0bcdab905f023f51ce03af7e503f5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91487
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-01 15:04:49 +02:00
Tamás Zolnai
304f3e3d7c cypress: mobile: this focus test is still unreliable.
Change-Id: I10556880dfa87bc4afea0f5b76b719a5ffa658d0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91433
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-31 17:47:05 +02:00
Tamás Zolnai
112882a3f7 update cypress: 4.1.0 -> 4.3.0
Change-Id: Ib8d642e0ba7b02a20207c53e1134d08dc92b2840
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91427
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-31 17:05:05 +02:00
Tamás Zolnai
c73956e78e cypress: mobile: enable this focus related tests.
Change-Id: I1a9dd2967c4238c123c150bca04ca1e8909aeacb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91426
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-31 16:33:51 +02:00
Tamás Zolnai
9add51eaaf cypress: mobile: disable some number formatting tests broken on core/master.
Two issues here:
* Select All does nothing if one column is already selected.
* Three number formatting item is missing from the mobile wizard.

Change-Id: I1f3976ba01c7cf53a58e08d37a5f55f14c3f154f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91417
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-31 14:35:27 +02:00
Tamás Zolnai
ab10cc1c83 cypress: mobile: number formatting tests in Calc.
Change-Id: I07b919f4bc06f5f368c23b5fed014cb5011c8e68
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91411
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-31 13:30:04 +02:00
Tamás Zolnai
f57fb8a91d mobile: add special icon names for spelling context menu items.
Change-Id: I9f5388a57f3f2079a0accbd8f43fc884a618af1f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91276
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-30 15:56:57 +02:00
Tamás Zolnai
952a7acd7e cypress: mobile: remove accidentally pushed only().
Change-Id: I78bcf632cc135a785296ece9a7e1c07070cd71ca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91092
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-26 17:11:31 +01:00
Tamás Zolnai
732a69e69b cypress: use hardcoded value as WSD hash.
cypress test framework has a problem with some
specific hashes (for example: 769e98018) and it
do not pass these values to the test code, which
make all test fail with 404 error.

Change-Id: I385b1621de25fdf90e6169bdff25eaf3c18cf81e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91101
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-03-26 15:58:22 +01:00
Tamás Zolnai
30161c9b4e mobile: don't show a dummy mobile wizard before sidebar content arrives.
If we show the mobilw wizard instantly after the mobile
wizard toolbar button is pushed, then mobile wizard will
be an empty bottom panel with an undefined content. It's
better to show the content, only after we get the
sidebar content from core.
For example, if the hamburger menu was displayed in the
bottom panel previously then we will see a white screen
first when we push the mobile wizard toolbar button. This
white screen is the background layout of the mobile wizard.

It looks wierd and also makes testing hard since we have
some wierd dummy HTML structures.

Change-Id: I852bce1ca1460b2210229bec294a249a47523099
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91062
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-26 12:45:35 +01:00
Tamás Zolnai
98c08b50ce cypress: mobile: fix line width test in shape related test suit.
Copy+paste error.

Change-Id: I558f8d76df7cbec8c34645a02fbe1e9efbfe1f22
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91063
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-25 23:09:03 +01:00
Ashod Nakashian
e9157a886f leaflet: don't allow focus stealing
This improves typing in the formula-bar.

Change-Id: I14359b5b4e842b68b1807d286e1831b3805bb4ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91019
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-25 12:29:14 +01:00
Ashod Nakashian
2d36b936ba leaflet: shouldAcceptInput -> canAcceptKeyboardInput
Clearer name to differentiate intent from expectation.

Change-Id: I74cc4c3bca11782bdd9cf72d6af4534357cefa64
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91016
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-25 12:28:37 +01:00
Ashod Nakashian
d6526b4982 cypress: check keyboard visibility when editing shapes in writer
Change-Id: I1580f4620459797b95eecb88edbcd12406531618
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90992
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-25 12:28:21 +01:00
Ashod Nakashian
0b7f70786c leaflet: do not expose map to cypress tests
We only need to expose a couple of helpers
to test the keyboard and clipboard, which
are not possible to test via the UI.

This patch reduces the surface area of
exposed code to testing, to avoid misuse.
The only needed helpers should be made
available, and they are read-only functions,
so there is no risk of changing the internal
state from test code.

Change-Id: Id4a1800e3d3b9364754a18fb11f61df612e56490
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90991
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-25 12:28:09 +01:00
Tamás Zolnai
9f20130c9f cypress: mobile: reenable this test.
Change-Id: I9cf356b3c7e41ac0a07f82124bd26b16a9a57cd2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91035
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-25 11:35:17 +01:00
Tamás Zolnai
44e219ce55 cypress: mobile: disable this unstable test.
Change-Id: I0205637fa5a167062de16e1fe389b6f64eaed148
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91030
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-25 10:42:39 +01:00
Tamás Zolnai
823207f244 cypress: mobile: fix-up shape related tests.
Change-Id: Icbb0812e5c2446dc04010d11a79e692e89104f9f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90932
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-23 20:18:09 +01:00
Tamás Zolnai
efa7d4a08a cypress: mobile: better way of pushing hamburger menu button.
Change-Id: Ifa4ebc3e490dddcdeee476c368b33a3cedd6ef17
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90931
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-23 20:17:59 +01:00
Tamás Zolnai
7ad798df47 cypress: mobile fix random failure in spellchecking tests.
Change-Id: I89a915ef0a7efefd1e684d30b4d04f7cb7914cad
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90929
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-23 19:34:07 +01:00
Tamás Zolnai
49e97638b2 cypress: update README.
Change-Id: Iacf4bd05b01f0ceb4f6d976f979db62afaba091b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90784
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-20 12:45:23 +01:00
Tor Lillqvist
15157f9e67 Mention --enable-cypress
Change-Id: Ic29138650f70c0eaa0d7a60b1b6dd4f4929b6b96
2020-03-20 10:20:23 +02:00
Tamás Zolnai
3b1ca68a21 cypress: mobile: add spellchecking tests for impress.
Change-Id: I7b3909c79ca1fad27c5e3754a36f38f659e467e1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90712
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 14:48:42 +01:00
Tamás Zolnai
ff92eb0795 cypress: better core version detection.
To make it work both with release and debug core
build.
Also disable some tests failing with core/cp-6-2.

Change-Id: I5617712e19dc8aaba0c5f9fbdf9c17d9a19fb18b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90725
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 13:47:55 +01:00
Tamás Zolnai
45886322e7 cypress: mobile: move focus related tests to focus_spec.js.
Change-Id: Ib8719f6d14e578ffc0125077942c063f4b5f3f37
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90718
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 12:32:52 +01:00
Tamás Zolnai
6e96d4f6df cypress: catch "Uncaught TypeError" error in the log.
During parallel build.

Change-Id: I18d78250650e5d16ff9a4ff8588a2e955a934f44
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90721
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 12:30:54 +01:00
Tamás Zolnai
c1b56a357c cypress: mobile: don't wait too long during long press.
In some use cases this time was too long and hammerjs
recognized a pan end by 'pointerup' event. We have
500 ms time set for long press in loleaflet code,
so use the exact value here.

Change-Id: Iab47c668ffa591ccfd7d2eeed10f2c3ec5664b89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90723
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 12:20:03 +01:00
Tamás Zolnai
3418701ecc Revert "cypress: calc assert we are in text edit mode in focus test"
There is no assertInTextEditMode() in calc_helper.js.

This reverts commit bc5bf2eb2a.

Change-Id: I97526eb8ea0297a2ea28080f09c85e4284d70932
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90719
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-19 12:01:18 +01:00
Tamás Zolnai
407f830f50 cypress: mobile: add also an indicator to enableEditingMobile.
Which indicates that the application stepped into edit mode.

Change-Id: I196851c618fd3b6c670b26184e6bbca8050f2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90711
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-18 20:45:36 +01:00
Tamás Zolnai
fdbca4dcf1 cypress: mobile: restore original selectAllMobile() in writer_helper.js.
Using CTRL+A is simpler, but with using the Hamburger menu we can
make sure that menu item is working. CTRL+A is not an actual
feature on mobile. Also it's good that we use hamburger menu, so
we can check interaction of hamburger menu and other wizards
using the same bottom panel.

Change-Id: I640e515070046ad18b00be69509ed895844962a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90710
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-18 20:44:48 +01:00
Pedro Pinto Silva
a28a759212 Mobile: Writer: Insert: Add missing icons to Formatting marks submenu
Change-Id: Ieadca0bdb5668d0bdc8ee9356879b652b540ab3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90659
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-18 15:35:48 +01:00
Ashod Nakashian
6e70407ba1 cypress: reuse select-all helper
Change-Id: I96a695dd96c07ab977ea0814117c642923e2f4db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90648
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-18 10:14:53 +01:00
Ashod Nakashian
4ff5406701 cypress: reuse helper to enable editing in tests
Change-Id: I9565376bf3e34c2d95a14a5411cee732a77f9f0a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90647
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-18 10:14:31 +01:00
Ashod Nakashian
3bafa7d4ab leaflet: maintain the keyboard state after toolbar actions
Previously we supressed the keyboard after toolbar
actions, but that is problematic because then the
user is unable to delete/replace selected text,
because the keyboard is hidden and there is no way
of showing keyboard without changing the selection.

Now we maintain the keyboard state, which is likely
visible, since a selection shows the keyboard.

This might not be ideal, because the user might
hide the keyboard on the device and we will restore
it after invoking a toolbar action, but at least
it's more usable now. Unfortunately, there is no
API to track the keyboard visibility.

New Cypress tests added to validate the above.

The tests depend on checking the last keyboard
visibility state in Map, because there is no
reliable (or any?) way to know whether the keyboard
is visible or not. There are many cases where we
actually hide the keyboard, while having the input
focus on the textarea element, so that is no indication
that the keyboard is visible. We do this for usability
purposes. For example, during zooming, when selecting
cells and graphics/shapes, etc.

The purpose of the cell is to validate that we restored
the keyboard visibility or we changed it, depending
on which is expected after each operation.

Change-Id: If0f2e96909ff20753043734789397d190cedb502
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90663
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-18 07:30:08 +01:00
Ashod Nakashian
bc5bf2eb2a cypress: calc assert we are in text edit mode in focus test
Change-Id: I21471d14d4bc44b20d252757c3bbb770e069bc81
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90649
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-18 04:56:01 +01:00
Ashod Nakashian
b2ec95dcfd cypress: new impress editing tests
Single- and double-click starts editing
text-boxes in Impress. Single-clicking works
only on text, not in the white-space.

Merges an existing test with a new one to
minimize redundancy where there is overlap.

Improved helpers to minimize duplication
and update a single place when there are changes
to the common operations/checks.

ESLint version set to 6 to support the inline
closure syntax that 5 doesn't support. This is
only used for tests, so perhaps we should have
a different ESLint config for leaflet to avoid
breaking IE11, which is pre-6.

Change-Id: I14ee65b18e310f4ff6b93ce81580b3d6aba0fa03
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90360
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-17 22:53:11 +01:00