Commit graph

31 commits

Author SHA1 Message Date
Pedro Pinto Silva
bef32043d6 CSS lint: add more rules and fix problems
- Fix duplicated properties (ignore cases where it's needed
for browser compatibility);
- Fix space inconsistencies before !
- Fix space inconsistencies after colon
- Fix space inconsistencies after and before combinator (>, +, ~)
- Invalid calc
- Many rules added to json, namely no-extra-semicolons

Change-Id: I78af6bc546aeb1d7d7090e2ef278c895f0393a07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-09 11:48:31 +02:00
Jan Holesovsky
b934b84ba0 mobile: Move the toolbar-related pieces.
Change-Id: I3cedfbdb6641d3e58f8faf16846cc25beb36e768
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91481
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-04-02 09:07:04 +02:00
Pedro Pinto Silva
8255828819 Mobile: Fix header-left alignments on mobilewizard and fix document container vertical(readonly and edit mode) position
to respect the height of toolbar-up as well as the main-nav element; Set 0 vertical paddings for the toolbar-up.

Change-Id: I4951b47a5c8b4fb34285c45b2ef9765245068b4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90253
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-12 13:31:54 +01:00
Pedro Pinto Silva
ade9bcb454 mobileWizard: context actions were not aligned in some browsers
Change-Id: Ibea92fcce449eea9651e6d84e44e47924b116f2e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89544
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-27 16:04:51 +01:00
Pedro Pinto Silva
c8b355bf1b Mobile: Toolbar-up: make sure that there is no background being applied to any icon on checked status
Change-Id: I1f419d485cefa387c35a9c42c9ac6671df909434
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89639
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-27 15:55:32 +01:00
Tor Lillqvist
dd70a89a60 Revert the changes that removed the menu bar on iPad in the iOS app
Change-Id: Ic374514bfdde4682f88b507eca82cf88df36bc9a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89329
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 12:19:27 +01:00
Tamás Zolnai
542b4b69d6 css-media: Remove 'screen' condition with invalid syntax.
It should be 'screen and ...', but since the other rules don't have
this additional screen condition, I just remove it.

Change-Id: Idabf28fbee303e19f1a5f5c75f3eb5e7387ac3fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89170
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-21 11:27:32 +01:00
Pedro Pinto Silva
116e3f74c7 Mobile: Toolbar up: Fix dark border when long press on any item and add hamburger press state
Change-Id: Ic2472ffd8e03463f56d7850d05d3ef5564093202
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89004
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-19 13:26:08 +01:00
Tamás Zolnai
364623c87f mobile: Fix css media rules to work with mobile emulation / cypress test.
Restore the media rules we used earlier for mobiles.
So for mobiles it's enough to have a small screen size,
for tablet we allow bigger screen size, but only with
special pointer properties.

Change-Id: Ic45f05c516ec44cd39c58463d8bf1907ec63c25a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88922
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 14:31:00 +01:00
Tamás Zolnai
1999f12b35 Revert "Revert "Mobile: change all media queries to:""
This reverts commit 55d067bfee.

Change-Id: I2077276e70e16324031b393a58bf802c3efdcb4f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88921
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 14:30:42 +01:00
Tamás Zolnai
55d067bfee Revert "Mobile: change all media queries to:"
This reverts commit ef48e44c0e.
2020-02-18 09:19:34 +01:00
Pedro Pinto Silva
ef48e44c0e Mobile: change all media queries to:
- Include phablet size
- Ensure that the mobile css rules do not kick in when on Desktop (900px window)
-- Detect if the primary input mechanism cannot hover at all or cannot conveniently hover (hover:none)
-- Detect if at least one input mechanism includes a pointing device of limited accuracy (any-pointer:coarse)

Change-Id: Idf1494acbd52ecd40e9082c8cf6f4ce88ecf9ac6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88862
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-17 15:53:33 +01:00
Pedro Pinto Silva
c92682c813 Mobile: Scroll indicators (shows the user he can swipe to see more):
- Use shadow instead of background gradient in order to have more granular control over the result (multiple shadows)
- [Toolbar]: decrease indicators width to 0; [MobileWizard]: decrease indicators height to 0
  - ^ to avoid mistaps. We now have larger "gradients" with 0 space from the element which allows any elmente that is underneath to be tappable

Change-Id: Ie329ed4e85d7342ab9cdc90f89cfdc8663e73da7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86979
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-17 14:05:25 +01:00
Pedro Pinto Silva
84ef6bd6fb Mobile: toolbar-down: scroll/swipe indicator: increasing width
also related to: https://gerrit.libreoffice.org/#/c/online/+/86691/

Change-Id: I85f0500927164cfeab756c1588e3f5e97644b866
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86702
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-13 17:31:34 +01:00
Pedro Pinto Silva
839cab9b65 Increased the horizontal scroll indicator contrast,
- which increases legibility even when there is a checked element underneath
- also decreases its width so the element that is partially under is still interactive without the need to swipe it first

Change-Id: I54fe3e3d0bd699246f76c77e929b3c4a250e0b82
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86691
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-13 15:11:00 +01:00
Pedro Pinto Silva
a4b146ec51 Mobile: w2ui scroll elements:
- Enable and adjust elements when on mobile so they are visible but discreet (without covering icons)
- Make them not clickable when on mobile (thus avoiding unwanted scrolled due to users mistaps
- Make their parent aware of the ongoing scrolling and call w2ui resize on it (thus making the left and right indicator showing and hiding as we please)
- Test and adjust so this changes do affect affect the click listening on desktop etc

Change-Id: Ic35dadb71e7fd6ae3ff2fad3e52d5219e7520c55
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86364
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-07 17:36:21 +01:00
Pedro Pinto Silva
33af2f483d Fix Insert Shape Palette scrolling issues
Change-Id: I98c141edbe88a74cf14453972494f29882aed23e
Reviewed-on: https://gerrit.libreoffice.org/84748
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-12-09 14:43:33 +01:00
Pedro Pinto Silva
adc46c7ab1 Mobile: Toolbar-up: checked state: Add webkit-only rule to fix weird behavior on some webkit browsers
Change-Id: Ia29bce6ab4e26c63d7f3bf25bb3750d680e7c022
Reviewed-on: https://gerrit.libreoffice.org/84607
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-12-06 11:03:03 +01:00
Marco Cecchetti
b7743930cd loleaflet: calc formula bar tunneling
Change-Id: I1e9de5eee5ce8992f37cdee4928476954b84b299
2019-11-25 21:57:16 +01:00
Pedro Pinto Silva
0a994724f5 Mobile: toolbar-down: horizontal scroll
- hide scroll elements (left, right)
- make it scrollable
- hide scrollbar (webkit, firefox, ie)
- tested on real devices (do not report/test based on desktop responsive mode. it's dubious)

Change-Id: I1dc509b36d4d16c3872561e8301d76ae708a286b
Reviewed-on: https://gerrit.libreoffice.org/82496
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-12 11:40:37 +01:00
Pedro Pinto Silva
1a0cee97b5 - Spreadsheet: Move rules for mobile to spreadsheet-mobile.css
- Remove duplicated selectors regarding toolbar-down (toolbar-mobile.css)
- Add max-height for toolbar-down (toolbar.css)

Change-Id: I41cbd09620d212916338aedbae1936a5d924a520
Reviewed-on: https://gerrit.libreoffice.org/82435
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-11 13:43:43 +01:00
Pedro Pinto Silva
814f4e91f5 CSS Files Clean-up: moving rules targeting mobile to specific mobile css files
- mobilewizard rules both from toolbar.css and toolbar-mobile.css to mobilewizard.css
- Hamburger menu rules from menubar.css to menubar-mobile.css
- scrollbar rules from toolbar-mobile.css to scrollBar.css and add media query
- and remove unecessary comments

Change-Id: I5372455ba723d334472b14df556825b1a3734922
Reviewed-on: https://gerrit.libreoffice.org/82298
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-08 14:50:41 +01:00
Pedro Pinto Silva
3dc6dd3e50 mobilewizard: spinfields:
- hide number of lines icon
- edge case: adjust width of various spinfields to account for inexistent units

Change-Id: Id8bee7731ee888821d95c3f8c423bcca53866d64
Reviewed-on: https://gerrit.libreoffice.org/82268
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-08 10:15:10 +01:00
Pedro Pinto Silva
526056f630 Fix search on mobile (including in the meadia query)
Change-Id: I4384bc1c29b5081ed5c1b40bad68567c208aa574
Reviewed-on: https://gerrit.libreoffice.org/82080
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:30:00 +01:00
Pedro Pinto Silva
ee6700463a Spreadsheet: spreadsheet-toolbar: add proper press states on mobile and disable desktop over states when on mobile
Change-Id: Id768d33e7267a17b25664a880333195fe28ce0ba
Reviewed-on: https://gerrit.libreoffice.org/82033
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:19:57 +01:00
Pedro Pinto Silva
a19f2faf2f mobile: toolbar-search:
- replace free text "Search:" with a proper label element
- give class to input group parent
- style search toolbar
- change font size to 16px so to avoid auto zooms from iOS devices

Change-Id: Iccbae8f7a932786acfde936e2002bd36b1fc564b
Reviewed-on: https://gerrit.libreoffice.org/81883
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 13:57:34 +01:00
Pedro Pinto Silva
49bb017e5a mobileWizard: toolbar-down: overlay
- improve w2ui-tb-down interaction and change its appearance depending on its status
- Fix w2ui-overlay-editbar -> menu where two triangles were being drawn instead of just one
- Fix w2ui-overlay-editbar -> Apply the same border and shadow etc properties used in the color picker overlay

Change-Id: Ic90844613eae126b5efdb7da8930d4007639850f
Reviewed-on: https://gerrit.libreoffice.org/81855
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-04 18:07:01 +01:00
Pedro
5c312db13d mobileWizard: image: add icons and fix position settings
Change-Id: Iffd3e491a0444118da29315d847a00267873232f
Reviewed-on: https://gerrit.libreoffice.org/81781
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31 11:52:27 +01:00
Pedro
43249febef Toolbar-down: space-out icons and restyle dividers for mobile
Change-Id: I927f1ae0e2cd10985c8b5a5720b3a967eefcde22
Reviewed-on: https://gerrit.libreoffice.org/81692
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29 19:43:42 +01:00
Pedro
23e71b56ac Fix how formula input looks on Firefox and Firefox mobile
Change-Id: Idb362dde1872f2ed934f67d349eb1693c6c9c074
Reviewed-on: https://gerrit.libreoffice.org/81257
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-22 14:04:24 +02:00
Szymon Kłos
91d281bf0b Split css files - added empty files
Change-Id: I67863622d37e350e8a5eafa4cd5f65ec4a2baed3
2019-10-16 12:38:04 +02:00