Commit graph

21809 commits

Author SHA1 Message Date
Caolán McNamara
6f984b042a don't check for SIMD in mobile case
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib4ec551bd3c3c662c0e39aa0df292920c7afac08
2023-09-25 16:55:04 +01:00
Caolán McNamara
77d1424b8d rleMask->rleMaskBlock in non-simd branch
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I09d0c900535eba6b274e294ff39ea71a9d9c323f
2023-09-25 16:55:04 +01:00
Caolán McNamara
aa59f57285 add Simd.cpp to android CMakeLists
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I577bbe203a940e1d2f38fa4d1f86cc6d8f8d1f33
2023-09-25 16:55:04 +01:00
Michael Meeks
fde98db394 Factor out CPU RLE into a function with similar signature.
Performance testing suggests that:
 + dense text this is 2x faster.
 + 'hello world' text this is 1.7x faster.

Change-Id: I4ff940663c44d0b22c9187deb4ee397a9d9953b0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
8f2c7f4de7 Add idea to save an instruction by masking at the same time ...
Change-Id: I9ecd35c1655bd72994a297b8897db473a921bc20
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
2e1e0c1260 Save another variable and rename.
Change-Id: I279df2615f972acd3f8107b236d67232c3d6015f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
81a8bb4589 Switch to a single loop to reduce branching.
Simply calculate our loop variables from the iteration we're on.

Change-Id: I0bb73302fb09963b2a1f5b3d93ef302316ef1d4f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
ad768d2337 Handle only 256 pixel runs, to drop another variable.
Change-Id: I5e28b4f86ae191b181a69b82511d3393b5fc8c20
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
0153ddb554 First cut at getting aligned loads and simpler loop structure.
Remove the special case for the first pixel, and instead have a
previous pixel run initialized to zero.

AVX2 has no effective shift for the while si256 so use permutation
to shift the last pixel of the previous run into the right place,
mask it and combine.

Saves a second un-aligned load of the same data, and branch.

Change-Id: I77c9cdead13d37aaf4d9f31d98cbd5c4a9c5ce24
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
743fa7d91f Use a LUT and SIMD packing logic to accelerate RLE pixel copy.
Change-Id: I6874f1b33acf6f0f3c72c86f9fbe232e1f5a560a
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Caolán McNamara
42e98bb2e4 experimentally bootstrap something using avx2 to generate bitmap
just enough to get the same results as before

https://github.com/CollaboraOnline/online/issues/7165

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I109c9b8f1e7935782c72e0179aa0ed48712eadb6
2023-09-25 16:55:04 +01:00
Michael Meeks
6d6425336d SIMD - first cut at building LUT for vpermd gather.
Change-Id: I6ae13be0a36b4e30b3d535029313d8402da7de1d
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Michael Meeks
cce3767ba8 First cut SIMD wrappers / separation to accelerate RLE code.
Split it out as a C file, to avoid accidental C++ header inclusion,
and C is a cross-platform assembler anyway so a good match.

Change-Id: I6c042781713aecaf143b9663af8377659a7deaf1
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-09-25 16:55:04 +01:00
Szymon Kłos
1d6d3806b7 cypress: autofilter: test autofilter on mobile
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I63f05af3f618f150bf6550b03a25ff83dfa9d3b4
2023-09-25 16:41:11 +02:00
Szymon Kłos
5acab9c966 autofilter: don't show hidden popup
Autofilter dropdown has submenus which are created at the same
time as main menu. These submenus are hidden but send jsdialog
message with "popup" type. We ignored that message on desktop
so do the same for mobile to not show them instead of main dropdown.

Added also warning about unhandled messages.

Removed old style "autofilter" type handling which is not used anymore.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I18d0c9078b88d6d24290e44179594a8eebd1c2e4
2023-09-25 16:41:11 +02:00
Darshan-upadhyay1110
507c272c80 Mobile: buttons with text color discrepancies
Will not create `<u>` element for mobile wizard
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Iaca88ac4be2c95dc4781180019ba8fede9cdc81a
2023-09-25 20:08:17 +05:30
Rash419
9b5b8c85c5 don't reload the tab if reconnected by indirect socket
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia75d085d17c49a64e56f0dc5c9494fd88d846bfa
2023-09-25 07:07:33 -04:00
Ashod Nakashian
2bf9665d45 wsd: test: enable experimental features in tests
Change-Id: Idc5b838d241e734af8b404dbf2052a69b376540d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
4407ac9136 wsd: test: improved single-test runner
The test now runs as many times as requested
and doesn't stop on first failure. Instead,
it reports the number of passing vs failing
runs.

Also simplifies the detection of the test
result by using the exit code instead
of grepping the output file.

Change-Id: Ie458b2963411632d566cd87d2dfb9137044d2b4b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
48918f9b3b wsd: test: fix typo in test name
Change-Id: Ifbc0c8dd6609fc55e86867c44e0e3ef62fb592f7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
3a91ff3e4e wsd: test: exit on failure to load unit-test lib
We now exit immediately with error code when
we are given --unitlib argument but fail to
load the given library.

Change-Id: I4eb5f3a37b9838ecf83bdceef4d09f888afcca83
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
d7a56a2747 wsd: test: exclude readonly sessions from modification indication
New unit-test that reproduces the corner-case
with disconnection. With graceful unloading
a previous unit-test verified that it worked
as expected.

This is restored from e6798e9062
after it was reverted (due to a PDF comment saving regression).
Since the issue is fixed separately in
0b27e85fc5, these tests can
now be restored.

Change-Id: Id84cda4f4599c559018247c32ea1205e154e4984
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
3bbb1761cb wsd: test: improvements to unit-load test
This disables the unreliable reload test.

On a slow box, sometimes the load takes
a little longer than 5 seconds. Waiting
a bit longer doesn't hurt in these cases.

Also, remove duplicate test and give each
test case its own testname.

Change-Id: I556f6da9e49a7fa4cd9917bc9964dd9561b93817
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
ee41b51cfc wsd: test: new UnitWOPI Overload test
This test is currently disabled, as it is only
useful for stress-testing

Change-Id: I803d8d5818f004afa72bbf2dfe5c9d90b41e1133
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
24264d6d9c wsd: test: better OwnerTermination Test
Change-Id: Iab417f7209c325ec363b5e7bc8648c610b9e32bf
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
968ab3e529 wsd: test: move File-Serve whitebox tests to own file
Change-Id: I4e659f28636cc78beca3c05ed7f23ef714d32063
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
d011656aa0 wsd: test: correct usage of string::find
Change-Id: I3768f74548e69cd8b14c352e7adf67ac210a34c1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Ashod Nakashian
fc6380c31a wsd: test: better UnitWopiLockReadOnly
Fixes a race-condition due to having multiple
views, we will get multiple onDocumentModified.

Change-Id: I806a3cc31f768c9f159e599c69fd1d31755e6cd1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-25 08:58:39 +02:00
Darshan-upadhyay1110
1f094a7b9d View tab for all other apps in mobile
- Added view option to all other apps on mobile view.
 - previously only text contains the view option in mobile view. ( click on hamburger menu)
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I04e06e346d398d947e637bd71e4134bc3e901c4d
2023-09-25 08:54:36 +02:00
Szymon Kłos
81c033df93 Fix UnitBadDocLoad test after repair dialog is enabled
commit	413e7a2e6f0c363938a0a5ee5bd6eb5d56d5a8d8
lok: add broken package interaction handler
https://cgit.freedesktop.org/libreoffice/core/commit/?h=distro/collabora/co-23.05&id=413e7a2e6f0c363938a0a5ee5bd6eb5d56d5a8d8

in core added dialog which asks user if file should be repaired.
This requires tests adjustment.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4e7f9de8b05dc8077447832e59b4e23ec02ccf4c
2023-09-24 20:18:01 -04:00
Cosmin Humeniuc
2b53099b2d Translated using Weblate (Romanian)
Currently translated at 30.4% (158 of 519 strings)

Co-authored-by: Cosmin Humeniuc <cosmin.humeniuc@1and1.ro>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ro/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie7f9626344564b0cbbc84f71d81ab8a7f993d389
2023-09-24 16:38:05 +02:00
Jérôme Herbinet
c724225429 Translated using Weblate (French)
Currently translated at 98.2% (510 of 519 strings)

Co-authored-by: Jérôme Herbinet <j.herbinet@protonmail.ch>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2e3d710bc7da514885c0168eb73ab2dc3c90ccf4
2023-09-24 16:38:05 +02:00
Ettore Atalan
d889e75b33 Translated using Weblate (German)
Currently translated at 99.5% (465 of 467 strings)

Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/de/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I00fa8b82f1d10a2633fe13bf04b08b2901094530
2023-09-24 16:38:05 +02:00
Sebastiaan Veld
04ea467290 Translated using Weblate (Dutch)
Currently translated at 100.0% (22 of 22 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/nl/
Translation: Collabora Online/Android lib
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic2691bfbe3f30a3acaa8dd8b0c945562f1e1778d
2023-09-24 16:38:05 +02:00
Skyler Grey
1b3218df04 Add cli option to use settings from env variables
Currently [in docker it is possible to do configuration through
environment variables](https://col.la/dockercodeconfigviaenv), which
works using the start-collabora-online.sh start-collabora-online.pl
scripts. This commit lets COOLWSD listen to the same environment
variables directly

Change-Id: I75762ad620132037523fa82167a3ff17075c7027
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-09-23 12:44:50 +02:00
Skyler Grey
d94dbf8c32 Option to stop coolwsd when configuration files change
- This patch only adds an option to enable this feature. It is off by
  default
- This allows you to, say, have a docker container and --restart=always
  to restart when you update the config
- This patch only listens for "/etc/coolwsd/", so if you specify a config
  file that isn't there then you're out of luck... An improvement for a
  followup patch will be make it listen to wherever your config files
  actually are
- The current docker scripts only listen for modifications, so this
  matches that behavior

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I674756b0188893f5d192885bb436256aa827e7b5
2023-09-23 12:42:21 +02:00
Miklos Vajna
fb5aab4693 scripts: add a simple script to invoke a single unit test
And also allow automatic re-trying to decide if this is a reproducible
failure or an unstable test.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I254d83cc1acc6b80ec3978e26e5fd64e676ff2a9
2023-09-22 16:01:52 +02:00
Ashod Nakashian
0b27e85fc5 wsd: comments can be added to PDF files which otherwise are readonly
This fixes a regression where PDF comments were lost when
the document closed immediately after adding a comment.

Change-Id: Iac78ec13fdbaa7d1ffe25067ea0f41704abb3312
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-09-21 08:23:36 +02:00
Andras Timar
17c77bf059 Revert "wsd: exclude readonly sessions from modification indication"
This reverts commit e6798e9062.
Reason: this commit caused a regression. PDF comments were not saved.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I180ecb9e298e37bd5a989a8cd6d23d02c25a6929
2023-09-20 19:57:01 +02:00
Pedro Pinto Silva
ffe501a114 Tabbed view: File tab: Save icon doesn't change on modified status
- Add or remove additional css class to the Tabbed view > File Tab >
Save button whenever the document is modified or saved.
- NotebookbarBuilder: onCommandStateChanged: Re-use existing state var
There seems to be no need to call again the object and its state when
we already have a variable for that.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3d0bee8903f4e7309d5d5e7389a824bf39e72651
2023-09-20 19:54:56 +02:00
Gökay Şatır
5039aa4797 Fix "modified state notifier" visibility.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If4feb0806ce92fadeb90f6676809bcbefc51eb24
2023-09-20 19:54:56 +02:00
Gökay Şatır
2a32970c9b Update packages.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I554d2d272b5fb869027088d4a0b2d8284edc4c7c
2023-09-20 19:23:30 +02:00
Andras Timar
5d98af34f5 Update UNO command translations
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia87bc96cca29edd8a362b4856f3eebb588a04a06
2023-09-19 22:06:55 +02:00
Andras Timar
0040ce2882 Bump version to 23.05.4.2
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic4709d3fa68e84262a3ab72faeb175159fb058e6
2023-09-19 21:57:02 +02:00
Theo
673dcffb7e Translated using Weblate (Greek)
Currently translated at 77.6% (403 of 519 strings)

Co-authored-by: Theo <tbousiou@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/el/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9bdd6b5cdf12b373f49d5dd794ea5b43a3dc7bdd
2023-09-19 21:57:02 +02:00
Pedro Pinto Silva
12149fdbd2 Translated using Weblate (German)
Currently translated at 99.2% (515 of 519 strings)

Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7bff182aa7146b87bc3c71776b95655ba0518d2e
2023-09-19 21:57:02 +02:00
Pedro Pinto Silva
c23d93357a Featurelock dialog (upsell): Fix layout and styles
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I18fc9d9b97a64be426d03744a5b707729447a1db
2023-09-19 21:56:52 +02:00
Pedro Pinto Silva
4802992cbe Featurelock dialog (upsell): Remove dialog header
This is **not** nonmodal dialog but it looks like. This is a modal:
user can’t interact with background content.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9e68afadca3d6ab04311f18d38a9dd43b9679522
2023-09-19 21:56:52 +02:00
Marco Cecchetti
97aec60766 Firefox 117 no copy event is emitted by hitting CTRL+C with no selection
The problem affects no-a11y case since the editable area is empty.
Since no copy/cut event is emitted, Clipboard.copy/cut is never
invoked. So we need to emit it manually.
To be honest it seems a Firefox bug. We need to check if they fix it
in later version.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I036414b5ffb5b35ff1ef1d7de1044e890832c673
2023-09-19 19:16:43 +02:00
Gökay Şatır
e309e0ffee Update packages.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I4d90323dade99f325a9c3b6d46fd3b595030d1ce
2023-09-19 14:21:06 +02:00