to filter tile-invalidation messages, so that the client gets
invalidations/new tiles for all split panes.
Change-Id: Ifacc452ed6bb43dfd36ff16386fb4a547ec8302b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98362
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and take split-panes into account when switching views on the arrival
of a new cursor message.
Change-Id: If97b06ceefd15335555d77b4074fd6991e21b7ab
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98358
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
For this to work, we need sheet-geometry data. GapTickMap is dropped
with a replacement HeaderInfo class that is easier/less confusing to
work with split-panes. All indices in HeaderInfo are 0-based and a
column/row is referred to as an 'element' when things have to be
generic.
Change-Id: Ibddac8901d48cada554b715af70195ef9b9832e2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98357
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
This method waits until the item is idle,
e.g. not detached for a while. Using this we can
workaround false failures caused by GUI flickering.
For example, mobile wizard is updated all the time
which makes hard to test it reliably. We can use
this clickOnIdle() method, which is slower than the
simple click(), but is more reliable.
Change-Id: I2f970eb0cf400382c8384c91ab7c84b1e02e63af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98373
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(This is only for svg renderer)
There are separate svg DOM-nodes for each split-pane with view-box set
appropriately. The L.Path based objects are shared for each
split-pane, but there will be separate identical 'path' DOM-nodes for
each svg container.
This patch introduces L.SplitPanesRenderer/L.SplitPanesSVG (has
same external api as L.Renderer/L.SVG). These are wrapper classes to host
child renderers, one per split-pane and delegate calls to them
appropriately.
Change-Id: Id44e9a1312500e6b43cdd8e4f42e235b43d22772
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98354
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
converting to/from container coordinates. Also introduce the
corresponding 'IgnoreSplits' versions of changed methods because they
are needed for repositioning the map-view which is independent of the splits
position. They are also needed for stuff outside the map which need not
be aware of the splits.
Change-Id: I9044a185e5762fa4c4866590e1b7cf456fb2d1dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98352
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
which is derived from TileLayer but renders tiles on a canvas instead.
TODO: Generalize certain methods of TileLayer instead of a complete
re-implementation in CanvasTileLayer just because a few things need to
change.
Change-Id: I51001f83f8f663d194bc9c4b018fa9950c40f420
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98351
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
This will store the split position and notify others and update the
splitters when someone changes this.
Change-Id: Ic1a2d665c972c369ce4e1362d0add50f72125d8a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98350
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
which is the behaviour in LibreOffice Calc desktop. This is now possible
because we can accurarately determine the pixel position of any cell at
any zoom level from the global sheetGeometry data we get from core.
Change-Id: I5af41770e94c65d803fa9f99906b4ee1ca2f6ac7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98328
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Pointless since my own 7f25109f72, so
yeah, I should have noticed then.
Change-Id: Ic34584134ef840b33b874952e0bba8d14d3fde2f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98374
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
After jquery libraries update some nodes
were not hidden. Using animation fixes the issue.
Also hide effects helper container which added
empty gaps between entries.
Change-Id: I36090a48d60401c9e6de4711601f357367239a19
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98327
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
When tests are run in parallel, they will all
compete to update and set up the systemplate
directory, which has a handful of files that
need to be up-to-date. This is a source of errors.
Normally, these files are linked (hard- or soft-
link, whichever succeeds). With linking, we
only need to worry about the initial setup,
as the files will never be out-of-date from
then on. However, when linking fails, we need
to copy the files, and update them (by copying
over fresh versions of the files, if necessary)
every time a new kit is forked. Copying over
is tricky, as it's not atomic. To make it
atomic, we copy the files to the destination
directory under a temporary (random) name,
and then rename to the final name (which is
atomic, including replacing the target file,
if it exists).
No such race exists in production, where there
is (or should be) but one instance of loolwsd
(which does the initial setup) and forkit
(which updates systemplate before forking
new kit instances).
This is an issue with parallel tests only.
Change-Id: I6ba1514d00a84da7397d28efeb6378619711d52f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97785
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Since we are manually changing the CSS class names when
orientation changes, this is only valid for main custom scrollbar
because the mobile wizard scrollbar is always in portrait mode.
Change-Id: I0b9e7156dac0e33a6e793c7f6caae2021068f252
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97900
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The preview thumbnail in mobile wizard are not visible yet,
so assume the map container rectangle bounds to properly
calculate the aspect ratio of the image
Change-Id: Iacc387b92e326965c86fb60d1acfde5b49365ad3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97899
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
We are manually changing the orientation CSS class name for
preview thumbnails, so it requires to destroy and create again
the custom scroll with the new axis to show a vertical or
horizontal scroll bar
Change-Id: Ib341025da66db05f6feddbbb32a286da107cd8df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97898
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
This prevents an assertion failure when you quickly open the same
document again after closing it.
Change-Id: I26b8c53d57bd1d33f0473a3c5a332ec02c37455d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98263
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
The unit test checks the aspect ratio of the preview thumbnails,
this happens when the document size changes (i.e changing paper format)
Change-Id: I0267e797327b73d714947258e004fe64cce9d1dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97775
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
When copy is disabled don't put stub message about
download button in the clipboard.
Allow internal copy & paste when copy is disabled
- so disable only external interaction.
Change-Id: Ie7864abc8a239aa068880545cf09a48155ebbaea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98237
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
In some browsers with strange settings localStorage is
not available.
Change-Id: If9e5ebeb9701cc0a2b19c5946bcbc23f76a8c577
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98238
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
the cell-area selection. Improbable, but can happen in a cypress test.
Change-Id: I112ef88d11818c6e0abc91a8de37c329666dcdbc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98216
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I8a834fef08685d0ee713f64abed1696e56987241
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98158
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
All graphic-selection messages from core are in print-twips if
sc_print_twips_msgs is set in SAL_LOK_OPTIONS. So do all the necessary
conversions on intercepting the message.
In addition, in this mode the core expects the parameters of the command
'.uno:TransformDialog' to be in print-twips. This is also done in this
patch.
Change-Id: Ief8a0d4677f83f26b135ce47b68c27bff5aaf5c9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98157
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
own: invalidatecursor, textselectionstart, textselectionend
view: invalidateviewcursor
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I7d7cfd62202ac46b3410ad3e08bc04f0e2cdab00
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98156
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and reuse this to parse all rectangles in text-selection (own/view) message.
Change-Id: Ic6946b2f10d9f642232d540b5974d53edbb774d7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98153
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Print twips coordinates for chart/draw edit-cursor is not there yet in
core (needs more work).
Change-Id: If8cd9431fa43351340c74e989ee837f4b1b859dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98152
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
until we have a better solution. It messes up the positioning of headers
w.r.t the map at certain zooms.
Change-Id: I32422a5f5076f83631f28a90db6a543e830ccf0e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98150
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
