strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6849 commits 1 branch 0 tags 244 MiB
Commit graph

21 commits

Author SHA1 Message Date
Tor Lillqvist
57326ae27c Third parameter to prefix() is a bool 
Passing syscall(SYS_gettid) as a bool is equivalent to passing true,
as far as I understand.

Change-Id: I31bb15000a9e6c95b657d58bc78df4f3da0fe687
 2018-08-29 18:36:16 +03:00
Miklos Vajna
9ed7c1065c common, kit, test, wsd: these parameters are copied for each invocation ... 
... but passing by const ref is enough
 2018-08-13 09:26:15 +02:00
Tor Lillqvist
0c425c82d3 Be consistent, no space before the '|' in LOG_BODY() 
Change-Id: Iecab73efcb19562c5a7ebee506f13668b1a827c3
 2018-07-13 17:51:21 +03:00
Tor Lillqvist
b4192de6fa Output '|' before the source file name in LOG_END(), too, like in LOG_BODY() 
Change-Id: I57d825d03321992d680670f3560e951bc0cb2005
 2018-07-13 17:49:21 +03:00
Tor Lillqvist
3b4269a301 Use Util::symbolicErrno() 
I think the general policy should be to always log errno using both
Util::symbolicErrno() and std::strerror(), never log a naked errno.
But only in cases where we know that it is highly likely that it is
the most recent system call that has failed, so errno makes sense.

Change-Id: I4a1fb31e375ea949e7da17687464361efe7c1761
 2018-07-11 13:05:22 +03:00
Ashod Nakashian
7be98efd93 ut: log timestamp to track timeouts better 
And improve the logging support in unit-tests to
help troubleshoot issues faster and more accurately.
Also makes the code more readable (hopefully).

Change-Id: I4f8aafb5245e2f774b03231591a74544f9ec84aa
Reviewed-on: https://gerrit.libreoffice.org/48645
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-02-11 19:21:15 +01:00
Ashod Nakashian
c06376cc1d wsd: cleanup logging and remove unused helpers 
Now all logging is done after checking if the
level in question is enabled or not (thanks to
the macros LOG_XXX), which saves unnecessary
conversions and stringification when said level
is disabled.

Change-Id: Icde31e067f60269563896f04f8b0d65643720766
Reviewed-on: https://gerrit.libreoffice.org/47885
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2018-01-19 00:33:40 +01:00
Pranav Kant
db13014e00 Update modifiedTime for local files unconditionally 
Also teach logger to print timestamp object.

Change-Id: Ia13836814c195cef92f5dafd8245c9958600876d
 2017-06-16 19:49:37 +05:30
Michael Meeks
08c70f1315 Signal safe number logging (lame but useful). 
Change-Id: I0b6095fc08dcc237a224b5942ab5a09e6820e43f
 2017-04-28 19:05:45 +01:00
Michael Meeks
ae0dba1088 Cleanup prctl / gettid system-call thrash on logging. 
Makes the strace look much prettier.
 2017-03-30 18:14:40 +01:00
Ashod Nakashian
e9614fc697 wsd: support logging file and line with logger objects 
Change-Id: Ibf82105d91ece29c0a4742c6b2e81f6b179c0be4
Reviewed-on: https://gerrit.libreoffice.org/35081
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-03-11 19:49:09 +00:00
Ashod Nakashian
386dc679a5 wsd: get system thread-id directly as not in Poco yet 
Change-Id: I49ba23b6cd50c2d9058e9803d7f65ec41277297b
Reviewed-on: https://gerrit.libreoffice.org/33890
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-02-03 16:01:52 +00:00
Ashod Nakashian
c22e69e9e6 wsd: correct logging of thread ID in log entries 
Change-Id: I10aaeeea8df2757362482a405b7525542d150178
Reviewed-on: https://gerrit.libreoffice.org/33857
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-02-03 07:05:06 +00:00
Pranav Kant
8c5028de05 fix build for poco 1.7.5 
Change-Id: I9636a7dd63c714bdd375d19af3eec0677c6d47fc
 2017-01-23 13:04:03 +05:30
Ashod Nakashian
ffe092f5ce wsd: log cleanup 
Change-Id: I569f7a81fa80686810c4d5aa65e03b02be189db7
Reviewed-on: https://gerrit.libreoffice.org/33417
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-23 04:34:38 +00:00
Tor Lillqvist
32b92dcd91 Bin default values for parameters that were defaulted at just one call site 
Change-Id: I965b0be1ad4f706a06d06d5c6c3f940c1b3cc33c
 2017-01-16 14:05:10 +02:00
Tor Lillqvist
ae6f0e3df9 Make it possible to use the LOG_* things as statements 
Use the usual do { ... } while (false) idiom. (See
http://stackoverflow.com/questions/4674480/do-whilefalse-pattern for
instance.)

Change-Id: I1fb00c331ab4eab3ebbff1d58a8ed36e59d2646c
 2017-01-04 16:48:16 +02:00
Ashod Nakashian
92bbe0b774 wsd: log bools as text 
Change-Id: I0d520671704881bf1aaeb090ce452be74e43fd0c
Reviewed-on: https://gerrit.libreoffice.org/32561
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-01 04:20:15 +00:00
Ashod Nakashian
9e677e268f wsd: new LOG_CHECK_RET to log failure and return 
This is to replace assertion for non-fatal cases.

Change-Id: I6f8aedea52fb861309d0bc8f8f9cd43395da0805
Reviewed-on: https://gerrit.libreoffice.org/32550
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-01 03:54:51 +00:00
Ashod Nakashian
4bc318fb88 loolwsd: LOG_CHECK to replace assertion when logging suffices 
Change-Id: I077c6394579f432c0aa9da053d20ccb9c6d31907
Reviewed-on: https://gerrit.libreoffice.org/31934
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-12-13 04:37:05 +00:00
Michael Meeks
cca657c8f2 Apply the pre-branch rename script to re-organize the source. 2016-11-25 09:58:48 +00:00
Renamed from loolwsd/Log.hpp (Browse further)