Commit graph

132 commits

Author SHA1 Message Date
Pedro Pinto Silva
6ed9065bb5 Navigator: fix active element style on dark mode
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f7e2d48eedf0f204acefadccb36764f553d65f5
2023-08-28 21:52:51 +02:00
Pedro Pinto Silva
53b94c7f0c Navigator: for now let's not communicate that is possible to drag
Since we have disable the functionality until it works as expected

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a99680d79ffb44a653c32edb25aafded35c7712
2023-06-10 09:02:25 +02:00
Pedro Pinto Silva
45f400c7a5 Dark mode: add select state for buttons
Do not re-use light mode values.
Increase color contrast

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I514d4be5468dd3df50ab5256b64d0a22e659ad97
2023-06-08 14:44:50 +02:00
Pedro Pinto Silva
468ca99820 Navigator: Fix and improve the selected item
- Categories (listview with icon) get highlight but not indicator
  - So it's understandable that they can be dragged
- Categories: change cursor so user understands that they can be grabbed
- All other treeview (even exapandable) get highlight and indicator
  - To help user's orientation

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c275c81503787c60c4527a3cee63be8323686ef
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
09511d5116 Start navigator from the top
This is a follow up on the revert f4f95b2 since the scroll logic depends on the
absolute position

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5659701c2236dc89f764f45008e6e92c47a3f101
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
a0820fa9ca Revert "Navigator: do not resort to absolute position to set deck"
This reverts commit f4f95b27cf.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iff99928855684252cc6b48977940f8ddd827a865
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
9057c705f7 Dark mode toggle: fix flimsy selected state
I have noticed that sometimes the toggle doesn't get assigned with
selected css class. We could just rely on this line and avoid add and
removing css class to the DOM every time the mode changes

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7c19f626d60c761a1ebe2509e7ab7aa8031403ad
2023-06-07 07:57:28 +02:00
Andreas-Kainz
ee5b5d8878 Sidebar writer Paragraph Section BackgroundColor justify-content: end
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I23a5690b0b33dae426914ebef30fae6d97d598c7
2023-06-05 14:42:06 +02:00
Gülşah Köse
07bbf1d38f Fit the images into the sidebar.
Without patch image sizes are 336px and seems cropped in sidebar.
We should use same width with sidebar width.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I617a4e79e15d1d49ca95aec8f5a20f95734160a2
2023-06-05 12:32:41 +02:00
Pedro Pinto Silva
9010d0125e Navigator: Fix alignment to coincide w/sidebar properties expanders
Zeroing margin and padding otherwise we inherit px

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1dedb755b3fb16ac2da6af95b4a0c4d5e5910715
2023-06-02 18:52:31 +02:00
Pedro Pinto Silva
f4f95b27cf Navigator: do not resort to absolute position to set deck
- No element should have border
- Reset max-height otherwise it will inherit 150px

This is a follow up on:
navigator: hide panel title in sidebar 56ca9b6

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I908468f0cb9a494acd7785d76e1882c3a8673de3
2023-06-02 18:52:31 +02:00
Pedro Pinto Silva
25e6b30cf4 Checkbox need to be vertically centered
Specially important when checkbox belongs to a parent that is bigger
Example : Using Calc inside of Alignment section, vertical stacked
checkbox

https://archive.org/download/checkbox-need-vertical-center/checkbox-need-vertical-center.png

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie54611006c5c11c39938e97358e3dfa9891f069f
2023-06-01 10:47:37 +02:00
andreas kainz
35a48c8c34 Sidebar.ParaPropertyPanel css class merged
identfieldbox and box3 use the same css class see #6392

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I7a95fdd8ae3a9bfffbe676917cb412a99cb40818
2023-05-26 11:06:22 +02:00
Pedro Pinto Silva
6b7cb803b2 Fixes: Sidebar icons are cut off
This hard coded width is not needed and was imposing that width value
to #indentfieldbox even if there is other elements present resulting
in the whole container being bigger than the sidebar itself

This issue became more evident with
27fddae9c6 (even
though it's not related to the bug but rather exposed it even more)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I90e684b395b950e4cc25a96a9875d4702016411d
2023-05-25 16:04:27 +02:00
Pedro Pinto Silva
0408fd62c3 Sidebar: Align everything to start and remove unnecessary css
Better to align everything to start so if the components differ in
width they will still be aligned (as opposed to be laid out in a staircase)

This is a follow up from 1bfbdf8072 coming with
the following PR https://github.com/CollaboraOnline/online/pull/6389

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic607567d30656cc122f9cbfd71bd3d910ebfe9bf
2023-05-25 09:09:47 +02:00
Pedro Pinto Silva
fffa61337a Fix menubutton tooltip, pos and style
- Do not appear above color
- Re-use tooltip styles

This fixes https://github.com/CollaboraOnline/online/issues/6293

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf67c23b2263e5eeabc70a7128087333856aa465
2023-05-24 10:29:29 +02:00
andreas kainz
1bfbdf8072 Sidebar calc Alignment fix button size of align icons
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I954c7885946dfd4e13261622673d1b97ef59001c
2023-05-24 09:41:47 +02:00
Szymon Kłos
56ca9b6b2c navigator: hide panel title in sidebar
and move all navigator css rules into one place

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf00bbd25bf111c5817621f4a72ac95aeb307786
2023-05-19 13:55:26 +02:00
Szymon Kłos
888448f597 jsdialog: fix spelling dialog layout
rules from sidebar were applied to dialog

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I18d274d0aaeeeba3ba47d839f82efaa5805eaa28
2023-05-11 21:08:51 +02:00
Szymon Kłos
22371ec0c5 navigator: fix alignment of tree items
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib28be9f4b0a9d00eff6185172979bc68b3b6953b
2023-05-05 14:38:05 +02:00
Pedro Pinto Silva
27fddae9c6 Fix down arrow/triangle position in sidebar dropdown icons
before this commit the triangle was misplaced, under the icon instead
of side by side

(might be related to https://github.com/CollaboraOnline/online/issues/6236)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id8d118471dcb02b5bc79399a4319ee514af03c5b
2023-04-28 16:41:56 +02:00
Pedro Pinto Silva
58bb4b9380 Sidebar: Remove browser's style padding that comes with <button>
Before this commit buttons were being generated with padding
this is not needed ( we already have safe margins applied to
the parent -> 'unotoolbutton' )

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4f1b4328131550d906cde3328c7de02daffd76a1
2023-04-13 09:18:52 +02:00
Pedro Pinto Silva
557c336d0d Set missing dimensions to sidebar button images
- re-use btn-size variable
- make it clear that this set of rules is intended to sidebar elements
  - Improve selector (more clear and so it doesn't target other
    elements outside of the sidebar)
  - Move it to jssidebar.css file

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib03c412a1e05fd6ed315f58a70486f14eaf5b9ea
2023-04-11 16:13:01 +02:00
Pedro Pinto Silva
70a5ec53aa CSS Refactoring: one btn-size to rule them all
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iedac492e206e15a1aad65e07dc8cdc3d95a4a488
2023-04-11 13:01:54 +02:00
Pedro Pinto Silva
311527b22e Set box-sizing for sidebar and notebookbar icons
This makes any resizing or position easier
and it's what is expected from "buttons" (it's the default value)

and those icons are buttons even if the html elment is somehting else

Bottom line: better to account for any border and padding in the values
we specify for width, height, border and padding. This makes sure that
the content box shrinks to adapt to those values.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I39af02f983611bc751e764c26d13d955b7774928
2023-03-23 15:55:51 +01:00
Pedro Pinto Silva
610a62be6d Sidebar: Fix to allow ratio to span across columns
There is an element displayed as a column before ratio
and we then hide it which is fine but, when ratio label
becomes to lengthly (Seitenverhältnis beibehalten) it then
gets cropped due to lack of space.
- Make it span across columns
- Do not align to the end
- Remove left margin from checkbox

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I02ec7a608c0b330a52fa70db3b453fe04fefa805
2023-01-27 12:53:26 +01:00
Pedro Pinto Silva
f051b62e35 Fix checkbutton label vertical alignment and spacing
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib32dfe4f7f2b0f8bb0b22434696143924f4fef17
2023-01-25 12:50:31 +01:00
Pedro Pinto Silva
b33a0c017e Sidebar fix cropped checkbutton label
In some languages (de) some labels were being shifted and ultimately
cropped due to their length. Example: Using German; selecting an image
-> the 'Seitenverhältnis beibehalten' was being cropped

Remove padding for those labels when on the sidebar

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4097268682a1890543c9d2a8107e621ea15335c9
2023-01-25 12:50:31 +01:00
Pedro Pinto Silva
c9a170463d JSSidebar: remove non-effective rules for expanders
These have no effect on the ui-expander-content since they
are set to display: block somewhere else (jsdialogs.css)
plus, (and even testing with flex) this does not seem to improve
or fix anything

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0260f44413ff46f79b9ea6a15e154ee62fb1e53f
2023-01-09 12:43:53 +01:00
Pedro Pinto Silva
ac2db46325 JSSidebar: Align vertically every widget
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If18a47848790bdf1898aab712c8900f46cd6cdbe
2023-01-09 12:40:37 +01:00
Pedro Pinto Silva
81f65509a2 JSSidebar: fix no vertical space by adding row gap
This also allow for one single shared place to have that
"margin"

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac46810ac4ef219a4103bc315722dbd95e6fd169
2022-11-29 19:50:08 +01:00
Pedro Pinto Silva
d6ddae75b2 JSSsidebar: Fix ui-image alignment and size
We can set those so, the total size is 28px (same as the
grid cell) while keeping svg 16px size this in turn centers
the icon within its parent

Also we can then use the same 5px (that we use for normal button
margin) for the column-gap so everything aligns well

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib13a376fe71e308f9146c291acfbe3a941a4ef57
2022-11-29 12:56:39 +01:00
Pedro Pinto Silva
c86424dba0 JSSidebar: remove outdated vertical-align rule from buttons
We now use CSS grid and this rule is now not needed

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I65f5a1d05d0ac748c328c669e99be307c8721f3c
2022-11-29 12:56:39 +01:00
Szymon Kłos
dcdb577a6a sidebar: hide stack container when not needed
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaa23b49ab7a90604c0eab7324411ecfd81656995
2022-11-29 10:29:13 +01:00
Szymon Kłos
99f1acaa70 CSS fixes after rebase
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I39c9595710f786bc6d6f5fbbb0dc3e6ff38af585
2022-11-29 10:29:13 +01:00
andreas kainz
2f66d70ebd simplify jssidebar.css file
complete new structure of the jssidebar.css file

file is structured into sections

1. general
   for general sidebar settings

2. expander section header
   ui-expander classes

3. section content
   biggest section
   define the sidebar gap elements
   first column justify-content: start
   last column justify-content: end

4. widgets
   general staff

4.1 widget width
    defined widths

4.2 widget selected
    style for
    - selected,
    - non-selected,
    - hover

5. fixes
   specific fixes

5.1 writer fixes

5.2 calc fixes

5.3 charts fixes

5.4 not available commands
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ia449544a671134abebdd4bebd347d20b119c964d
2022-11-29 10:29:13 +01:00
Szymon Kłos
8ac4c5b672 sidebar: don't add special alignment for spinfields
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I724097f9fb60d0620f9da5d78a49b619c8fc98a0
2022-11-29 10:29:13 +01:00
andreas kainz
9c1db9919b Sidebar calc Alignment stacked push button better size
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I394c7725b1eb507b54630b48ccef5ac8e5416fdd
2022-11-29 10:29:13 +01:00
andreas kainz
dbf7738c1f Sidebar Calc Cell Appearance arrange widgets into one row
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ic68bea19e302ff664c09df6bf154865a7d1e200e
2022-11-29 10:29:13 +01:00
andreas kainz
1c7665ecf6 Sidebar Paragraph section alignment of spinfields
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I439ad49c5630071896ef1f7fc4538ef446139f52
2022-11-29 10:29:13 +01:00
andreas kainz
ca45b74bf5 Sidebar add padding to grid-cell similar to how notebookbar was designed
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ieef9e7671c0c009d59d5597b34fd23ac7e26611b
2022-11-29 10:29:13 +01:00
andreas kainz
1e58908cf5 Sidebar: align widgets left and right with space between
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I88bda938d314cd6b0b239542b9f0fcbf367c79fa
2022-11-29 10:29:13 +01:00
Szymon Kłos
0f5dccd990 jsdialogs: cssGrid columns and rows
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id23b85a4bb3cc5845beade9f049d2250b5bd7f55
2022-11-29 10:29:13 +01:00
Pedro Pinto Silva
98b0fd4a7f Fix jsdialog spinfield jumping on hover
Visible when using the following core change:
https://gerrit.libreoffice.org/c/core/+/142974

Note: no need to have generic CSS rules for spinfields
only for the sidebar

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2c9df00d1067537adb9ec5e3db0eab8bd1b2290
2022-11-24 11:33:23 +01:00
Szymon Kłos
562a1094d9 Fix alignment panel width in calc
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I119d10f58fdb3159dcd780799042c37f99dd112f
2022-10-27 10:32:50 +03:00
Gökay Şatır
e200533b5e Remove obsolete css rules for shadow-transparency items.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idd1b71e1b32a1367902a230eb9f43fe18321f856
2022-09-23 14:42:21 +02:00
Pedro Pinto Silva
45341ab31e Remove master slides sidebar's btn CSS declarations
Better to inherit from button.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4dacfefa1f551c67e1b00910f25393897f7ccae9
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
e55812033d Remove sidebar's hardcoded :hover states for unotoolbutton parents
These should not be targeted
- ids can change (e.g. FormatPaintbrush2 ,etc)
- Also unotoolbutton is already inheriting :hover rules

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7149cebfd52b4049a27bd3989fc88d254440df6d
2022-08-17 10:21:26 +02:00
Pedro Pinto Silva
f3c7b59265 Fix sidebar's clear direct formatting hover state
No need to specifically mention unotoolbutton's parent and apply :hover
, unotoolbutton is already been targeted

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaa92d50f35f63dea4d10cd0906d9dadb700c25f1
2022-08-17 10:21:26 +02:00
Szymon Kłos
962e1a9a5a sidebar: show Misc panel with Table Cell Color
It was removed in:
mobile wizard: hide unsupported items in table panel
commit 1aed5ddaa4

but now works

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia9ba8d9c7bad1c2074405617a4443e05df42ac66
2022-08-04 13:17:26 +02:00