Commit graph

13781 commits

Author SHA1 Message Date
Ezinne Nnamani
74f14cccdf Created Cypress test for Merge cells in Desktop Calc
Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
Change-Id: Iba89ea0a2bc5b788c9202247d5cada801fc6d5f6
Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
2021-01-12 13:44:07 +01:00
Szymon Kłos
bbecabed82 mobilewizard: refresh sidebar after border change
Change-Id: If4ef31d47c3831cbc4918b2cf168cae9acd542e0
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-12 10:04:04 +01:00
Szymon Kłos
8e25f04e8b mobilewizard: add disabled state for toolbox children
Change-Id: I5fb30e63b05a32f986c6eab587bea089ba5f2294
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-12 10:04:04 +01:00
Szymon Kłos
702f3b3036 mobilewizard: send XLineColor data properly
Change-Id: I79a53f23a7efdc6f404192baedc0ac4bf50c2bb3
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-12 10:04:04 +01:00
Ashod Nakashian
07cf0d52ef wsd: default UserFriendlyName if missing
While UserFriendlyName is an optional field
in the WOPI protocol, Core needs it for
the Author of the document. When it's blank
the Author is not set and the document fails
to load.

By default we are at least able to load the
document with a sensible placeholder for the
Author. Meanwhile, we log a warning to let
the integrators know of the issue.

Documentation updated.

Change-Id: I4dd2c9d164b4d889f85701a4a27ee8d395bff220
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-11 22:07:21 -05:00
Pedro Pinto Silva
41728bd630 JSDialog: force checkbox style
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2770137acb9c64bca79c21f0e99dfaabb2701217
2021-01-11 17:12:03 +01:00
Michael Meeks
7094331d89 Add pixel-testing image for interpolation avoidance.
Change-Id: I8d6da1e35f4c0a8dfcead884ea3ad3a078c96157
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-01-11 14:16:47 +00:00
Henry Castro
722a152caa wsd: disable setting "SAL_LOG" in "DEBUG" mode
The development environment is necessary analyse
the logs, so disable setting SAL_LOG instead to
add a parameter to already a long list of options

Change-Id: Id8e4a66e1dcb32c636806e47e1d69270af4c53f5
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-01-11 08:15:39 -04:00
Tamás Zolnai
0a0d185258 cypress: NC: disable failing spellchecking tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I3d48a5069eb0bfad8168826b6ab79ccd7f207b32
2021-01-11 12:28:48 +01:00
Andras Timar
289a51db58 Fix #895: build poco from source, link poco statically, add openSUSE target, and other fixes
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I525ee004771ad335e41e4602e044d4fd8d8a19bc
2021-01-11 11:46:52 +01:00
Szymon Kłos
a47a5b324d jsdialog: radiobutton updates
jsdialog updates require main container for control to have
id equal to the widget id. In case of radiobutton it wasn't true.
Fix it for desktop for now and leave for mobile as is (used
in cypress tests - so needs reworking)

Change-Id: I9220b289185ff6a72ea08360f0fa0570db40f95b
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10 19:19:19 +01:00
Szymon Kłos
b00e903030 jsdialog: support radio groups
Change-Id: I8a56ccfe5d38ea451713d732c11131b8ee3d3db6
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10 19:19:19 +01:00
Szymon Kłos
ca51113955 jsdialog: apply updates using new message
- use jsdialog: message instead commandresult:
- add updates handling also for autofilter dropdown

Change-Id: Iab909c9f119625784c6efcd14e8d0fdf38302ce4
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10 19:19:19 +01:00
Ashod Nakashian
e8a5b4843c wsd: UploadResult cleanup
A minor cleanup of UploadResult to make tidy
it up a little bit and make it less specific.

Single-argument constructors should be explicit
to avoid unexpected conversion and other surprises.

Change-Id: I57599805743dffddac620f501dc6ca79c2217f89
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-10 11:13:27 -05:00
Ashod Nakashian
81d794bf9d wsd: chrono type-safe usage
Change-Id: I1e6bc4724672d3e86ad997d7b13ff9db87aade1e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-01-10 11:13:08 -05:00
Andreas-Kainz
c4c30ecc03 add clone and clear to ContextMenu
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Idd963d2f5789dbec4e1fb182d5e96925b64fabaa
2021-01-10 13:14:59 +01:00
Szymon Kłos
5268b8c5fb notebookbar: select correct tab for cached ones
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7b3ff02f3e2e6ee444edb5d11fb08c1171141d90
2021-01-09 16:22:56 +01:00
Szymon Kłos
0107e7feda notebookbar: improve readibility in Impress
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic1f00d9b272d012fa9f2f5b6ccd076aba7d4f1eb
2021-01-09 16:22:56 +01:00
Szymon Kłos
8398f1a5a0 notebookbar: improve readibility in Calc
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie09740892a96ba3b3cf7a406e994d5f60e75ecb0
2021-01-09 16:22:56 +01:00
Szymon Kłos
dd3bffa540 notebookbar: improve readibility in Writer
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I32dd75967f70fac0fe7d399d44a4432fce12afc6
2021-01-09 16:22:56 +01:00
Szymon Kłos
014a2b412f notebookbar: improve readibility of JSON
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3bd732f254a17883378de38319283d689e82b1e6
2021-01-09 16:22:56 +01:00
Henry Castro
7b6a0fa904 loleaflet: fix remove child
Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is no longer a child of this node. Perhaps it was moved in a 'blur' event handler?
    at NewClass.onRemove (src/layer/marker/Annotation.js:48:24)
    at NewClass.removeLayer (src/layer/Layer.js:83:10)
    at NewClass.onAnnotationCancel (src/layer/AnnotationManagerImpress.js:107:14)
    at NewClass.fire (src/core/Events.js:152:22)
    at NewClass._onCancelClick (src/layer/marker/Annotation.js:314:14)
    at HTMLInputElement.handler (src/dom/DomEvent.js:51:14)

Change-Id: Ib4a9f60d6b0685b80cdf1271f506692dffe19715
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-01-08 15:20:17 -04:00
Henry Castro
85912b9100 loleaflet: makefile: fix override recipe
Makefile:815: warning: overriding recipe for target 'dist/vex.css'
Makefile:815: warning: ignoring old recipe for target 'dist/vex.css'

Change-Id: I31083acc17b89df4f02bfbd55696725dc04f275d
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-01-08 15:19:50 -04:00
Pedro Pinto Silva
ac3b6f0947 Mobile: Calc: Misaligned text in Validity > Error Alert
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7866eed069857a9762c91d96407a710be3ae2187
2021-01-08 16:12:27 +01:00
Pedro Pinto Silva
fe2064b3ec Impress: Expose Insert Line on classic and NotebookBar mode
related: #1139
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaa520f925eaf5808d7b1f9c3cf90bac0591c6640
2021-01-08 14:24:05 +01:00
Tamás Zolnai
7887056213 cypress: make: remove unneeded run_interactive_multi() funtcion.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib6642b57a11d0ae181358fe74f0be48cbd65f774
2021-01-08 13:24:11 +01:00
Tamás Zolnai
1276580794 cypress: make: restructure and document desktop interference test functions.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I20c170a8da84191f333d7a9584ba073a3feebf40
2021-01-08 13:24:11 +01:00
Tamás Zolnai
45f1211899 cypress: make: restructure and document mobile interference test functions.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I5540d537672ff0384354d25a7c92111fa45fe927
2021-01-08 13:24:11 +01:00
Tamás Zolnai
ce43db6ec9 cypress: make: document multi-user test functions.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I304fc0e44c64f7eccf35f75f8eed6d9c1810bced
2021-01-08 13:24:11 +01:00
Tamás Zolnai
6672170932 cypress: make: remove unneeded '\' character.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ifb20a849e5f3e9115d6453eba63257d281cdbf9b
2021-01-08 13:24:11 +01:00
Tamás Zolnai
7fe262127e cypress: make: restructure and document run_multiuser_test() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic4623cb89a97f32e88020c61996eddbe060e389e
2021-01-08 13:24:11 +01:00
Pedro Pinto Silva
b170601ff1 Writer: Expose Insert Line on classic and NotebookBar mode
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7a19e64a436f2007cc434b7046f87ff3bc048203
2021-01-08 12:31:16 +01:00
Tamás Zolnai
66282b1030 cypress: make: move this echos to the rigth place.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic77663a9c3debbe39e34ba5575cda381fa4d70ef
2021-01-08 12:24:03 +01:00
Tamás Zolnai
31fee645fc cypress: make: restructure and document run_desktop_tests() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1c8138ae400e25ab198ea10acf438813b2b7eb6a
2021-01-08 12:24:03 +01:00
Tamás Zolnai
54ff9bf7ad cypress: make: restructure and document run_interactive_desktop() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib409f724a8a4214fb473c96cda37fa54cf626df2
2021-01-08 12:24:03 +01:00
Tamás Zolnai
5dbf5a9c56 cypress: make: restructure and document run_mobile_tests() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I41b1dd78fb98897b11fd03f3e9778011b4faaa31
2021-01-08 12:24:03 +01:00
Tamás Zolnai
7413a298e4 cypress: make: restructure and document run_interactive_mobile() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I9ebd5f765f37757c310e2963ddbc0ca9b55668fc
2021-01-08 12:24:03 +01:00
Tamás Zolnai
9796f47994 cypress: make: extract run_test_headless() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id1592c418e54a50c06db1ecb5d8f106b95b2502e
2021-01-08 12:24:03 +01:00
Tamás Zolnai
5398ef8591 cypress: make: fix build failure caused by not expected parallel build.
By now 'make check-mobile' and 'make check-desktop' commands
are not supposed to run in parallel. So 'make check-mobile -j3'
won't run mobile tests in parallel (three tests at once).
However, before this commit running these make rules with more
jobs, led to build failure. With this commit the build does not
fail, but still ignores the jobs and run the tests on a single job.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I13e13fdefcfb393ae5a42b4e065bbfe00278236a
2021-01-08 12:24:03 +01:00
Tamás Zolnai
c665ea0a6f cypress: make: extract run_test_parallel() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7d89abfc5d98c3db37fed7ac266d57af639cfe73
2021-01-08 12:24:03 +01:00
Tamás Zolnai
34b64a3106 cypress: make: extract run_interactive_single() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ie9a84cbdfa95d53dcbf63eb4387d6cdc89ad6769
2021-01-08 12:24:03 +01:00
Tamás Zolnai
bf0a547804 cypress: make: extract run_interactive_all() function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I960f8271b92753d74bb338793a0d283a955ebffe
2021-01-08 12:24:03 +01:00
Tamás Zolnai
8c6a2da439 cypress: restructure makefile.
Too make it more organized.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idf630df2813f6c7ce043b1f00db92105450ba814
2021-01-08 12:24:03 +01:00
Gökay Şatır
ea9f1cbb78 CanvasTileLayer: Fix image rendering.
There was a regression because of the recent improvements.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If0b77349a65f2503b29de7ca5e967282c979b6bf
2021-01-07 20:17:17 +00:00
Gökay Şatır
ebfcbbd8a2 CanvasSectionContainer: Rename myProperties to sectionProperties.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I79b362f384315123468238a465e37692c7242546
2021-01-07 20:58:44 +03:00
Gökay Şatır
a34fc23e1f CanvasSectionContainer: Add mouse enter & leave events.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I09b66deebe21e4d4732525ff8ffa778dab99110c
2021-01-07 20:58:44 +03:00
Gökay Şatır
de9299a455 CanvasSectionContainer: Improve event handling.
Tested on mobile device and desktop. Event combinations are added.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I97087921c7cc4de292e8919bcc8a99fd86d27806
2021-01-07 17:10:00 +03:00
Gökay Şatır
5ebb4b0a23 CanvasSectionContainer: Add drawingOrder feature.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I531ef4cfb3c5820cab99f6b8861e687f44d38d33
2021-01-07 12:38:00 +03:00
Gökay Şatır
3da59be947 CanvasSectionContainer: Rearrange re-drawings.
Only a few events / functions trigger a redraw. Sections can trigger it when needed.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I49c1b2f52ffd2af9e2201cb500bd5ae06b49d6d4
2021-01-07 12:38:00 +03:00
Gökay Şatır
aa63de4554 CanvasTileLayer: Fix offset variable setting.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ie0796d045e477c00c4edb1efa49e6de0bf2f95bc
2021-01-06 22:53:02 +03:00