Commit graph

67 commits

Author SHA1 Message Date
Pranav Kant
d7ff0b0bb2 loleaflet: Keep the cursor 'default' by default
Change-Id: I88e18f7ce08612837dd99df3f9d08b4561007371
Reviewed-on: https://gerrit.libreoffice.org/50276
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-24 10:28:01 +01:00
Samuel Mehrbrodt
deecd0e0d8 Add some right margin for info msgs
Change-Id: I037b8dd42fa8dafb1686284e9241a32f4068ff75
Reviewed-on: https://gerrit.libreoffice.org/50185
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-22 15:46:33 +01:00
Samuel Mehrbrodt
4c9872188f Add non-obtrusive notification method (infobar-alike)
This reuses the vex dialogs and pushes notifications to the bottom right area.
Converted the limit reached notification to this new type.

Change-Id: I20f0c1202eecde028e70156f02ba31497ef2f9b9
2018-02-22 14:28:09 +01:00
Henry Castro
341c9dcc96 loleaflet: copy text of the annotation element to clipboard
Change-Id: I8675b3752656afc1ba79d614d2f1fe3e7d98f600
2018-02-10 14:40:54 -04:00
Pranav Kant
6335fa6861 loleaflet: Don't allow selecting the dialog canvas
Change-Id: I8c88183f0fbb29b5cd815240105153b71c5eb2ce
2018-01-12 18:22:22 +05:30
Pranav Kant
f44639eca4 loleaflet: hide the caret on dialog canvas
Otherwise, on firefox, when the dialog canvas has the focus, a caret
different from the one overlayed by LOK, is shown.

Change-Id: Ie38aae59f01a3811becca0bcf50c9d7d240bfa9b
2018-01-12 18:22:17 +05:30
Pranav Kant
c7d268b4a4 loleaflet: '/' or backspace launches browser-specific actions
Make the canvas contentEditable which prevents such actions from being
invoked. Other alternative would be to add a dummy text field but this
seems to do the work as well.

Change-Id: I8d39f06b02959459e0beeebad2eefcd8e9e00d9d
2017-12-26 17:27:23 +05:30
Pranav Kant
91d6755781 Bringing it to the top of the world
I don't have much idea how the vex overlay's z-index is 1111. We don't
set it anywhere. Anyhow, the dialog still needs to be lower than vex.
Hence, the 1105.

Change-Id: Idbd9beeb84d626a80580a7f7ca75f73edb89f06b
2017-11-28 22:18:21 +05:30
Pranav Kant
3dd644b1bc lokdialog: Let floating window pop out of the dialog container
Change-Id: If339cdff39137e68a1fb61bb49830f4734485001
2017-11-09 14:44:49 +05:30
Pranav Kant
2b8c4ee3bb lokdialog: Remove padding around dialog canvas completely
Change-Id: Ie6d65ca23936f081c5e2b37fff6f5d90d9fcd06e
2017-11-09 09:49:17 +05:30
Pranav Kant
83cb6270da lokdialog: Strip unnecessary padding from dialog container
No idea yet why there still is a thin padding strip at the bottom of the
dialog.

Change-Id: Ia1347bafbf647385c1771f7af3e755cbf44dd666
Reviewed-on: https://gerrit.libreoffice.org/44517
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-09 04:24:13 +01:00
Pranav Kant
374d6a197d lokdialog: pass the dialog id in dialog command
Change-Id: Ia0e76b1dc93483340361777cf21f23127bac91e1
2017-10-25 00:38:08 -07:00
Pranav Kant
e74a4e2487 lokdialog: wrap the lok dialog image in dialog container
The two test dialogs, Spelling dialog and word count dialog
appear on the screen when invoked from the menubar.

Interaction with dialogs is WIP.
Mouse/key events and floating window still needs to be worked upon.

Change-Id: I2d439465c7536d0b453c8ade503ec181a96c90d2
2017-10-25 00:38:01 -07:00
Pranav Kant
1e6c345715 loleaflet: Detach closebutton from toolbar
This is so because we require this also when document is opened in
readonly mode and we don't have any toolbar in the readonly mode.

Change-Id: I085d1640f52843e01370d528d6eea656b743d908
2017-06-22 19:48:24 +05:30
Pranav Kant
b4ff02cacd loleaflet: Also show scrollbar on hover
Better to add our own class and then add/remove it instead of messing up
with original CSS rules.

Change-Id: I45cf2a566d51fe8e7d9b009c4c9d86b97354ffd1
2017-06-13 18:13:29 +05:30
Pranav Kant
5858f4e856 Don't eat new lines
Change-Id: Idaa1af9a0bc12d9967d3807ebca95ec1ca755ae3
2017-04-27 11:09:55 +05:30
Pranav Kant
56c49af98a loleaflet: Bin client side cell annotation marker
No need as core renders its in-tile annotation marker now, if comment
indicator setting is on in the document.

Change-Id: I213827fc089790398e02b0fd9cba464ab62b0d8d
2017-04-27 10:40:47 +05:30
Pranav Kant
759b0945d4 loleaflet: Don't allow inserting breaks anywhere
overflow-break property is enough for us which still allows inserting
line breaks arbitrarily anywhere but only if there is no otherwise
acceptable break points in the line.

Change-Id: I8ea94daba258b00caa259c97597cf1206a89fa64
2017-04-25 19:40:30 +05:30
Pranav Kant
2d55476b20 loleaflet: Don't overflow long names, align author names properly
Change-Id: I0d833291fc996ecb4007bcb58b588967afa6ea58
2017-04-25 14:48:23 +05:30
Pranav Kant
0c53975f18 loleaflet: New comment size/width
Change-Id: Ief2d9c942dffab7a98dc5a7de2208e511f45df78
2017-04-25 13:32:51 +05:30
Pranav Kant
2b38191e3b loleaflet: Wrap both comments and redlines
Change-Id: Iee0c61340cc78b93a2d3d23157bab715c3e7411e
2017-04-24 20:31:06 +05:30
Pranav Kant
ca482f0065 loleaflet: Fix width of the redlines too
... otherwise with very long comments, they keep increasing their width
which looks ugly.

Change-Id: I5cd67258b251a9d522716433d5e190cd29fef078
2017-04-24 20:31:06 +05:30
Pranav Kant
c88f1156b2 loleaflet: Increase the annotation height a bit more
Change-Id: Ibd04cfe3e17354244a31177edca23467e0f8e9c8
2017-04-24 20:31:06 +05:30
Pranav Kant
ecdb7e2645 loleaflet: Enable vertical scroll on annotations
Change-Id: I6ff7a29bd22f57b4d9bbdbb824619030cf5f2e43
2017-04-24 20:31:06 +05:30
Pranav Kant
b864b562cf Revert "loleaflet: Remove box-shadow from comments"
This reverts commit 86be5a24a5.

Change-Id: I272b9a88e29a8ab77e93dfc36c6e3aec9c91a1a6
2017-04-19 15:22:18 +05:30
Pranav Kant
86be5a24a5 loleaflet: Remove box-shadow from comments
This box-shadow interferes with direct comment children and breaks the
root-children comment block UI. Lets remove the shadow for now.

Change-Id: Idda659bcfca76093c148400b2ab311bc39861e84
2017-04-14 13:46:01 +05:30
Pranav Kant
043ec94bef loleaflet: Same width for all comments, different from redline comments
Separate css classes for these different types of annotations.

Change-Id: I2013a05a2f7095956765661169670e0bb87bb372
2017-04-14 11:46:12 +05:30
Jan Holesovsky
7b7c73f8be Align the Accept / Reject buttons with the kebab menu.
And few other improvemnts inluding:

* use svg instead of png for the menu
* add title (caption) for the Accept / Reject change.

Change-Id: Ic7e781d7e93d319f766b387a8eddfa70c1920760
2017-04-12 17:43:49 +02:00
Pranav Kant
5bb6e203c5 loleaflet: Accept, Reject redlines buttons in main annotation win.
Change-Id: I16b931c07485eb98fdac00d1dc968a4c9251a02a
2017-03-23 17:34:35 +05:30
Pranav Kant
064b2508a7 loleaflet: Slide sorter for draw documents
Change-Id: I4ad11236c0186561b5c7df1a3c634e54f8576c8c
2017-03-20 13:59:52 +05:30
Henry Castro
bd911ff9d5 loleaflet: rework Impress annotations
LO Impress does not have an anchor position of the annotation object

Change-Id: Ifaa08bb3f62f442f3ee58242e835b6377901a592
2017-03-09 23:01:33 -04:00
Pranav Kant
148e0f6832 loleaflet: Make caption text bold
Change-Id: I2dbfcf8e341703ba931466e00c269a4a5814c7f9
2017-03-09 17:41:15 +05:30
Pranav Kant
7c84478840 loleaflet: Allow accepting/rejecting a change from sidebar object
Change-Id: I309b33c4569bc74c69200298566734e16d08b305
2017-03-09 17:11:01 +05:30
Henry Castro
9f9e090039 loleaflet: make annotation color consistent with the toolbar
Change-Id: I7b153f01844f5be2c55d1760b75206d2ca96a01d
2017-03-07 21:35:50 -04:00
Henry Castro
dc24fdea67 loleaflet: change annotation appearance
Change-Id: I9c27b0576b686ac5b8a92bda8ab7960a1b400777
2017-03-01 17:54:45 -04:00
Henry Castro
91666d7cd3 loleaflet: insert Calc comments 2017-02-25 18:18:24 -04:00
Pranav Kant
8fa0bb54bd loleaflet: fix readonly UI for spreadsheets
There is still one known problem - for some reason, when a spreasheet is
opened in readonly mode, the ViewRowColumnHeader request sent to server
has height=0 leading to server sending no rows information back to client.
Though the problem gets resolved when one scrolls the spreadsheet
window, but something to fix.

Change-Id: I2aefafd1a93c1bc5a9ad8581edb83018ec9a3f07
2017-02-17 22:16:58 +05:30
Pranav Kant
c3f9ebb888 loleaflet: Fix readonly UI for impress
Change-Id: I1434cad4f471a3f13c989d67b95b967345598148
2017-02-17 20:53:54 +05:30
Pranav Kant
e4ed4c1ad2 loleaflet: Vanish UI in readonly mode
Some of the related code was accidently commited in
8ebff4399c74a42463e1ec7578e6f5a028826682

Change-Id: Ia58e31bea7352541a89ae3f1b57c611acbe27e21
2017-02-17 20:09:10 +05:30
Henry Castro
aa751efbee loleaflet: modify and remove annotations 2017-02-14 16:37:16 -04:00
Henry Castro
f9d54cd058 loleaflet: insert annotation 2017-02-11 21:22:59 -04:00
Henry Castro
174154093b loleaflet: add annotations 2017-02-05 20:24:18 -04:00
Pranav Kant
962cc570cd loleaflet: More document space, use space reserved for scrollbars
Don't give extra pixels to scrollbars and reduce the document
area that is visible on the screen. Instead put these scrollbars
on top of the content and show them only when user hovers over
the scrollbar.

Change-Id: I7f7b34d0efde24bfad04324f5dfe3e3e35c752fc
2017-01-16 20:27:46 +05:30
Pranav Kant
456afb50bd loleaflet: Move closebutton to menu bar option in mobile mode
Change-Id: Ie6b9f507862e36ada44fda88acd96b1b495ae002
2017-01-12 21:38:13 +05:30
Pranav Kant
9b564af003 loleaflet: Set toolbar-up-more width to auto in low screen width
Change-Id: I10c41630da3a3003db1663bea211b42335f468c8
2017-01-12 21:38:13 +05:30
Pranav Kant
21d3ef8c33 loleaflet: right padding for hamburger option menu
Change-Id: I1d946f537e66d637e82354ff3af80353a930d8eb
2017-01-12 21:38:09 +05:30
Pranav Kant
54e2b237b6 Position row/col headers absolutely inside header frame
... so that its easy to move all of it when we switch from mobile
mode and vice versa.

Change-Id: If2db351aafc4a8fefa05bc88f73c0046a3f887b8
2017-01-12 19:41:04 +05:30
Pranav Kant
c20ff7adda loleaflet: Collapse to a single row in mobile mode, more doc space
Change-Id: Ic6ad9dd78e8710497e33069cd7121f31f240f035
2017-01-12 19:29:55 +05:30
Pranav Kant
aa7ef0337c Fix specificity and hide slide sorter for smaller screen width
Using !important always is not a good idea. You can't override an
!important with another !important and we have started to face
such situations now where we want to adjust element's alignment
based on media-screen width. Instead lets fix the specificity to
make this work.

.parts-preview-document or .spreadsheet-document would be
0-0-1-0. Use #document-container.parts-preview-document to
increase its specificity to 0-1-1-0 so that we can do without the
!important flag and use !important flag for media-screen blocks.

Change-Id: I1d15df492cdc7cd1cd09c3b43c8ea84295a07205
2017-01-11 17:05:38 +05:30
Pranav Kant
b34f5a38a2 loleaflet: Wrap slide sorter and related refactoring
Slide sorter and presentation toolbar are now contained in a
presentation-controls-wrapper and alignment values are now
factored out and only present in the container now.

Also, position the presentation-toolbar absolutely outside of
container so that slidesorter scrollbar doesn't go behind the
toolbar hindering some view of the slide thumbnails.

This would also make the job of hiding/showing the whole control
easier.

Change-Id: I080e854906ef0635aba02cfeb687bf87463ef756
2017-01-11 17:05:38 +05:30