cause of the problem: if the last position of the cursor
before selecting a complex object is out of view
then the page will scroll to that point.
This happens because scrolling takes place between
deselecting object and cursor position update
Change-Id: I4046cf6728f7da32a4f6d89768e201982023afa9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91734
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Fixes issue with crash when parent window was already closed
and then user tried to close child window.
Example: Tools -> Spelling and message box ("Spellcheck completed")
Change-Id: I30fef5adb33ba4208b1ee48f3bbced1cff2969d1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91468
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
After this commit:
9374a28835
The view jumps to the cell cursor, so we should have
the cell cursor at the first column to avoid view
change after opening the document.
Change-Id: Ie577ab932496a5506e69b84bf7ff362d98950e92
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91682
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The actual problem was with the test document.
The selected cell was in the fourth column and
the view jumpped to it. So I moved the cell cursor
into the first column, so there will no jump when
opening the document.
Plus reworked clickOnFirstCell() a bit.
Change-Id: Ic132d1ef5392c1653060f84caa6c39f2033f8598
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91661
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Added in:
9374a28835
getWest and getNorth is a float value, not a pair of values.
We don't need actual subtraction here.
Change-Id: I2ffa964863eefcdb2758e5e920563c31f22b77b8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91646
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
There are already several classes called Document on the C++ side.
Let's reduce confusion a bit. (Also, we might need to use the
Objective-C Document class from some of the Online C++ code (which is
actually compiled as Objective-C++).)
Change-Id: I34347ba0161c067b14bb125c3410eefd89bbca31
The purpose of the convert() function (without arguments) is to either
return fast in case the type of the JSON value and the argument match or
do a conversion.
We generate this JSON, so we know the JSON type will be always a string
and the argument type will be a size_t, so use the variant that always
does a conversion.
(Additional benefit is that I seem to hit a false alarm with
admin_fuzzer in the old code and it goes away with this change.)
Change-Id: I40851ab3ddd46fb1515ea9f0c9f40d9ec2006de7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91652
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
LibreOffice Online/ios (Portuguese (Brazil))
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I62d7492d5f9d867bb5e7b3e0092606a2bc8f0e88
update translations
LibreOffice Online/loleaflet-ui (Portuguese (Brazil))
Currently translated at 100.0% (292 of 292 strings)
Change-Id: Ic03d72abd2e6aa70330ab2494df033ff43ffcc6a
update translations
LibreOffice Online/android-app (Greek)
Currently translated at 100.0% (102 of 102 strings)
Change-Id: I96f62c4c4a90970614f9f456db9ac965ac192236
update translations
LibreOffice Online/android-lib (Greek)
Currently translated at 100.0% (12 of 12 strings)
Change-Id: I31de8ed41b0709e640f682bb4a97b33ffe4914bd
update translations
LibreOffice Online/ios (Ukrainian)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: Id766ebd459eec65d27b55931a27ad912fa29f39b
update translations
LibreOffice Online/ios (Greek)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: Iac81fb01e9168d77679672089df1373ec09db6c4
update translations
LibreOffice Online/loleaflet-help (Greek)
Currently translated at 100.0% (416 of 416 strings)
Change-Id: I8d247c6f64ac666dfcb31bc7f489d4350dbcf738
update translations
LibreOffice Online/loleaflet-ui (Ukrainian)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: Idb6b1798d10761adec99024fd81f50981e1ad161
update translations
LibreOffice Online/loleaflet-ui (Greek)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I5c222a29cf698ecd54cadb771eb0d8505238a1d4
update translations
LibreOffice Online/ios (Finnish)
Currently translated at 40.0% (2 of 5 strings)
Change-Id: I5d28721c19fcbd6cf6d8137bb0cdd523960eb8be
update translations
LibreOffice Online/ios (Polish)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I74bb40f34b886c65ba4b0d1e4249314d40da87de
update translations
LibreOffice Online/ios (Basque)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I1721bfce5df7bfc3aabd51bcb930e3338233c759
update translations
LibreOffice Online/ios (Spanish)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I64ad62ebebf9882a9720f8b87a898f2af0414f53
update translations
LibreOffice Online/ios (Welsh)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I521cc41cd2fabff5fb981cf8771d29649b132a05
update translations
LibreOffice Online/ios (Catalan)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: I55a557c2d150d0efde4146a42de42f4aee110f4c
update translations
LibreOffice Online/loleaflet-help (Welsh)
Currently translated at 55.3% (230 of 416 strings)
Change-Id: I48c894e595c50014fb485c2873cb21c88f7e76d1
update translations
LibreOffice Online/loleaflet-ui (Polish)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I643b628ce55ec3a6af6629ca05af13cad5ddc975
update translations
LibreOffice Online/loleaflet-ui (Basque)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I0613c9c422c23de5cdd92415581e64bc88e57b1d
update translations
LibreOffice Online/loleaflet-ui (Spanish)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I70fe4e83e7dfac8d7860b53893fa14a3e4131a1f
update translations
LibreOffice Online/loleaflet-ui (Welsh)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I6ed3a9c25e8f5f87fea96dff65ee62369ca734e9
update translations
LibreOffice Online/loleaflet-ui (Catalan)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: Idaa4b73356aaa4d2c0e0294dfbe054a4137cbd71
update translations
LibreOffice Online/ios (Hungarian)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: If7255fc6e58e4f08a060f08f5f567e932d5935d2
update translations
LibreOffice Online/ios (German)
Currently translated at 100.0% (5 of 5 strings)
Change-Id: If1e1d91cf95e8e5fb4c5132ced5d7ae67c9a3c5c
update translations
LibreOffice Online/loleaflet-ui (Hungarian)
Currently translated at 100.0% (292 of 292 strings)
Change-Id: I7a1337316e3bc85f077b900731d6f53adfb703ec
update translations
LibreOffice Online/loleaflet-ui (German)
Currently translated at 99.7% (291 of 292 strings)
Change-Id: I0d23279ace83554307900fa36844415bdb024ca0
Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
Change-Id: Iba298c0bbadea66690c15bbfa1b49b38c0e9cb6d
Translation: LibreOffice Online/ios
Translate-URL: https://weblate.documentfoundation.org/projects/libo_online/ios/
Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
Change-Id: I05e4ec2e11be5dfbd3313d7e3e09d6537fd1a12a
Translation: LibreOffice Online/loleaflet-ui
Translate-URL: https://weblate.documentfoundation.org/projects/libo_online/loleaflet-ui/
update translations
LibreOffice Online/android-app (Portuguese (Brazil))
Currently translated at 100.0% (102 of 102 strings)
Change-Id: I12ec751df10eacd194883f03bfdceab8ce57ff41
update translations
LibreOffice Online/loleaflet-ui (Portuguese)
Currently translated at 100.0% (290 of 290 strings)
Change-Id: I23c75ac7fd1df29d267c7f985614dd1cb0eda0c2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91642
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
This is no longer a huge problem, but it's still a good idea to return
early in that case.
Found with the recently added admin_fuzzer, when I locally disabled the
StringVector safety checks for test purposes.
(If you view the diff with -U30, then you see that we access tokens[2]
later, so if size is < 3, we should give up.)
Change-Id: I46fc531fb042cc1485a17a9e994ad37e9ff0cd80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91587
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Cypress sometimes fails with 'DOM element is detached'
failure because of the animation in the mobile wizard.
Disable animation instead of waiting for 100 ms.
I tried to override $.fn.show() function, but it's
actually overriden by JQuery.ui code.
Change-Id: I0e8e937a501a99b1106d7a450088760f67102bc2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91569
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
When the focus is in the search box, we shouldn't
lose it, or hide the keyboard.
Change-Id: I05c4c3e384d840b2919106af1063978b6fe7fbfe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91580
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
When pasting into the document a special handler
is used to manage the transfer of data. For the search
box we need to let the default handler do the right thing
and so we check that we aren't searching before we override
the paste handler logic, which explicitly pastes into the doc.
Change-Id: I570168d1aaf70c2a78403644e006ba9625ec68db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91581
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Apparently there were more stuff added mobilewizard.css and nobody cared
to update these, so I suspect better not to have this, because nobody
will ever test it again anyway.
Change-Id: I591fe2b52621cde4f1d7d1f087555f98c49731f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91575
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Now the LO Core server sends the converted units formatted
text to update in client side when mobile wizard is visible.
Change-Id: I82416bb4712aa20bcddb409c1129da1aff521a34
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91266
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Change-Id: I20f6188eec56c1ef193a9f1efdfd8b7d7a60f169
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91568
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Idc56a0534770a1895c5e6e7ea93fb46ccb44f3e9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91573
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
There are cases sometimes, where we can't use cypress'
nice retry feature for waiting to an assumption to
be true. A workaround for this issue is the cypress-wait-until
package, which makes us able to use the retry feature for
any use case.
An example is the position of an element. I don't know
a way to wait on the position to get changed in the cypress
test framework. So we can use cy.waitUntil() here instead.
Please use this new package when it's really necessary,
do not replace the better cypress calls with it.
Change-Id: I8c553456e351664e30043b8ccd5ace51f1c0298d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91554
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(When the menu is active.)
Change-Id: Ifdd3dd951aef4c14e596b659f2a05c1288852ca8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91476
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
The mobile-wizard is not shown on desktop at all, avoid the @media.
Should there be some bits that are mobile-phone-only, they should go to
mobile.css.
Change-Id: Iae50779df030586eadd44cbd5a2cb59939a29e47
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91475
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This screws up cursors across views in some circumstances,
when there is no marker in one of the views.
Regression from 3b0478baab
Change-Id: Ia1294d83801d656a919f97206b7b573a1b74b77f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91489
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
It's a known issue that text selection is persistent,
which made these tests unstable. So use a different method
to remove the text selection.
Change-Id: I46b0ba268a39bae9e79ce62686b2d1e0eab1adda
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91486
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Kept in #if 0 in case some similar experimentation needed in the
future.
It might be interesting to be able to tweak behaviour based on knowing
on what kind of storage the doument is located, but alas, that seems
not possible.
Change-Id: I877c96fcea3a350faa58a934485714d15b01141d
I believe this is not relevant any more, since we are using the
mobile-wizard for menus on the phones these days.
Change-Id: Ia6b16fcde1b1e4278a8d40c58968c44492248b69
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91443
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
