This patch allows the lok core to know about the device form facor of
the client requesting the creation of a new view, immediately instead
of a later time.
When a request for a new view is sent a 'deviceFormFactor' parameter
is appended to the message.
This parameter can have one of the following values: 'desktop',
'tablet','mobile' and is forwarded to the lok core.
Change-Id: I21739ddb8c43c960164b3c625e4cf0a80f4616a4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92691
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
It is used (just once, but still) in the remaining parts of
w2ui-1.5.rc1.js.
Change-Id: Ic59f9c0d7d10b3556a4f8fbe08b7af2faa77d941
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92043
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
There is clearly not enough space for the normal sidebar when one of the
dimensions is below 768.
Change-Id: Iac27f12f837b9e6a64d1cce7b8376009bbe2c15f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92004
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
No idea why they were in Control.Toolbar.js.
Change-Id: I18ab812317b4bfb71d0c63a4cb2283d4fbaa3b54
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This should never happen, since the _onMessage is re-assigned when
loadDocument is called, but it is better to ensure to forward all
messages.
Change-Id: I9a792bc077b26f2f92c30c4e7851c9d2b2637bfb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90449
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The file was imported from node_modules/autolinker/dist/Autolinker.js
the main reason is to analyze the source code, debug and patch
if necessary
To get the source code from npm repository
make libs
Change-Id: I3eea7cc6e8d61623398d77ed74e751ccd861252b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89150
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The file was imported from node_modules/json-js/json2.js
the main reason is to analyze the source code, debug and patch
if necessary
To get the source code from npm repository
make libs
Change-Id: I7d80646704b368f6961c75f1dabaabecde2527e6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89146
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The file was imported fromnode_modules/select2/dist/js/select2.js
the main reason is to analyze the source code, debug and patch
if necessary
To get the source code from npm repository
make libs
Change-Id: Ibe0fd718d1dd6157d463a304c56fd6475821a0eb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89110
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The file was imported from node_modules/vex-js/dist/js/vex.combined.js
the main reason is to analyze the source code, debug and patch
if necessary
To get the source code from npm repository
make libs
Change-Id: I59e466e925d43bf4c599305898c656f69ec195d9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89099
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The file was imported from node_modules/@braintree/sanitize-url/index.js
the main reason is to analyze the source code, debug and patch
if necessary
To obtain the source code from npm repository
make libs
To bundle the file sanitize-url.js
browserify braintree-sanitize-url/index.js --standalone sanitizeUrl > sanitize-url.js
Change-Id: I7869a1349648ae1f8f2194859ebb398b1a73733e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89055
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The file was imported from node_modules/l10n-for-node/l10n.js,
the main reason is to analyze the source code, debug and patch
if necessary
To obtain the source code from npm repository
make libs
Change-Id: I7bd4d400c504f57a94566e187c6d26361aed8bd0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89043
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Move the code related to browser detection immediately
when loading html page to be accessible to all javascript libraries
Change-Id: I442cf5ab8e9452bffa5a760768e8a3e38c1c3c21
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88744
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
w2ui is bundled with: w2grid, w2layout, w2popup,
w2tabs, w2sidebar, w2fields, w2form
But they are not used in desktop nor mobile and
it is preferable to remove the dead code to reduce
bundle size, parse with mobile devices.
If in a near future, these components are used,
still we can restore the components.
Change-Id: I522f01a73217635acc9828a54006111fa196636d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88735
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
This checks whether all statements end with a semicolon.
We already use this rule in the code, so I enable to check
this rule by eslint to keep the code consistent.
Change-Id: I5ea46376d2b6fb488224d4d69e4d117139763a8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The mobile and desktop prevents default 'contextmenu' action
Change-Id: I89171c955c153b2fceaad92970e2eaf039cb8527
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86373
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
- Enable and adjust elements when on mobile so they are visible but discreet (without covering icons)
- Make them not clickable when on mobile (thus avoiding unwanted scrolled due to users mistaps
- Make their parent aware of the ongoing scrolling and call w2ui resize on it (thus making the left and right indicator showing and hiding as we please)
- Test and adjust so this changes do affect affect the click listening on desktop etc
Change-Id: Ic35dadb71e7fd6ae3ff2fad3e52d5219e7520c55
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86364
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Horrible hack, but works for the specific case described in the bug at
least.
Change-Id: I55150d84dc892ece69540fdc0d06bc277891c1fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86328
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
To have the menu translated.
Change-Id: I8d4d90d260aa3fcd80a8eb68515b22c58c9b3e18
Reviewed-on: https://gerrit.libreoffice.org/84931
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: If338b10ce3e117a8f43b9bb920820c3d1de324af
Reviewed-on: https://gerrit.libreoffice.org/84415
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Some mobile devices support both pointer and touch events,
so if we add event listener it will fire 2 times.
Change-Id: Ida9862e9ee24e47ccbe3963b5c4ff18a173fffe0
Reviewed-on: https://gerrit.libreoffice.org/82799
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
When the frame is null, it is referring to a container frame window that
it is always not accessible.
Change-Id: Ie96a05327928b2b72ce5577409e368061b2afa1e
Reviewed-on: https://gerrit.libreoffice.org/82798
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
The _coordinates function is called several times to compute
the same coordinate value.
Change-Id: I6e187b74709515ddde77d60649e564cb2b484fb4
Reviewed-on: https://gerrit.libreoffice.org/82797
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Add some missing parameters when the "websocket" is connected after
loleaflet.html while "bundle.js" is downloading and ready to execute.
Change-Id: I36995a3c82ce17fa5a81923e8d6d785f0c1c7742
Reviewed-on: https://gerrit.libreoffice.org/82546
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
I have no understanding of what this code does and how it works but
this seems to fix the problem described in the bug.
Change-Id: I7188745b5c77d9e065828336b7dd6524aedc1dce
Reviewed-on: https://gerrit.libreoffice.org/81079
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit b95a22a740bccbd50d6cf49ad0b5fdbd1d489a90)
Sadly it doesn't seem to work, though, at least on iOS, if I as a test
re-introduce the error that was fixed by
2ddd8d7c81. But maybe it will work for
other uncaught errors. Clearly it is better than letting the code
attempt do the XMLHttpRequest thing which is totally wrong and
pointless in an app.
Change-Id: I7b6e95556603b680527a0516f54e24dc10e96b21
This used to work fine, but at some stage it had regressed. I did not
bother bisecting to find the culprit. Anyway, now the JS part needs to
send a lang parameter in the load message, too, for the corrent
language to be used in the tunnelled dialogs. (Likely it affects also
other things in core.)
Change-Id: I339cddb28357978414669964106cb6fa472c967f
Reviewed-on: https://gerrit.libreoffice.org/77599
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/79023
I've been getting this on Android, but suspect it can be a general
problem:
loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165 Uncaught TypeError: Right-hand side of 'instanceof' is not an object
at global.FakeWebSocket.global.socket.onmessage (loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165)
at <anonymous>:1:25
Change-Id: Ifa6a6b15843e0c8235b920cea07324db59282074
for next patch I require to modify the contextMenu
to trigger on touch start event.
I should do updating archived-packages, but ...
Change-Id: I20f1fbda1e7e60f97cd790c055599edcf8da9d1a
Scrolling with selected sheet was endless.
This change allows scrolling using mouse wheel
when scrollbar is close to the end of screen
and prevents from doubled updates.
Extension of work done before in:
ec24337b11
Change-Id: Id76818158c0d9988b323ec52a408efd5ae6a9da5
Reviewed-on: https://gerrit.libreoffice.org/70266
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
