Commit graph

8136 commits

Author SHA1 Message Date
Jan Holesovsky
4e4da1eb92 Revert "loleaflet: verify if "toLocaleString" function exists"
This reverts commit 52b03a2d1a.
2019-03-15 17:23:00 +01:00
Tor Lillqvist
3503dc9a07 Guard against "TypeError: null is not an object" 2019-03-15 12:59:23 +02:00
Michael Meeks
5627c767ab Anonymization: don't log when it is disabled.
Also fix unexpected concatenation error in Poco::URI::encode generating
eg. authorid=localhost0 xauthorid=localhost0localhost0 in the output.

Change-Id: I560e47e31884eeb1c662f468436ed7541cfb082d
2019-03-15 11:27:38 +01:00
Michael Meeks
d8bb92cdcf Don't count convert-to connections vs. the document count.
Change-Id: I350905fb98c503ae8f22a377e4af5cbcb9f3c52d
2019-03-15 11:27:31 +01:00
Tor Lillqvist
949ca42221 The iOS app now works again
(Except that the tunnelled dialogs don't show up, but they don't show
up in a browser connected to a normal Online 'make run' either at the
moment.)

Change-Id: Ic054b415d5d78572338e20da711a4285584ba330
2019-03-15 09:48:51 +02:00
Tor Lillqvist
21d707757f Make the iOS app work again
We already do all the FakeWebSocket setup things in global.js. We
don't need to do it again in the connect() function in Socket.js (and
doing so in fact breaks stuff).

Change-Id: I2b77b85f2659995e99d21339685717fba14db371
2019-03-14 20:47:08 +02:00
Szymon Kłos
e62c4ba4dc Don't show closebutton on menubar toggle
Change-Id: I57dbca9aac09445c0990770565682adc1da1db40
Reviewed-on: https://gerrit.libreoffice.org/69222
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-03-13 18:52:12 +01:00
Szymon Kłos
a533fad1f2 Don't wrap menubar
Change-Id: I5283a20d50dceb945378b47fc5678798dfa52608
Reviewed-on: https://gerrit.libreoffice.org/69159
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-03-13 16:41:30 +01:00
Szymon Kłos
984565ae68 Hide close button by default
Change-Id: I44528a096849324d68304165f7698fcd7e3b4130
2019-03-13 16:38:56 +01:00
Szymon Kłos
a532906137 Don't show closebutton if not requested
Change-Id: Ie7d84f52244003607cb1a227d9eeea8217c817f8
2019-03-13 16:11:08 +01:00
Jan Holesovsky
5e06891569 Last modification: Show the pointer cursor only when revision history enabled.
Change-Id: I64ca1936f22fc94d887c01e7ccaca4a84154aa02
Reviewed-on: https://gerrit.libreoffice.org/69153
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-13 15:20:51 +01:00
Jan Holesovsky
e22dfdec5d Send the UI_FileVersions only when the revision history is enabled.
Change-Id: I03a1a27c6a09ff34a6ff828b4903785ae342abc8
Reviewed-on: https://gerrit.libreoffice.org/69113
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-03-13 15:17:28 +01:00
Jan Holesovsky
3071f774e6 colibre: Update to the latest versions from master.
Change-Id: I4358a89b48bd4165bdc059a09e7e794599a9d842
2019-03-13 12:00:11 +01:00
Henry Castro
746a81c0f0 loleaflet: fix "failed: WebSocket is closed before...
the connection is established"

Change-Id: Icb44f1a9fe75ac995f9a771d0a0f052c55339df3
2019-03-12 14:58:19 -04:00
Gabriel Masei
023cbfc32d Added support for defragmentation of incoming websocket fragmented messages and handled some protocol error cases
Change-Id: I4d11a6527b6b131c65101fd53b71015529645f74
Reviewed-on: https://gerrit.libreoffice.org/68901
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-12 15:19:42 +01:00
Szymon Kłos
8460f61e94 Show normal statusbar in narrow window 2019-03-12 11:51:32 +01:00
Szymon Kłos
5cafda5fd2 Send init commands after mobile is switched to edit mode 2019-03-12 10:26:04 +01:00
Szymon Kłos
1236c63f6b Show user colors when no avatar is available 2019-03-12 09:21:03 +01:00
Henry Castro
315fc0b3e8 loleaflet: move main.js to src/ directory
Simplify building loleaflet.

Change-Id: I3cdc6455b21e683b0331997766badd606c6aca43
2019-03-11 17:30:07 -04:00
Henry Castro
c1ba96f951 loleaflet: move toolbar.js to src/control directory
Simplify building loleaflet.

TODO. Convert to L.Control.Toolbar

Change-Id: I6abedd19caa6f0c22267c661e67480507dcd8336
2019-03-11 14:51:56 -04:00
Szymon Kłos
3b0478baab Always show cursor header 2019-03-11 16:16:34 +01:00
Henry Castro
4612d10244 loleaflet: integrate "Path.Transform" extension to the main build
In order to simplify "loleaflet" building, the plugin "Path.Transform"
was moved to loleaflet main build.

Please use the file "loleaflet/build/deps.js" if you need to integrate
more files from "leaflet" plugins

Change-Id: Ib3bfa6fd3255811034856849a4f62cc1bf430af5
Reviewed-on: https://gerrit.libreoffice.org/69007
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-03-10 15:09:07 +01:00
Henry Castro
655c2642ed loleaflet: purge "draw-0.2.4" plugin
for some reason I forgot to delete remaining files

Change-Id: Ia5e0fc4ae5e594d5cebbd14f33ecd3163cd076c8
2019-03-09 11:08:55 -04:00
Tor Lillqvist
f60618f0ba Add important note
Change-Id: I9f4a6c8f01c72ec40a38f44a7ac23d22a46d2d83
2019-03-08 13:24:54 +02:00
Miklos Vajna
0d5ee512b3 wsd, tile cache: avoid copy in loop when result is only used as const ref
Change-Id: I7f5d3b0a52c5257b8e8d23fb2eafb5919aaae5f6
2019-03-08 08:37:14 +01:00
Henry Castro
2774a04833 loleaflet: improve early "websocket" connection
Normally the "websocket" is created and start a connection when browser
evaluate "bundle.js" after download it.
So we create an early "websocket" connection after the browser parse
"loleaflet.html" and start receiving tiles to improve load page
performance

Change-Id: I56fca7a2da39031222c1d43781825997221385a1
2019-03-07 14:13:52 -04:00
Henry Castro
3f7fe205bc loleaflet:mobile: remove unused toolbar item's code
Change-Id: I8900c6a945e07fb78dcccd3f2912c9cd2b30f9fd
2019-03-07 10:27:31 -04:00
Henry Castro
52b03a2d1a loleaflet: verify if "toLocaleString" function exists
This API has not been standarized yet

Change-Id: I63e1ac88dc660675420af266766163dbe13d31ce
2019-03-07 10:22:12 -04:00
Andras Timar
7e774f3642 docker: --enable-pdfimport and --disable-poppler in build config
Online does not use poppler anyway, it uses pdfium

Change-Id: Ia72b31072640874d2c54d4d4b28f5282e992b6ce
2019-03-07 12:30:20 +01:00
Eduard Ardeleanu
3301f01c0c fix: remove old svg for currency format button
Change-Id: I2224ed4c6d99b11ce8ab833f21223de82401ae75
Reviewed-on: https://gerrit.libreoffice.org/68840
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-07 10:13:30 +01:00
Henry Castro
70848989ad loleaflet: update node_shrinkwrap
Change-Id: Ibd1b6ed55d8ed7485e6a82cf3e698eb2cbafd034
2019-03-06 22:27:29 -04:00
Eduard Ardeleanu
1073127103 loleaflet: new icon for currency format button
Contains an icon proposal for format currency button from spreadsheet files.
Current icon contains a dollar sign, which can be misleading, especially when the UI is rendered in other languages than english.

Change-Id: Ie767caf11b6ca1644bd8ec31f16344fb281f606b
Reviewed-on: https://gerrit.libreoffice.org/68755
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-06 17:55:06 +01:00
Tor Lillqvist
29626c36a3 I was misinformed: The _ function *is* needed also in normal Online
Not all calls to the _ function are magically replaced by the
FileServer, but only those that pass an explicit string literal.

Change-Id: I9917c569f0471551ade9e46ee9f87b4f326f581e
2019-03-06 17:00:01 +02:00
Tor Lillqvist
f5791f9e1f Send the HULLO message to the mobile app native code already in global.js
Apparently the connect() function in Socket.js is now dead code?

Now the iOS app seems to work as before.

Change-Id: Ib6c2b9a08e818ec8f4b5dbdfbf75f507c4bb7069
2019-03-06 15:30:49 +02:00
Tor Lillqvist
9dee582718 Bin the now duplicate and unnecessary FakeWebSocket things in Socket.js
global.js now defines windows.FakeWebSocket.

Change-Id: I9a430a684769ab071838e4e3e30372f26f761139
2019-03-06 15:28:54 +02:00
Tor Lillqvist
318efba053 Try to make l10n work again in the iOS app
In real Online, after recent commits localisation of messages in our
JavaScript is handled in the FileServer code. Calls to the _ function
in JavaScript being served are replaced with the translated string. We
can't do that in the mobile apps (without some re-work, and I doubt we
want to spend time on that now, there are more pressing problems). In
real Online, the _ function in global.js thus actually dead code.

But in the mobile apps, we don't have any FileServer, and we do want
the _ function to work as before, and we do want to include the
l10n-all.js file in the bundle.js.

Of course, if profiling eventually indicates that doing that *is* a
problem from performance and/or memory usage point of view, we do need
to re-work this. But for now I just want things to roughly work as
they did in the iOS app.

Change-Id: Ib77020010867e7aabaf68bbb892d150d15708213
2019-03-06 14:17:53 +02:00
Tor Lillqvist
97970bc081 Define window.ThisIsAMobileApp etc before they are used in global.js
Change-Id: I7ae2687019575fc27e4c5dff128c8a97595676ea
2019-03-06 13:36:25 +02:00
Tor Lillqvist
039913499b We need the FakeWebSocket code for the mobile apps here, too
We don't use (real) WebSockets for anything at all in the mobile apps.

Is the WebSocket (and FakeWebSocket) code in Socket.js still relevant?
Has it been superseded by what is now in global.js? Good question.
Next question please.

Change-Id: Ief4209b738ba1f0c1a8c496ae53bedcb1f7e14f9
2019-03-06 13:32:59 +02:00
Tor Lillqvist
c8aedbc218 No FileServer involved for the mobile apps, can't use <%FOO%> things
Move the <%FOO%> things to the non-mobileapp branches of the MOBILEAPP
m4 conditionals.

Change-Id: I3d6e51083f7926bb0c90b48367f284e99d64c3b4
2019-03-06 12:39:18 +02:00
Tor Lillqvist
a1feac0c24 Fix -Werror=stringop-truncation: Make sure FatalGdbString is NUL-terminated
(Note that when I say 'NUL' I mean the ASCII character called NUL,
i.e. a zero byte. Not to be confused with 'NULL'.)

Why FatalGdbString has to be a C style fixed size char array I don't
know. Or wait, I do know. Because SPEED!!! And using C strings safely
is trivial.

Change-Id: Id28b00a6e3219cf6f015c4209732f33216f83b22
2019-03-06 11:48:33 +02:00
Tor Lillqvist
8d52cf2c9f Fix iOS build in Xcode: Add header search path for boost
(But note that the iOS app is now completely broken at run-time,
nothing sane shows up.)

Change-Id: I685580bbc0113a075d2cebc54c7af8a3bbca6bd6
2019-03-06 11:03:01 +02:00
Henry Castro
31aa763470 loleaflet: remove timeago.min.js
simplify using Date.toLocaleDateString

Change-Id: Ib264cd90edd7ddacb3b944ee7f252648a629ab3f
2019-03-05 23:55:39 -04:00
Henry Castro
1d801b833f loleaflet: remove jquery.time ago
use Date.toLocaleDateString that returns a string with a language sensitive
representation of the date portion of this date

Change-Id: Id2e207e5b4d0dbc8d82498567c97105052d70b90
2019-03-05 23:50:39 -04:00
Henry Castro
83130d1e45 loleaflet: remove unused map geolocation code
Change-Id: I14f4ca2bade957f0105f31838efe26601d965943
2019-03-05 23:46:29 -04:00
Henry Castro
e81441f63b loleaflet: remove jquery-ui.js
This library is not used, reduce bundle size

Change-Id: I925ed1335a46f78ba74af55582261a86376d7aca
2019-03-05 23:42:24 -04:00
Henry Castro
4a31a3beac loleaflet: fix debug makefile rules
Change-Id: I90f7e1789e631d1a3194316e1c01012326f671ab
2019-03-05 23:37:27 -04:00
Henry Castro
3d91ea94a9 loleaflet: remove unused draw plugin
Change-Id: I6acdec7a5e04ba9cd370b80a3a04b54d370420a0
2019-03-05 23:20:24 -04:00
Henry Castro
c9685387b9 loleaflet: remove client side L10n
Change-Id: I4bd40e569441c22b902b5bac2cb21705a4565384
2019-03-05 22:38:13 -04:00
Henry Castro
304852ccd5 loleaflet: fix String.locale assignment
Change-Id: I901f635ef2cb176329ef8e836a5314efabbc026b
2019-03-05 22:05:51 -04:00
Henry Castro
ad9e0c7c4f ignore generated m4 files
Change-Id: I732287ca2384df1991e04a0b05cd841ca62d7c3f
2019-03-05 21:16:08 -04:00