Sure, the test could be even more strict and actually do a
case-insensitive check for an initial "file:" or
"vnd.sun.star.pathname:".
Change-Id: Ic252aeccdec708138530075d1f38fa348d1e469e
Sure, could add more and more options to specify what LibreOffice
installation to run against, etc, like gtktiledviewer. That is not a
priority though, this is just a very basic testbed for now.
Check all pariticipating IPs to be allowed to use convert-to
functionality. In a simple use case it means the reverse-proxy's
and the actual client's IP.
Change-Id: I4ef9cb14a1c3003cba6c66f6e99d5b54b2c3b2b8
It is likely a Mac browser client simply accessing a "special
character" on their keyboard. (Or an iOS browser client using a
physical keyboard.) Like alt+8 to get '[' on a Swedish/Finnish Apple
keyboard, or alt+shift+2 to get '€' on a US English Apple keyboard.
Change-Id: I94b49d64db87324ff2a5cd5f50226d3c537b68e6
Reviewed-on: https://gerrit.libreoffice.org/62315
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Extract the client IP from the X-Forwarded-For value
and use that one to allow / deny the usage of convert-to
feature.
Change-Id: I363c0931df5a0538236cae12f943fffd65086ee6
Nah, that fixes one thing but breaks another. After the change that is
reverted, the on-screen keyboard pops up too often, also when you just
want to pan around in the document.
Let's see how hard it will be to make the on-screen keyboard pop up
only when actually wanted (after a single quick tap, and after
selecting a word with a double-tap, IIUC) and never otherwise.
This reverts commit c69a19ec30.
Matches the behaviour of real sockets in a real Online server better.
Seems to get rid of the occasional hang problem.
I had already some time ago suspected that such a change would fix
that problem, but unfortunately my first attempt missed one crucial
detail, so it didn't, and I spent days looking for other ways to fix
the problem instead, in vain.
Probably I should add some sanity limit on the number of buffered
messages, though... But if such a sanity limit then would be hit, most
likely much else is totally broken already anyway.
Change-Id: Ice43057814ee5abd85b2935ffaa91765845a515a
Add an entry to discovery.xml with the urlsrc where capabilities end
point can be found. Use json format to send back the feature list.
Change-Id: I390a53d956d53ca79e5a8090aead7f4131ec4ca0
In 1c7f94045a that introduced
DelaySocket, its getPollEvents() could indeed return -1, but that was
removed later.
Change-Id: Ie3a7e01b7b9a7517d97f6ed3cc6d96bdb3313969
Reviewed-on: https://gerrit.libreoffice.org/61990
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>