The temporary directories created for convert-to
and insertfile are used only once and should be
cleaned up to avoid clutter.
We also de-poco the temp directory creation as
it doesn't add value and do a bit of cleanup.
Change-Id: Ie1fd5b4749788ff4407f2cc886d405258f65f97a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We now download the convert-to files into the
child-root/tmp directory and then move it into
the jail that will convert it. This way ownership
and cleanup become contained within our child-root
and jail subsystems. This reduces the chances of
leaking convert-to files and simplifies the design.
In addition, we avoid an extra file copy and improve
the security of the convert-to API.
Change-Id: I450c24d0d0dc0da447c8072b0701c3b48d07c81b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When scroll down button was used the view was jumping
on every use what caused flickering.
Change-Id: I16de0e9d01c9d025977edc6affc16de4bd098b49
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
These helpers are for testing only. They should
ideally be moved to the test helpers, but because
of dependency on the FileDeleter in FileUtil they
remain in FileUtil.
Change-Id: I93c7e08823edec8f6a53419f0a6596f3255f23f9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
On non-Linux systems we should default to std:🧵:id
which needs to be serialized using ostream interface.
While Util::getThreadId does specialize for Linux, the
code using it doesn't always handle the different return
types.
While std:🧵:id is the standard interface to the
thread ID, using such abstraction has proven to be costly
when converting the thread ID on each and every log via
ostringstream (due to the cost of memory allocation).
In practice Linux is the primary and so far only platform,
so the getThreadId is optimized for it. Other systems
can either use the default std:🧵:id, or can also
specialize as necessary.
Change-Id: I91cf279a8fdff12636a534957db5069dee51bd65
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This is not allowed by the standard and libc++ is more stricter than libstdc++ on that matter.
Luckily, the conversion is used to turn it into a string, so just use stringstream to convert the thread::id directly.
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: Iea1a844a086b7fe7ed4703fd06e1d538d5d0bc43
We use simple cy.click() on mobile, we might
get a better result to use a different way for
tap on document in the future.
Change-Id: I4b0c6989aaf105ae79be930ffc54898414efb92a
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is possible for the jail directory cleanup
to fail, if there are still references to at
least one file in the jail. In those cases we
keep the jail path around so we can retry the
next time we cleanup a jail. This reduces
the chance of leaking jails until restarting
the service.
Change-Id: If6116ef598afc91063de71c66870bd6426a971ba
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Instead of hard coded test file, we use the admin
console to find out which test document we should
open with the interfering user.
Change-Id: Iedaea07eb558ca6335d8768ab23799bf02d7f4a7
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We have more users running already for one test, better
to avoid side-ffects coming from running more multi-user
test in parallel (they are using the same loolwsd).
Change-Id: I1cbed36a3ffe2825c384b525da361c4cfe781b38
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Create an alias for the iframes, so we don't need
to find them every time, but we can use the
reference to them. It make the log more clear
and also makes things faster.
Change-Id: I6ca21f951568e46cec3d6a574ce1798b522067ea
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It does not work correctly in NC environment.
Change-Id: I1358f0f80aa05ddb118fc1cfd4237a5fac875fcc
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
One is used in Debian-based installs, other is used in the rest.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: If21c5d70cb8bb738931c3cd05bd4c5c732f394f7
- Fix redundant values and declarations
- while keeping the style the same across different platforms (desktop, tablet)
- while account for different parent's background (notebookbar)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I501cb0137282682980864d980571429ded8cf6c1
