If a cell is edited and suddenly press ESC key,
followed by Shitf + Arrow down to select more cells,
so the "uno:InsertMode" state arrives late and
it cannot update the row header selection.
Change-Id: Ib0e4e0699336e07d96efd96559f7b47caa285921
Signed-off-by: Henry Castro <hcastro@collabora.com>
In 24.04 we activated dialog which informs about idle dialog.
It covers full screen so some tests fail on that.
Add {force: true} to ignore that in failing case.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I11a183deb91ca35a2ddecc63b62bcb82b8ad1d0f
With "notebookbar: simplify structure with css grid" (Change id
I21421da5395fb9a7e4063a40f85e6af64e267ada) there is no more the need
to apply float rules as the grid layout should be responsible for alignment.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie57ffc819f460178eceb03c6796e02a8bc2297e7
Zoom reset button ("#zoomreset") was targeted by its ID:
- We shouldn't do this better to instead inherit css class if needed
- With "notebookbar: simplify structure with css grid" (Change id
I21421da5395fb9a7e4063a40f85e6af64e267ada) this becomes more
problematic:
- Zoom reset button now is align to the top while occupying 2
rows (hover effect display huge rectangle)
- To do: This button should be a big button instead
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaf93a648b10e380b1b8fd5a1cc12e2a88a2accf5
use toolbar from notebookbar_online.ui in the core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibeba3acfdae69248ed4de5d6a2df43cb7d1bb47a
Probably went wrong with bf8b9945ab304c3c4604ff296ff33b3f127accf7 (Warn
on non-async dialog usage when in debug mode., 2024-01-26).
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ifb92e0d9431f252cdf26ac92dd428b87e5d6e8e0
Fails when we don't check for '<img' in Clipboard.js
_navigatorClipboardGetTypeCallback().
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Idde76a7da26bac624c15c316be8cac638032c848
This is the case when the HTML has no own marker and we actually parse
the HTML data.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I8b1690faccbc9ebc6c67557cde8897eccf641fdc
If tests are invoked in parallel, then interacting with the real
browser/system clipboard would lead to unreliable tests.
In practice this is already problematic, because we don't want to ask
for browser permissions when running tests.
Solve the problem by creating a dummy clipboard that can be overwritten
by a test in cypress_test/.
The actual test is not yet added here, this is just the infrastructure.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Icc9e3900dee7fb4b53454152e5cda13439569bdb
Resolved an issue in Impress's 'Present in Window' feature where the snackbar would persist even after closing the presentation window or pressing the escape key. Now, the snackbar properly disappears as intended, ensuring a cleaner and more intuitive user interface experience.
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: Id491e39d88b433993b5ff83e10c3ca2b1eb8ab40
we want the normal ones, so we see the output in our own console, but we
don't want the others.
It would be better to use posix_spawn_file_actions_addinherit_np here,
but that seems to be currently macos-only.
Signed-off-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: Ifd42c51f68ca2f340b78066b381cdbc6a23f0abe
using fork(), the kernel needs to copy the VM data structures,
which can be quite large for the main COOL processes.
I looked into things like vfork(), clone() and using a helper-process,
but it looks like posix_spawn is sufficient for our needs.
Internally it uses clone(CLONE_VM) which means we avoid the VMA copies.
Also, simplify the arguments of spawnProcess,
we don't use the optional params anymore.
Signed-off-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I8f943541dc4d7f56c2d36ccbf7b78c40ec14b8e0
Sets random language and launches debug mode,
turning on the Randomize User Settings tool
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I5e06be624cd5383784ea640304980a82e76be229
Eight is a little few with multiple users around.
Change-Id: I0fe3e8a463463b9d7f2bb3e9efdc4aa12e7777e9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
so we can pass through the full state that the view reports
which makes it easy to see if a browser side is given a view
whose render settings are unexpected.
e.g. clicking "formatting marks" and not getting a viewrenderedstate
with 'P' or view#1 clicks their "formatting marks" and view#2
receives a 'P'ilcrow state.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I31d3a8397f02dedf2505bed5dd83576f3138b504
- avatar popup list in the top right corener was getting cropped if we have multiple users ( like more than 10=12)
- this patch will make overflow auto and add scroll otion to tackel this issue
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id57539cb91a7f4a2a3766e6d01f0e6a00d3af92a
- jsdialog not getting close when we change tab
- this will close all dialogs whene we click on tab or change the tab
To test this patch
- add 2 or 3 tab sheet in calc
- add `autofilter` in any calc sheet tab
- open autofilter popup
- change sheet tab
Before this patch:
- popup not getting close when focus goes away.
After: - all dialog should be closed now whene change the sheet tab.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4eb308e499853a6e1d86b8dc7f60aa938e9c03b9
The old marker is stripped away when Chrome sanitizes the incoming
clipboard HTML. We used to go with both markers to allow an incremental
conversion.
By now, there are no remaining consumers of the old marker, so remove it
before somebody would depend on both markers by accident.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ib9dd0e7cf64e1a99d6038a179651ef5e114c6f8b
It was a dependency of "pako" package, which it was removed.
Change-Id: Ia35b4c4ff9ee5e9ab1f09da398f6d93e51d24a1f
Signed-off-by: Henry Castro <hcastro@collabora.com>
It seems that commit 2d7743cb73
sidebar: initialize after recover from idle
Introduced a regression, in multi user case sometimes
sidebar is shown/hidden by other users. Also app was
slow sometimes what could be a sidebar reloading all
the time.
Revert previous single-init on docloaded and use dedicated
reconnection code to reinitialize sidebar.
This should still fix the problem that when doc become unloaded
with sidebar opened - after reconnecting it was not possible
to close.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4c66d6e7ca0998ea4461ebca1aa401ca4d65a4a9
Change from commit 85ff10db7a
calc: avoid view jump when using formula wizard
wasn't enough to fix the issue. When we receive grab_focus
action for widget which is hidden outside view - browser
will move the app view leaving blank space on bottom.
Steps to reproduce problem:
1. open spreadsheet
2. open function wizard (Fx icon next to the formulabar)
3. move dialog so it is almost completely outside view (edit field
with focus has to be outside view)
4. select some function and click inside edit field for it's param
5. click on the sheet content
Result: view jumps and moves everything up
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I02c5e7432f46d20ccb8ccb6d84395dddb6eb5409
This issue can be reproduced in spreadsheet with split pane
where some cell is merged and longer than a visible area.
Then every click on that cell will move view to the
beginning of the cell - we don't want that.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5649b8a24f0948d08ca5cc5b71f39844d620b52e
Steps to reproduce problem:
1. open spreadsheet
2. open function wizard (Fx icon next to the formulabar)
3. move dialog so it is outside view partially
4. select some function and click inside edit field for it's param
5. click on the sheet content
Result: view jumps and moves everything up
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0555fb72a1dcf6de5e969994229e7a36b7811028
