After you have sleected a table on a text document in the iOS (and
Android) app, you are supposed to be able to tap the "header"
rectangle that is painted for each column and row, in order to select
the whole of that column or row. But this worked only in web-based
Online with a desktop browser, for clicking it with a mouse.
Was much more complicated than expected. But now it seems to work. One
needs to use Marker instead of Rectangle.
Change-Id: I4f701c70dd4edce6a3edb6fcf9feffa7b7969a8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87079
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
The android browser application changes the orientation when the
soft keyboard pop ups, it has been given a heuristic number 2/3 screen height
to hide the slide sorter, this is because there is a header size
that show the URL bar and it can be improved to the equal screen size of the
native Android app.
Change-Id: I182795fe698bf191cd5b675c1768820ab78b1602
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/85333
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
- make sure document container has doctype class every time
- set auto cursor for spreadsheet and presentations only
Change-Id: I2cb7b0bdaefa51e01745291c78501a7495da2289
Reviewed-on: https://gerrit.libreoffice.org/85515
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I04bbf704c981d80b04f2e003905129b857b28316
Reviewed-on: https://gerrit.libreoffice.org/85376
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
The browser has to move the sidebar to accomodate
scrolling, and this movement makes the sidebar
overlap with the document (specifically, the
scrollbar of the document) and causes other visual
glitches.
We now display a scrollbar at all times to make
the sidebar width fixed and also to avoid flickering.
This is the only portable/reliable way of avoiding
flickering/jumping-around due to scrollbar showing
and hiding. (Previously we had extra space in the
parent, but at least in Chrome it now always pushes
the canvas left when showing the scrollbar anyway,
so we gain nothing but having a thin margin on the
right, and we still got shifted left/right when
the scrollbar show/hide.)
Change-Id: Icbec841ffa4cec255e59f547530728f076d2877e
Reviewed-on: https://gerrit.libreoffice.org/84713
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Based on information from UNO ViewRowColumnHeaders messages, this draws
the grid lines with Leaflet's SVG polylines, in a background pane.
To prevent visual glitches on touchscreens, this also reverts parts of
26aad36771ebd5a304b763912184acd2ea26dfdf - that introduced a regression
that prevented 'dragend' events from being fired when inertia-dragging.
Instead, inertia drag is disabled in the L.Map constructor.
[ Miklos: cherry-pick these early as they prevent automatic merging. ]
Change-Id: I86c68214822a0a2c2f8ced82ccf5a6c201e2cf04
Impress document
When mobile device change orientation the client browser will apply the
corresponding @media rule.
Change-Id: I96b9d8fe7152833287de1be3a81d7423d22fc4c9
Reviewed-on: https://gerrit.libreoffice.org/82014
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Use the CSS class selector to modify the bottom properties for
each tile layer document, so adjusting values for portrait or landscape
orientation not be so complicated.
Change-Id: I900ef5c4ec3f770fd802a23238fdd9e6eb838772
Reviewed-on: https://gerrit.libreoffice.org/81928
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Adjust the CSS property readonly at the bottom and change dynamically
the document size dynamically to show the slide sorter in view mode.
Change-Id: If49d682bcd1eed94443a5d8f8b20420744ba60f4
Reviewed-on: https://gerrit.libreoffice.org/81691
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
slide-sorter element
Unfortunately the static properties affect the spreadsheet and writer
views, and it is prefereable to change it dynamically when the impress view is
loaded. So the other views will have an empty slide-sorter element.
Change-Id: I03a969c6de74999509314184a4aad9bc5c9e3380
Reviewed-on: https://gerrit.libreoffice.org/80546
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
In order to show a slide sorter, it is necessary to reuse the code that
it is working for desktop view.
changes:
* modified the @media properties of the slide sorter container element.
* added new @media properties for slide-sorter element.
* changed the axis direction to 'x' for the mCustomScrollbar
* changed the calculation using left, right and width properties for the
direction 'x'
* added options maxWidth and maxHeight size for the image preview,
default 60, 60 for mobile case
Change-Id: I23a83c831c9aa21ab2876f9d1875c7428c17d18d
And merge a single z-index property into
the main css.
Change-Id: I0a8ed76c98b46052b2cf4b32cfcae498c1615584
(cherry picked from commit 7ba1f6a12c6c8797b3d832faf540d4914b6f219b)
And resize the sidebar div to slightly shorter height than
the content area to avoid scrolling the sidebar unnecessarily.
Change-Id: I5cedb54a573f90097bfefd9a0099375e13a76a3b
(cherry picked from commit 9bd92971dc34508091133024bcabd3043e0b6ab3)
Otherwise it always stays 400x600 and things get cut off.
Change-Id: I999ef1f852f933ac447d500d922e6d38cb028459
(cherry picked from commit dee28b6b1eae2c5faf18c3e7cf7dd2264b05f833)
* Make it work with the menu fold / unfold button
* White background + a grey line separating the document area + the
sidebar
* Use CSS instead of manually setting the properties in some cases
(cherry picked from commit d1ba38386c2c8367213afd47d66f992870fa7207)
Change-Id: I2ba7201075637ebdcc2b9f7319aa59317631aba2
Add 'Resolve' button to annotation context menu
Add 'Resolved' indicator to comments
Change-Id: Ie43e247635a14d3407535e02ec2012f0809d425c
Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/76757
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
This adds:
- support to freeze movement to x or y axis when dragging the
marker (depends on the marker type - column or row marker)
- change marker on hover, which uses a different image, which is
solved in css
- change cursor to col-resize / row-resize when howering over the
marker
Change-Id: I63bf5e82860ef75f2dfde31ee2ab7ede6f61ce70
Reviewed-on: https://gerrit.libreoffice.org/77652
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
This adds table markers for resizing rows and columns if the user
has the table selected or the cursor is in the table. The code
reacts to the callback "tableselected:", where the markers are
created for each column and row, if the payload (json) of course
has any data. When the marker is dragged, a uno command to resize
the table column or row border is send to the core.
Change-Id: I9b21d09639c1b2be70a1a897f9e3340b453d847e
Reviewed-on: https://gerrit.libreoffice.org/77360
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
This breaks cursor positioning with the mouse.
Was introduced with 0576a3cced
Change-Id: I85abca224d2bc9d365443bd87c6793db1900e2a4
Reviewed-on: https://gerrit.libreoffice.org/76578
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Also add some space between the ruler and the document frame
Change-Id: I75a3e4668d03cf44b235082cd7d8c24672209262
Reviewed-on: https://gerrit.libreoffice.org/72339
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
The entries in the native edit menus appeared underlined for me
because I had turned on “Button Shapes” in Settings > General >
Accessibility. They are not supposed to be underlined normally.
Change-Id: I9b85774f3c8300e014092f6ea08953a404156899
Not icons, but white text on black background, etc. This is how the
native context toolbar (whatever it actually is called in iOS) looks
in Notes and Pages and in text input fields in general.
Change-Id: Ibfa149fa8a951046de25c71022ea5c5684cfcc02
