This renaming will allow the mobile wizard to be able to find the
svg images/icons corresponding to the uno command
affected context menu/Mobile wizard:
Row header
Column header
Sheet tabs
Change-Id: I94198096085ebe1f482a70d84c8399c34f9e0ea0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87713
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
By now, we only emulate mobile layout, but we are using
simple mouse events (click, rightclick), not touch events.
Later it might worth to investigate, how to emulate touch
events.
Change-Id: Ib7d032933c50221173bbc749f0653d7d777884b1
- realign plus icon
- readjust top elements' position
- avoiding changing border from #toolbar-wrapper as this would affect readonly mode
Change-Id: I010aaa7b3bd25bce1fe386854c0a7cd0b9c7331e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87675
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
select any row/column now try to open the context menu
by right-clicking row/column header and perform some action
Action will be performed on the originally selected row/column
(same goes with the mobile wizard)
Change-Id: I2d2a7f871b1562d4706e9ea1e4382968a4502583
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87658
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
This patch fixes non-showing character properties
on calc, also a bit improved the related function
in terms of performance.
Change-Id: Iba3f32ec5322225dd0d34bb56173151c52156564
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87610
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Under Cell Appearance properties, cellbordertype, borderlinestyle,
borderlinecolor items are removed due to not working properly.
Change-Id: I56fd71355051a0b1dc20f6dc86090e2f35520b3a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87608
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
This reverts commit 2f861612e9,
which caused the formula bar to be hidden, and rows to get
misaligned on tablets.
Change-Id: I14826fccb23283e3f7462eee7aeb43fb6d2eaeaa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
On mobile, we now do not show the keyboard by default
when the user taps the cell in Calc or a text-area in Impress.
Instead, the user should double-tap. This is especially useful
when the user selects the cell on first tap, then double-tap to edit.
As for Impress, editing-mode is enabled only by double-clicking,
so showing the keyboard on mobile on single tap is not helpful
as the user can't edit just yet. So it makes sense to show
the keyboard only on double-tap, when the slide is in text
editing mode.
On desktop and for other document the behavior is unchanged.
Change-Id: I4206291f60656391d061387f7bbad1b6e3caf80d
Impress toolbar now reflects the state of the sidebar.
All sidebars now show correctly for Impress docs,
except for the properties deck, which conflicts with
the sidebar button.
Change-Id: I8802e5e35b388df20ca21c4f756b4d95197de570
Use the clipboard code to generate the HTML of
the selected text, so we can check the font properties
in the document.
Change-Id: I43e5325b7fe0a9fda073c43335231e014374d6c2
- Add exeption
- Even if there is no image passed add it manually and adjust HTML sctructure so to be consistent with other menu-entry-with-icon elements
- Add inserttable monochrome icon
- pass optional argument data.id
Change-Id: I34536272d3ef5742895c4db5a52058fe6558f837
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87633
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
In mobile view context menu replaced with wizard for calc column header
Change-Id: I3ea1dfc79815d9fde61d5d22e7a8b09a98a8bc63
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87287
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
In mobile view context menu replaced with wizard for calc row header
Change-Id: Id85eefacbe598a3a041dd92dbe6b3c85e8997b4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87286
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
only the image button was clickable which was
confusing where to tap on mobile. This patch
changes the hit area to surrounding div instead
Change-Id: Idfa2533b5daaa9df8f288eab5f9bb4b9e861d822
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87609
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Change-Id: I095c23c086c026995d1433e9f3efc1adfef2a8cd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87601
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
after new callback function route for the mobile wizard,
noneexisting images were being added to menu
Change-Id: Iec3f817cc218d7a4cb9b92370f092fdf6dc18d70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87228
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Contain the textInput instance in map and use
the available focus() and blur() functions instead.
Ideally these functions would be renamed to something
more accurate, but that's a big and risky change.
Note that there are many cases where the textInput is
still accessed directly. These are harder to encapsulate
just yet, but we should move in that direction.
Change-Id: Ibc14fcbde14b54a9633cf534e11072f6fd383403
In mobile view, the 'spreadsheet-toolbar' toolbar is not needed anymore
Change-Id: Ie4dd518cbb4db62a3b3d0da812e37219d8a8bc4b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87548
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
- Replace content (symbol character) with a darker element (SVG)
- Avoid adding new asset when we can simply apply transformations etc
Change-Id: I3c9ecdfd000723a30c28cb92ac752bd98823bcb7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87540
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I61e2bdb24e082d095a832dec29f406869f21f986
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87538
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
It checks for the state of the .uno:Orientation which
comes from core commit 7285b040ccf619210207c555981beb6df64cfc5a
Change-Id: Idc20f8b6f7c5ba10f5ce4726f4bc4408116dfe6f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86704
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
Since the Orientation commands (Portrait and Landscape)
can now be accessed from the hamburger menu.
Change-Id: I5d07a6ac8df3e5f4e28dbd5a71d58bde5613251a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87371
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
In the mobile wizard, if there are no icons for a menu entry, firefox
will display a broken image even if we set alt='' in img tag. Lets add
an error event handler for img(icon) element to not display
anything. This seems to be the general solution that works both in Chrome
and Firefox.
TODO: We may want a css-only solution probably by having a custom transparent
icon to override the broken-image icon.
Change-Id: I879035ca847c4c52611eccfc20834866c0144e02
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87373
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
