Commit graph

4731 commits

Author SHA1 Message Date
Bayram Çiçek
5b7f27f1e4 add auto fill popup UI
AutoFill popup has two options:
- Copy cells
- Fill series

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I08ad88afad1bb6bd2d746a9a8964f1b4446ae7c7
(cherry picked from commit 91f080976f4c1d643db1b217b605f59742f13bd0)
2024-05-28 14:07:09 +02:00
Darshan-upadhyay1110
3591fba03e Fix state update of input element
- Input elements in jsDialog does not change state after CORE update message
- this is because in previous commits we changed input element structure.
- we should Synchronize the child elements with parent.
- this patch will Synchronize disable state of parent with it's child elements

Change-Id: Ice94de732dc7392f3c79100e6a2d60480294eb0e
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-28 13:28:18 +02:00
Darshan-upadhyay1110
bb15a1d05a Close mobile icon should be hidden in desktop
- if we switch to compact mode & server get reconnected some icons are visible in desktop which should be only visible in mobile view.
- in control.toolbar.js we call updateItem method for icon in mobile
    - `toolbar.updateItem({id: 'closemobile', type: 'customtoolitem', w2icon: 'editmode'});`
- after this updateItem call we should also check all condition about that item like
        - item should be visible in mobile or not
        - item should be available in tablet or not etc etc
- this patch will do that checks
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I11adc3d94cacd4afe85e177d050ccc73f3112872
2024-05-28 13:19:49 +02:00
Pedro Pinto Silva
449b35b64c Color pickers: Fix image size and alignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib4391a2dce205928309c94b86ad7c8e759eaffa1
2024-05-27 15:01:10 +01:00
Pedro Pinto Silva
429070a224 Notebookbar: Home: Remove unnecessary CSS and fix fontnamecombobox
- Remove all the rules that are not longer active (better solutions
were implemented)
- Remove also #fontnamecombobox.notebookbar declaration. Not only top
and padding were not applicable but we were setting the width which in
turn was creating a different gap (bigger than the grid gap) and
moving icons out of place

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibf608f41d25beb3120b5b6d9f032673697f018b8
2024-05-27 15:01:10 +01:00
Pedro Pinto Silva
da051e2178 CharBackColor: Remove legacy CSS rule, no need for extra margin
- This has no effect anymore since the id has changed
- Furthermore, the fix is not needed anymore since meanwhile impress
and draw has seen new button additions (shadow, fontwork) that renders
this obsolete.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id1990e9c6e227cf2f2567b18e7826fee81865a69
2024-05-27 15:01:10 +01:00
Szymon Kłos
0dd2c55adc jsdialog: add queue for snackbars
Snackbars will appear one after other now.
Add forgotten SnackbarController to Makefile.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf5ed98f8384c2688adc9653948137f23fb0ce3e
2024-05-27 13:45:08 +02:00
Poe Mon
97ec41c0f2 Translated using Weblate (Japanese)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Poe Mon <p.poemon.awitd@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ja/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I558b81c08e65f2a58eaf8d8581813f3c237fc81a
2024-05-27 10:04:39 +02:00
Sabri Ünal
e2b238aba9 Translated using Weblate (Turkish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Sabri Ünal <yakushabb@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id4337eac79282f315de7ced849ae686d906a5778
2024-05-27 10:04:39 +02:00
Yaron Shahrabani
7962411b5f Translated using Weblate (Hebrew)
Currently translated at 70.2% (336 of 478 strings)

Translated using Weblate (Hebrew)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/he/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icc48a9c6f488090a1a03e3704053ff26a41f3cd4
2024-05-27 10:04:39 +02:00
bittin1ddc447d824349b2
f322995c59 Translated using Weblate (Swedish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: bittin1ddc447d824349b2 <bittin@reimu.nl>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5a6fa8532f559069b07e7fb4cb4802e21c9220c4
2024-05-27 10:04:39 +02:00
Ali
fe1de9cbf7 Translated using Weblate (Arabic)
Currently translated at 100.0% (478 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (110 of 110 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7a63416359b15bd99dde457b06a1912e6d434b75
2024-05-27 10:04:39 +02:00
Darshan-upadhyay1110
5c7ee9e0c3 Replace ruler height hard coded value with css-variable
- Replacing the height value with the CSS variable will help maintain better consistency.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0627778919885c8ee0a989f0b47b976304892585
2024-05-24 21:10:52 +05:30
Szymon Kłos
34850e7bbd jsdialog: create separate controller for snackbar
Reduce size of UIManager and also it will make it possible
to add queue of snackbars to show.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I221049f48f471d85795ede7922a668eef4c7f0df
2024-05-24 16:20:39 +02:00
Szymon Kłos
500997fdd9 jsdialog: move types into single file
To deduplicate definitions

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3c542e192f31ece69cff08cae5dd61e32b478420
2024-05-24 16:20:39 +02:00
Darshan-upadhyay1110
0a9968a074 Handle case for items only available in dark mode
- we have now some uno item present only in dark mode.
- so there is no resone to check image exist or not for light mode.
- we will set dummy url for those image elements.
- this patch will consider those items and will not throw error if icons are not present light mode
- Example: please see `invertbackground` item in view tab after change to dark mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I6aa2fc9d7bdd356617a808f17d14f77bc8453496
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 11:48:27 +01:00
Darshan-upadhyay1110
8396afa1af Statusbar: Set image to false for zoom menubutton
- `zoom` menubutton is not a image to represent so we will make `image: false`
- this pathc will fix image not found error for `lc_zoom.svg`
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I39c2d68f4b0afc7b3831c2082be2ae1a315b2d8e
2024-05-24 11:48:27 +01:00
Darshan-upadhyay1110
6dfeffd53a Add missing dark mode icons for 24.04
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ibf42fc04f953769790e9bc4145d8fe4f6e994298
2024-05-24 11:48:27 +01:00
Pedro Pinto Silva
9c766bb9ee Comment: Add missing icon alias and remove unnecessary duplicates
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie1ea6e5be762ee5d1650cf8ccb0a408ce6340c08
2024-05-24 11:48:27 +01:00
Rashesh Padia
b9ef48310e mobile: add save progress bar on top toolbar
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I14c8a715e922d00b2cfd8f67afd7fc2df2dd9d38
2024-05-24 09:16:39 +01:00
Pedro Pinto Silva
7fad9a6a44 Formula Wizard: list view: use smaller icons
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I84076a6a3b85fe3d61e849946bd8f9f8e7638985
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
1340fdcdcb Formula Wizard: Fix search input field width
Before this commit the search field wouldn't fill the available space.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If079942b1e594a0461835e52ad65827a639c6173
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
701422de3e Formula Wizard: Tabs: Make tree view transparent
Make those transparent since color would just look odd within tab
background and more importantly because they offer no interactivity.

----

Currently the treeview accepts clicks (not just the expanding and
collapsing) but also children accept clicks but do nothing. Probably
we should fix this.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifc53d0099a19103b15895dc8b76127034b05f3c1
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
dba0e711b5 Formula Wizard: Tabs content should extend all the available space
- Use all the available space on both tabs' content
- Fix Structure tab's content
  - make the tree view extent the available space (1fr)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib1c9e852a3a292f795675365040318c1d5602f35
2024-05-24 08:44:41 +01:00
Pedro Pinto Silva
567f6def33 Formula Wizard: Tabs: make it clear that this is tab group
Before this commit the tabs in this dialog were being rendered as top
level dialog navigational tabs. However, this is not the case. Add
background and border to clear separate one and the other.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I158ee1e1d4d163417f5055459adfeac47b6ab437
2024-05-24 08:44:41 +01:00
Darshan-upadhyay1110
b9bef83487 Change vertical ruler code to typscript
- remove use of Leaflet's
- change working js code to ts
- please check above commit messages for understanding of implementation.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Iee222bbdb343730014260c1785a90e68c6dedfd1
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
c25e8d78cc Reset Top/Bottom values of page margin if view section changes
- we are string previous response values of top/bottom margin
- resone is because we need that values to pass after dragEnd.
- but if we change section foucs from Header to Footer or Text area to Shape then we need to reset that old values with the incoming response
- this patch will do that.
- for `table` we will hide the marker as we do not need that. table already have there marker to resize.

- added some edge cases like if start marker goes beyond end marker
- start and end marker should not cross limit beyond page top/bottom

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Iffd3cbf08806666b858d9c3da7ca6362085223dd
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
c3c7caaf0b Set upper and lower margin after drag in vertical ruler
- Send Upeer and Lower space value for header and footer according to drag
- we need to send both values in core.
- even if we drag either upper or lower we will send values accordingly but both values should be updated

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4ef3287c5afe6e1eef5aac225d3c06ca9d1fd9e5
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
4a13987fdd Add markers to vertical ruler.
- As we do for horizontal ruler we need marker that will change margin of Header and Footer of the document
- current patch will have design where user can see markers in vertical ruler
- you can drag and change potition of marker.

Improvments that still need to do:
- user can drag but it will not change size/margin of header/Footer
- next we will pass info to CORE according to corrdinates we got from drag
- it will update text potition on document

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I9663a75d5c84eace784266c76be12abd762434bb
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d41d73382d Add pageoffset calculation for vertical ruler
- Before this commit vertical ruler stays only in first page
- if we jum to page 2,3 so and so ruler won't change it's possition
- but i have added some calculation based data we recevice from CORE
- calculation:
    - we need to consider pageoffset for vertical ruler
    - check if cursor moves to other page
    - then add total Height of previous pages.
    - for Ex: if we are at page 3 then ruler.marginInlineStart should additionally have total height ( page1Height + page2Height)
    - this will place ruler to exact possition where we want
- next : add Top and Bottom margin drag
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Ie2a2d4e5f0cfd627bcafd81230ad33b7aec280a2
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d3d7f48225 Add vertical ruler for writer
- add new LOK callback for vertical & horizontal ruler update

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c0e26f22072de4612e128d58ac41b629be82807

Add vertical ruler and implement margin calculation

- Added new vertical ruler file to separate it from horizontal ruler calculation
- For vertical ruler we do not need tab stops so removed it.
- next stpe will be to implement add top and bottom margin by drag

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8186c874ff59571db7a75ec4c31f81fc655ef301
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
9bfc60b8fe Improve color contrast in application canvas
- improved color contrast between text area and edge.
- changed --color-canvas for contrast between text and edge area.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8dd8296901da6ee5ce59704f7e27d8c37d29e8b1
2024-05-23 14:14:45 +01:00
Gökay Şatır
b4bc0a71c4 Problem:
* On Calc, when user starts editing a cell and uses zoom, core side sends "cursorvisible: false" message.
* This hides the cursor.
* We also hide the cursor while user is zooming in / out.
* But the core side zoom doesn't set the opacity back.

This commit fixes the input handler's visibility issue.
But the core side will continue sending the cursorvisibility message.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ibf679c132f96dc3504de17d00958133bd45244fb
2024-05-22 11:53:17 +03:00
Gökay Şatır
e5256c265d User app.file.textCursor.visible instead of _isCursorVisible.
Duplicate functionality removed.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Id0bc972d20e6974dc2671696830a55dcb35ade7a
2024-05-22 11:53:17 +03:00
Hubert Figuière
2643992f95 Translated using Weblate (French)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Hubert Figuière <hub@figuiere.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icc016591763db192e7b4fc9b01700b02593d2426
2024-05-21 16:13:24 +02:00
Pedro Pinto Silva
8eba634231 Translated using Weblate (Portuguese)
Currently translated at 100.0% (588 of 588 strings)

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9c45a233e479ea10c9de092265afee238a793b75
2024-05-21 16:13:24 +02:00
Ali
e3cb73d1fc Translated using Weblate (Arabic)
Currently translated at 100.0% (110 of 110 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/Android app
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8f8cc2a8f27e50d3a60b6a8ba3f8adc9e8dbd6d9
2024-05-21 16:13:24 +02:00
gallegonovato
89cfe8463e Translated using Weblate (Spanish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0ed063594644f5d26c7ad71d7c3c80365adbb690
2024-05-21 16:13:24 +02:00
Matthaiks
f458df9463 Translated using Weblate (Polish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I632037308291800d990d37ff689add6d37769f6d
2024-05-21 16:13:24 +02:00
Darshan Upadhyay
3a3518b454 Translated using Weblate (Hindi)
Currently translated at 26.5% (156 of 588 strings)

Translated using Weblate (Hindi)

Currently translated at 20.0% (1 of 5 strings)

Co-authored-by: Darshan Upadhyay <darshan.upadhyay1188@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/hi/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hi/
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5cb618bd36c160658d61cf70cb6f6b51d7be628c
2024-05-21 16:13:24 +02:00
Andras Timar
c9cca42137 Translated using Weblate (Hungarian)
Currently translated at 100.0% (588 of 588 strings)

Translated using Weblate (German)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4a6fe12f0bda8dc1c3aa2c8761f11b8e7adb0d0e
2024-05-21 16:13:24 +02:00
Lily Logua
e2dba9956a Translated using Weblate (German)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Lily Logua <lily.logua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2a4d903f72fefdd474f5daa824b14a0e9ec8ee5c
2024-05-21 16:13:24 +02:00
Pedro Pinto Silva
0ad09fda60 Impress: fix slide preview animation and color
Replace svgs introduced in 3efbfaeccd
- Animation and smiley svg: Use gray
- Don't use a smiley face, use instead something more semantic such as
a checkmark

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I38e341ae393c59e785adff9207f8111d68c341ef
2024-05-21 15:06:45 +01:00
Gülşah Köse
a73991b7f3 Hide Invert Background button until implementation
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I061901d748641ffbb40f60e2fa03fcc31df2cd7e
2024-05-21 13:44:25 +01:00
Gökay Şatır
85b93bfb9d Fix coordinate calculation error of cell selection area.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5f130924455cd29018baf6fbc14c1ceffd29cf46
2024-05-21 14:10:13 +03:00
Gülşah Köse
2acc5a94c9 Introduce new formula auto complete feature
When we start to type a formula in a cell eg: =S
We will see the possible function names in a popup.
If we move with "ArrowDown and ArrowUp" and enter, or direcly select a
function with mouse, function name will be automatically inserted into
cell. Then we will see the usage details of the selected function in
another dialog.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ic06ca0d904770e95bb85ccdf9a73f60b7d5c5eb0
2024-05-21 12:09:20 +01:00
Rashesh Padia
a6cf4eb118 zotero: fix: can't select language or store as option in citation style
- problem: in combobox widget we were always passing the
`_defaultCallback` which will send `dialogevent` to server but in
zotero's case the callback is different
- also fixes some `undefined type` errors

Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I7bd7aff6a1a3a9715123c1335ea83ab13fd7b22a
2024-05-21 16:06:27 +05:30
Rashesh Padia
93e9259aaf css: decrease max-width at which filename is hidden
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: Ibbd2aed0739af6627d982db954487ad98159500e
2024-05-21 12:34:29 +02:00
Gökay Şatır
f480e10d75 Fix cursor visibility issue.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5ba8a44b51592b52ed9bfc378d4461b8fc7dccd6
2024-05-21 12:45:40 +03:00
Miklos Vajna
a161ee30f4 cool#9072 browser: better error handling when navigator.clipboard.write is advertised but fails
In case an integration doesn't allow clipboard interaction via
<https://sdk.collaboraonline.com/docs/advanced_integration.html#allow-the-clipboard-permission-query>,
we end up in a situation where navigator.clipboard.write is not
undefined, but is broken.

By the time navigator.clipboard.write() fails, it's too late to fall
back to the old copy code, as the security context is already gone.

Fix the problem by improving the failure handling: show the popup to try
again copying, remember that navigator.clipboard.write() failed and
prefetch the text selection, so next time a copy is tried (via the
keyboard), the selection doesn't need re-creating. (Normally the
selection change would trigger the prefetch, so select->copy->copy-again
would still fail.)

Note that paste doesn't have a similar problem, since there we always
try the old paste code first, and only use the new paste code if the old
one fails.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I12ea4810395970421000d213744d1838213c7a07
2024-05-21 09:47:54 +01:00