At the end of the test we validate getting
the clipboard contents after disconnecting
and unloading the document. Unfortunately,
this relied on the speed at which unloading
happened.
Now we wait for the document to unload,
via the callback, before proceeding.
This makes the test more reliable and
harder to pass accidentally.
Change-Id: I4b7f4483c6827dc56689f739ec41a197759413f1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
It tries to bring up formula bar, which is unsupported,
and causes issues.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I9aaf445fde9ed5fa507e503e72319b6c7a146e44
in the future we can make icons different for every type
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I039f412e9d89b08b86ef9fe0b45bc868343de122
The code that is conditionally called based on that check verifies
using ThisIsAMobileApp anyway.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ic86cf102e061d90bedecb6efcb4ef171dc494004
To switch to edit mode in a cell, firstly we have to select a cell.
During that selection Clipboard (here _clip object) has a context
normally. When we do double click to switch edit mode, that selection
should be invalidated because actually we don't select anything yet
in that case.
Here we clean the selection when we switch to edit mode.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ib8d5bedba3a6d9c05a26a73edd81b52cd94e3358
To show a checkmark for "Freeze Rows and Columns" item on hamburger menu,
we have to set "checked" propery of the item according to uno command's
status.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Icfc2ac07a84ed8a843b3bb8b2fe4c75de8ad9233
exclude notes, full text and snapshot entries
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib2183d95c4b0f90d3fd80504625f989ccafe3fb9
This creates the scenarios where the
storage is read-only (i.e. UserCanWrite=false)
and we have an editable document.
Change-Id: I2878e5e27bc3c3a809dde16f7c39a5ccda4a35a3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This ensures that when the Storage has
UserCanWrite=false no editing can happen,
no new versions could be saved, and no
attempts to upload would happen, even
on view-only documents (by means of
allowing comments).
When the Storage has disabled writes for
the current user/document, we override
the read-only and allow-change-comments
flags.
Change-Id: Ic140fab4f76209fb143f3f5edef70bc3c80cad1b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We need to differentiate between a document
that cannot be edited (due to permissions)
and Storage being read-only.
The distinction isn't always important,
except when readonly is set either by
the client side permissions, or is due
to opening a view-only document (such as
a PDF). Since for a view-only document,
adding and editing comments might be
allowed, while the document is read-only
and cannot be otherwise edited, we
still need to upload it to storage.
This is to preserve the changes done
to comments.
Since we need to differentiate between
read-only Storage vs the above cases,
we use a new flag in Session: isWritable.
Change-Id: I028e7908db7f0f10e5407a45c71d89aaab858390
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This helper is only true if editing of the document
is enabled and not whether or not the document is
writable in storage. Since it unifies isReadOnly
and isAllowChangeComments, which are in Session,
there is no advantage in having it in ClientSession.
It is now renamed to isEditable in Session.
Change-Id: Ib923b6162a8075be145049bc1442c42479c8ce4b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We should always set the read-only flag when
the storage disables writing for the doc/user.
Similarly when the user is locked.
This breaks down the logic of setting these
two flags such that it's explicit and more
readable.
Change-Id: I99ea19b85a529c08fa50b91fb73bffcfba47f996
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Currently translated at 100.0% (479 of 479 strings)
Translated using Weblate (Croatian)
Currently translated at 99.7% (478 of 479 strings)
Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib32b8d001305efaee88744febf628a67d57b3732
