In the past I've seen very often that for example
commentList section was missing but used without any
check.
This commit checks if section exists before use and
warns if it doesn't so we can see that in the console
logs.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idca23c5327f5b36277479fcd3f44b92920466474
The additional margin was affecting the surrounding elements in some
browsers in the sidebar
Better to not call padding-right or padding-left specifically:
- Better to use shorthand and make sure how the final padding will be
- Better for RTL
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia61d670580258187f9fd538dcc2f2a2e20be3bdf
use the same font-size for listox no matter where it's placeholder
- Multiplying would make it look too big in some places
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6436baea5ed3018e4c4cad6078fdb51bfa0d068e
with refactoring from 2da8de38df1660b205392391ebada7759ee8e2d6
and with the code now in onw place we can now use the 28px height that
was used only in the sidebar to have the same visual component be that
on a dialog or on the sidebar
- Reduce from 32px to 28px (the opposite would make the component too
big in the sidebar)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4d11f74219e55a2a05e0f1c9f70ff9a8c4a88c54
Avoid to place rules within jssidebar.css that should be global
(it should affect any jsdialog class) and let jssidebar-only exceptions
in jssidebar file
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib950f5c13522f3d91139d8eac52b5b4daa22fe05
When using position relative the elements will still occupy and affect
space around. This was flagrant when using chromium.
https://archive.org/download/t-34772-writer-selected-img/T34772-relative-shouldbe-absolute.png
as you can see dropdown with arrow are being dragged outside
Also use margin-block-start to add vertical start margin (e.g. top) to
element depending on the element's writing mode, directionality,
and text orientation.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If580fba061d8cb274a60ad5f780882c772059162
When using position relative the elements will still occupy and affect
space around. This was flagrant when using chromium.
https://archive.org/download/t-34772-writer-selected-img/T34772-relative-shouldbe-absolute.png
as you can see the spinner with units are being dragged outside of the
screen
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I292f83dc4840ceb1e12923a9aaf1fe56dbe14131
When the coolwsd server is ready, begin to
fork the load.js process to start the tile tests
Change-Id: I7846ce013b729eab54e5fd3ab81ce396406bcf0b
Signed-off-by: Henry Castro <hcastro@collabora.com>
To signal SIGUSR2 to parent to notify
that the server is ready to accept connections,
and begin the tests.
Change-Id: Ie936217243aa7a2e836f3d45cb508ede13fae8c5
Signed-off-by: Henry Castro <hcastro@collabora.com>
previously without data in localstorage it started with
compact mode always
- reduce calls to local storage
- unify local storage entry name (no doctype)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2bf4776a6296d2c35ac974b3d108bce5e77a7614
This is a temprorary patch until we can properly
migrate the verification code to openSSL 3.x.
Change-Id: I676ae3b5a1e0d27ef1d253dba2275f7de5fc08ff
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
If I have used a path with symlinks in it when changing directory to
my build directory, what gets put in config.status as ac_pwd is that
path, not a realpath version. That then propagates to
ac_abs_to_builddir and to SYSTEMPLATE_PATH, which is what Makefile.am
passes for the --o:sys_template_path option to coolwsd.
To be on the safe side, do the tmpfonts dance both for the systemplate
path that might include symlinks and for one that has been realpathed.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I7575120090986e6207497c5ce740aedd6075e48f
we preserve original reason,
so setting default reason means always using default reason
and ignoring any other reason
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I837a13a129aa759a319406affc6e89425bf31361
This also makes us sure we are in sync due to
single point of knowledge about UI Mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifefeee90666db7c341da52a7190ef09749b8e3ab
This avoids the runtime overhead of strrchr used
in logged filenames on iOS, which is unnecessary
on string literals, and adds unit-tests.
We also strip leading './' and '../' in other builds.
Change-Id: I56ec722d1400fad9165eb046d1bd8d4438241ca3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Normally these kind of button wouldn't need a tooltip but:
1. Doesn't hurt to add it
2. It helps the user with understanding what that btn does:
- The button doesn't remove the current opened document
- The button doesn't save and close
- The button closes the document
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I45e63c4c7f42d314743702e6ff50b777527c4367
All NB items ids have EachWordCapitalized and are successfully target by
users/partners/users to change image for example, and expect them to be
have EachWordCapitalized:
- Notebookbar: Make rev-history -> Rev-History so it also can be
- Classic: Id remains "rev-history" in the case integrator rely on that
specific lowercase id
- Allow rev-history and Rev-History when checking id (Menubar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7a5a31f78713fe43e1855021652500d0306c5ac4
All NB items ids have EachWordCapitalized and are successfully target by
users/partners/users to change image for example, and expect them to be
have EachWordCapitalized:
- Notebookbar: Make saveas -> SaveAs so it also can be
- Classic: Id remains "saveas" in the case integrator rely on that
specific lowercase id
- Allow saveas and SaveAs when checking id (Menubar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia92a442eadb34c4b4ae374e54835d7866f70df7a
context: https://archive.org/download/repair-doc-close-misaligned/repair-doc-close-misaligned.png
line-height, if the hard-coded px is needed, then it should be the
same value as the width and height so not 28px but 32px
as it's the values used in a.leaflet-popup-close-button.
But better to just rely on the unitless value that line-height can
accept then it will fit whatever the font-size and width the anchor has:
- Fix it by letting the web browsers align the content for us. Web
browser multiplies our number by the font-size value (1 times font-size)
, so no need to depend on specific px values for that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4145231241a9acc540c684971e3bde46adb2304b
The commit message of this commit was correct but it seems I end up not
git adding the latest change which obviously is not initial but 1.
This reverts commit c80d4ca62e.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I999e7e51ee36e4c162cc8d0a15bc9850fdd9c1fd
context: https://archive.org/download/repair-doc-close-misaligned/repair-doc-close-misaligned.png
line-height, if the hard-coded px is needed, then it should be the
same value as the width and height so not 28px but 32px
as it's the values used in a.leaflet-popup-close-button.
But better to just rely on the unitless value that line-height can
accept then it will fit whatever the font-size and width the anchor has:
- Fix it by letting the web browsers align the content for us. Web
browser multiplies our number by the font-size value (1 times font-size)
, so no need to depend on specific px values for that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4145231241a9acc540c684971e3bde46adb2304b
if right clicked on already selected row/column range,
don't reselect the right clicked row/column
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I718a0a727913c38bc506fd2b808fba8feaebb0c8
