Unfortunately, we cannot show the hyperlink pop-up,
in client side based on cell formula, because the formula
had not been evaluated.
=HYPERLINK(A1,A1);
The server should fire event "hyperlinkclicked".
Change-Id: Ie2b743812493e1790b9e54f0050974c585e61e00
Signed-off-by: Henry Castro <hcastro@collabora.com>
Added tablet check for Insert buttons to display on dom or not based on passed condition .
- By default custom buttons will show up in tablet.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I103461b02405bc03d63671b885a31735668d4111
std::make_shared and std::make_unique
are superior to explict smart pointer
construction. Where we have private
constructors, we can't use them.
Change-Id: I492122f58e958113c6e6d31445c6614ad98c89aa
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Using our own http library, we request
cool.html with realistic parameters and
validate many key values sent in the
request.
Change-Id: Ie3c0ac042f64bf5d6ed21354a33efac801b32846
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We have http::Response specifically for
this kind of thing.
Change-Id: I57130754f95c06f5ab958ca373f21763e74cb6a2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The GetCookie was removed due to sensitive
access data because the browser can block to
security concerns.
Change-Id: Ifaeb495202a53125bda9e3705b6e33b7e54e56df
Signed-off-by: Henry Castro <hcastro@collabora.com>
The access token will validate the session
when a websocket is connected to the server.
Change-Id: I008b04a499ab0d85fd6f95fc06a511f800c0bb2e
Signed-off-by: Henry Castro <hcastro@collabora.com>
Provided support for screen reader to report key accellerators
description.
When <alt> is pressed screen reader says something like: "tab control
Home tab selected".
When an accellerator is typed such as "N" screen reader says: "N
Insert tab selected".
When an accellerator for a tab item is typed the screen reader says
the typed letters and the item name as set in the 'alt' attrinute for
the button element.
For instance by typing accellerator for bold style ("1"), the screen
reader says: "1 Bold"
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I64b198f79cb9f7f13dcd1a4fe0890e4317e512dd
On focus away or if NotebookbarAccessibility is disabled then remove accesskey
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I04310f7ee4ab599a0c53c7aceaba459dd7641681
The input field is already being hidden for mobile. For Tablet and
with the increased amount of UI elements on the top bar best to hide
it also. Renaming the document is a quite rare used action when
compared to any of the other top bar actions (switching tabs, open
sidebar etc). Better to hide the #document-name-input when on tablets
instead of trying to fit everything (and end up obstructing tabs for example)
Tablet user can always:
- Use the integration (already used to do many other file manipulations) to rename the file
- Use the in-app Save as can still be used to save a copy of the current
document with a different name
----
Possible future improvements would be to add the possibility to rename
the file when using a tablet:
- Add menu entry and tabbed view button
- Control.Menubar.js something like {name: _('Rename Document'), id: 'renamedocumentbtn'}
- Control.NotebookbarWriter.js add bigtoolitem Rename Document
- Maybe in Control.UIManager.js add a renameDocumentBtn function that
- Creates a JSDialog with document-name-input element + Cancel btn +
OK btn
- Ideally that input element would re-use the functionality from L.control.documentNameInput() -> Control.DocumentNameInput.js
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I968e806a4a9e0018b38b87fc249a57e5af099c78
When Collabora Online is inside iframe and we load
Calc spreadsheet, after few seconds we receive CellCursor
message. In case when user was typing outside iframe in
some textbox - we were stealing focus, what caused
that user started to type inside spreadsheet.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I12a5501be6f59f73830ff9bf25c98a00492b6caa
Simplified code:
+ re-use the bit mask as an inner loop counter.
+ turn alpha only rows into zero length with agreed lastPix.
+ keep lastPix around on the stack.
+ handle odd widths in a duplicate slow-path
Change-Id: Ibc7630f7187ea5f4904c6fed14dda28cdfbf7523
rle: further optimize the pixel reading & de-compression.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ifcaaa45d1de6532b3fd43015c47a37daf56c2ea5
and so this loop never finds anything, the intent is clearly to find
an existing comment in this cell so use the right field for that.
possibly a problem since:
commit 922ae4924a
Date: Wed Jan 26 15:08:31 2022 +0300
calc: Fix new comments do not check tabid on insert
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I11208493ef7eae6a01576d90129b25ed9f792d62
We don't want to dump the whole paste buffer as hex, or indeed any
large mis-encoded string - instead crop to the problematic section
for easier debugging, and no performance hit.
Change-Id: I30518beea436895a42b3429c3cb6e16e2093cca9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Do not wrongly switch part of the UI to edit mode when on read-only
mode. Best to be only remove readonly css class when it's not needed as
opposed to removed it whenever refreshNotebookbar() is called.
Before this commit:
- We were showing tabs in wrong mode (readonly mode) -> every-time
refreshNotebookbar() was called. Thus, initial tablet mode was
appearing with icons and actions from edit mode.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6ad9c8c14e60d4c3513f63b75717db0a124b73ea
Introduce getTailsGroupRect method which will be
different in every implementation but share findTailsGroup logic
using above function.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I321abaa2579bfdff08c8cd4df2e781cd9a28c3d3
I added Headings + updated some wording/examples in:
- Feature Request
so when users submit a "New Issue" to Github, it will look nicer.
Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Ic7c5b0a841d39b2cd2b20c5d4a31846eba0c3f4e
I added Headings + updated some wording/examples in:
- Bug Report (Smoke Test)
so when users submit a "New Issue" to Github, it will look nicer.
Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Id72ed9ac10a6ae935fb5fa4b1001c11683f46672
I added Headings + updated some wording/examples in:
- Bug Report
so when users submit a "New Issue" to Github, it will look nicer.
Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Ie32f2c9a4c6ed47aaf198286a0d39831fa397992
