strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7708 commits 1 branch 0 tags 244 MiB
Commit graph

39 commits

Author SHA1 Message Date
Ashod Nakashian
00a44d6e81 wsd: flush logs before existing 
This is important for when we abort with some explanation.
Often said explanation doesn't show up anywhere to be useful.

Also, issue fatal logs for abnormal exist and use SFL to log errno.

Reviewed-on: https://gerrit.libreoffice.org/57540
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit ad7964393eadb68873b820e0a620fb40f1e1b06a)

Change-Id: Ic67064ef40ef6e93d26e5847ecd32bdd49c3cc8b
 2018-10-16 20:12:23 -04:00
Ashod Nakashian
053161b3f5 wsd: move string utilities into Util 
Reviewed-on: https://gerrit.libreoffice.org/57539
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit fb2671c4145edd4d4e359f0dcf5cc84835487cd4)

Change-Id: Idc578dff4e8ee5e48c1b7780d3feb2d21c6a9b13
 2018-10-16 20:12:23 -04:00
Ashod Nakashian
380c55d9eb wsd: disable tracing after initialization 
The first child had tracing enabled even after
initial startup is completed. This would leak
user details when anonymization is enabled.

Change-Id: I5325e02d1a1078bff6640af85f5672b556c00aeb
 2018-10-16 20:12:23 -04:00
Tor Lillqvist
8ead4af199 Say "TerminationFlag" in logging when that is what we mean 
We already did in other places.
 2018-10-15 15:36:51 +03:00
Ashod Nakashian
b9db83518b wsd: warn when we have no kits and we are not exiting just yet 
Change-Id: I8c19dcea3eb900a989aebac7ef96793af31bdce8
Reviewed-on: https://gerrit.libreoffice.org/55576
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2018-06-14 17:05:46 +02:00
Michael Meeks
03bbe52665 Ensure the forkit does not have lingering threads after preinit. 
Change-Id: I216a03a0ada628189355ebfd4016bf6033430eef
 2018-04-16 20:04:23 +01:00
Michael Meeks
8f134aa1a9 Allow running without seccomp and capabilities. 
There are some significant security trade-offs here which are now
at least configurable.

Change-Id: I1d879d69e91392f4ccf5db250a2277f53df60db7
 2018-03-19 20:46:17 +00:00
Miklos Vajna
e76485d8b9 kit: spell out non-trivial autos to improve readability 
Change-Id: I69b025b08a69c8780d40b39074d7d7abb12cc3af
 2018-02-07 10:18:12 +01:00
Samuel Mehrbrodt
00dc0658d3 Missing capabilities: Add hint to check mount options 
Change-Id: I946df0082b385b2eaaad9c23b9e5e7ac508f64aa
 2018-01-31 11:45:03 +01:00
Ashod Nakashian
95af839fd9 wsd: trace first child's startup activity 
To help debug early failure, log the first
child's statup at trace-level.

Change-Id: I8a6c8fe535bbc971174c0d950a2243460f81a2c7
Reviewed-on: https://gerrit.libreoffice.org/47628
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2018-01-09 13:06:48 +01:00
Ashod Nakashian
94781ec6d9 wsd: log at trace level until first child is forked 
Change-Id: I1b995b4714738f3bffd6dac58cf90ee6f1a32898
Reviewed-on: https://gerrit.libreoffice.org/47565
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-08 05:52:39 +01:00
Pranav Kant
f63858433b loplugin:includeform 
Change-Id: Ib62a7aa61062f00698aa3e8a144438de5c57e53d
 2017-12-20 21:21:05 +05:30
Jan Holesovsky
894c5f2cc2 Warn more about missing capabilities, and advise what to do on SLES11. 
Change-Id: I93587db6fa32c1c505877c20857799be71ee162f
 2017-08-10 11:12:24 +02:00
Andras Timar
ad8bffa04a configure option to disable SECCOMP 
Change-Id: I8120674b60d388a3f85190631469a112c4af9266
Reviewed-on: https://gerrit.libreoffice.org/39408
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2017-07-03 11:43:01 +02:00
Ashod Nakashian
98dd83338c wsd: log jail removal 
Change-Id: I1fef24d66bcab800dc1b4536da781ab8d344586e
Reviewed-on: https://gerrit.libreoffice.org/39463
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-07-03 05:42:15 +02:00
Ashod Nakashian
36fb1e64f0 wsd: new internal command to change config values 
Change-Id: I8b4a573ba7b01ee6e7b3b91a00e12cc744f85fa8
Reviewed-on: https://gerrit.libreoffice.org/38676
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-06-12 06:18:53 +02:00
Ashod Nakashian
6de3adcf9c wsd: pass default rlimits to forkit from config 
Change-Id: I84d271f460f0fb1d03a973107c32265d84bf2841
Reviewed-on: https://gerrit.libreoffice.org/38675
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-06-12 06:18:31 +02:00
Ashod Nakashian
9798eafb8c wsd: random jail paths instead of pid 
Jail paths are now generate from a PRNG
instead of using the PID of the kit process.

The PRN is converted to base-64 and used
as the directory name where a given
kit is jailed.

Change-Id: I8e4bc35d9ccdfdae0e542ab707c417cd29ad52f3
Reviewed-on: https://gerrit.libreoffice.org/37372
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-05-08 04:59:12 +02:00
Ashod Nakashian
f062b2058e wsd: use fast tokenizer 
Change-Id: I477bac24a5e944ce3d747db6e694f2766b44c7f3
Reviewed-on: https://gerrit.libreoffice.org/37370
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-05-08 04:52:23 +02:00
Michael Meeks
36900f7d78 Clear display to avoid potential problems. 
Running --nocaps under massif; it is unexpected to see
fire_glxtest_process doing heavy lifting glx work.
 2017-04-08 13:32:00 +01:00
Michael Meeks
a2398fc367 Improve debugging information. 2017-03-30 21:59:05 +01:00
Michael Meeks
1f5b7b6def Include config layer to override kit config simply. 
The config is read once during the forkit startup. Add a read-only
user configuration layer, and also disable config writing: no
writable user config.
 2017-03-11 21:47:05 +00:00
Ashod Nakashian
57e7d22e28 wsd: logging and formatting cleanup 
Change-Id: I5bfbd517c37b6df864d181abe7c70857815b9ece
Reviewed-on: https://gerrit.libreoffice.org/35082
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-03-11 19:50:08 +00:00
Miklos Vajna
f296c0ffeb wsd: avoid redundant string initialization 
Change-Id: I5ac26d56c3b73e380d26226e83020ace3f1b54f4
 2017-02-14 09:33:23 +01:00
Ashod Nakashian
3fb136170f wsd: extend timeout when nocaps is specified 
Change-Id: Id10b38716cc184bf899120bbe18d9095fd2f48e5
Reviewed-on: https://gerrit.libreoffice.org/34053
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-02-09 04:36:17 +00:00
Jan Holesovsky
ad20adce1a fuzzer: Don't handle signals when fuzzing. 
Change-Id: I2febdf96bcbbd5c6edaf791d99a77674e6f0b0a9
 2017-02-08 21:39:55 +01:00
Jan Holesovsky
04d7ed9d09 fuzzer: Make the shared loolwsd and loolforkit binary actually work. 
Change-Id: If6ee9f22d93aa040f94df86b30fdc8a0a1ad68e2
 2017-02-07 13:27:14 +01:00
Jan Holesovsky
0dac1c4321 fuzzer: Compile a separate binary that contains both loolwsd and loolforkit. 
Change-Id: I158e4b19d0929de03f09645c106aebfdbc44ea74
 2017-02-07 13:27:14 +01:00
Ashod Nakashian
93858c5b9e wsd: forkit removes jails after reaping dead children 
Change-Id: Ia4b8dd85b41fa59ececbed85e35616fee6a02254
Reviewed-on: https://gerrit.libreoffice.org/33678
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-30 05:11:07 +00:00
Ashod Nakashian
f242865c3d wsd: simplify kit forking 
Change-Id: I49338fbd2ccf944493f94a8f2c98750711733f1a
Reviewed-on: https://gerrit.libreoffice.org/32865
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-09 06:21:25 +00:00
Ashod Nakashian
b2160ee3a7 wsd: improved logging 
Change-Id: I9c10803f451b6226c6a15d89acd4758c04042f28
Reviewed-on: https://gerrit.libreoffice.org/32864
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-01-09 06:20:33 +00:00
Ashod Nakashian
ba9ffb4775 wsd: include cleanup 
Change-Id: Id481cfbab6be12a095918bdc7318fb3584345307
Reviewed-on: https://gerrit.libreoffice.org/32548
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-12-31 23:22:15 +00:00
Noel Grandin
4199efc91c convert enums to scoped 
Change-Id: Ic3d4c09dbcec28b4638bb8888f812f970f40a1c5
Reviewed-on: https://gerrit.libreoffice.org/32331
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2016-12-22 09:51:56 +00:00
Ashod Nakashian
1376856107 wsd: logging updates 
Change-Id: Icbee0349a3cfda5a56f8d681c779484e18b98ab6
Reviewed-on: https://gerrit.libreoffice.org/32287
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-12-21 15:01:20 +00:00
Henry Castro
38549b0c9b kit: debug, wait until unique kit die 
Very useful to debug preinit stage when it is
ensured 1 kit process
 2016-12-17 07:56:03 -04:00
Henry Castro
e71c0046e7 kit: save first lokit PID 
This is required to debug preinit stage
 2016-12-16 23:39:08 -04:00
Ashod Nakashian
7a4250b90e loolwsd: terminate forkit when wsd dies 
When we the pipe with wsd is closed we
assume wsd has died and we terminate too.

WSD can fork us anew, if it's still alive.

Change-Id: I669ed717db973b50498a6bc08e1fca59c6563443
Reviewed-on: https://gerrit.libreoffice.org/31337
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-29 02:42:46 +00:00
Michael Meeks
c1a398977f Adapt makefiles, includes etc. to new locations. 2016-11-25 09:58:57 +00:00
Michael Meeks
cca657c8f2 Apply the pre-branch rename script to re-organize the source. 2016-11-25 09:58:48 +00:00
Renamed from loolwsd/LOOLForKit.cpp (Browse further)